[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 Robert Großkopf changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #23 from Robert Großkopf --- Tested with Version: 24.2.0.0.alpha1 (X86_64) / LibreOffice Community Build ID: 06946980c858649160c634007e5fac9a5aa81f38 CPU threads: 6; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded Works in GUI without any problem. I will set this one to RESOLVED → FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 Julien Nabet changed: What|Removed |Added Assignee|serval2...@yahoo.fr |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW --- Comment #22 from Julien Nabet --- Unassign myself, feel free to revert my patch if you think it wrong. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #16 from Julien Nabet --- patch for master here: https://gerrit.libreoffice.org/c/core/+/154524 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 --- Comment #15 from Robert Großkopf --- (In reply to Julien Nabet from comment #14) > @@ -2958,6 +2958,7 @@ interval_value_exp: > non_second_datetime_field: > SQL_TOKEN_YEAR > | SQL_TOKEN_MONTH > + | SQL_TOKEN_WEEK > | SQL_TOKEN_DAY > | SQL_TOKEN_HOUR > | SQL_TOKEN_MINUTE > > > So should we go ahead with this patch (+ adding the other missing Extract > elements) or is there some other way? I would do it this way for all missing tokens: WEEK, WEEKDAY, YEARDAY, MILLISECOND -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817
--- Comment #14 from Julien Nabet ---
(In reply to Lionel Elie Mamane from comment #9)
> I think the EXTRACT function needs to be added to the SQL grammar of
> LibreOffice
it seems EXTRACT is known by SQL grammar,
sqlbison.y:156:%token SQL_TOKEN_DAYNAME SQL_TOKEN_DAYOFMONTH
SQL_TOKEN_DAYOFWEEK SQL_TOKEN_DAYOFYEAR SQL_TOKEN_EXTRACT
sqlbison.y:1774:SQL_TOKEN_EXTRACT '(' extract_field
SQL_TOKEN_FROM value_exp ')'
sqlbison.y:3877:| SQL_TOKEN_EXTRACT
sqlflex.l:218:EXTRACT {SQL_NEW_KEYWORD(SQL_TOKEN_EXTRACT); }
the rule which is concerned is:
2958 non_second_datetime_field:
2959 SQL_TOKEN_YEAR
2960 | SQL_TOKEN_MONTH
2961 | SQL_TOKEN_DAY
2962 | SQL_TOKEN_HOUR
2963 | SQL_TOKEN_MINUTE
2964 ;
(see
https://opengrok.libreoffice.org/xref/core/connectivity/source/parse/sqlbison.y?r=e469a171#2958)
We could add SQL_TOKEN_WEEK, SQL_TOKEN_WEEKDAY, SQL_TOKEN_YEARDAY and
SQL_TOKEN_MILLISECOND but it would be wrong for HSQLDB.
I gave a try, just for "WEEK", with this patch:
diff --git a/connectivity/source/parse/sqlbison.y
b/connectivity/source/parse/sqlbison.y
index 0c5d359d083e..f50d136782ab 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -2958,6 +2958,7 @@ interval_value_exp:
non_second_datetime_field:
SQL_TOKEN_YEAR
| SQL_TOKEN_MONTH
+ | SQL_TOKEN_WEEK
| SQL_TOKEN_DAY
| SQL_TOKEN_HOUR
| SQL_TOKEN_MINUTE
in hsqldb, the query can be saved but when executing it, we got this:
SQL Status: 37000
Error code: -11
Unexpected token: WEEK in statement [SELECT EXTRACT( WEEK FROM "test" ) AS
"Year" FROM "Table2"] at
/home/julien/lo/libreoffice/connectivity/source/drivers/jdbc/Object.cxx:172
as expected of course.
With Firebird example from Drew, it works.
So should we go ahead with this patch (+ adding the other missing Extract
elements) or is there some other way?
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 --- Comment #13 from Robert Großkopf --- Still the same buggy behavior in LO 7.5.5.2 on OpenSUSE 15.4 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 --- Comment #12 from QA Administrators --- Dear Vilos, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 --- Comment #11 from Robert Großkopf --- Bug is still the same in LO 7.1.5.1 on OpenSUSE 15.2 64bit rpm Linux. EXTRACT will work well with YEAR, MONTH, DAY, HOUR, MINUTE, SECOND, because HSQLDB will work with this strings. EXTRACT won't work in GUI with WEEK, WEEKDAY, YEARDAY, MILLISECOND because only Firebird will work with this strings. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 --- Comment #10 from QA Administrators --- Dear Vilos, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 Xisco Faulí changed: What|Removed |Added Blocks|116968 |51780 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=51780 [Bug 51780] [META] Default to Firebird not HSQLDB in Base (for _new_ files) https://bugs.documentfoundation.org/show_bug.cgi?id=116968 [Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 Lionel Elie Mamane changed: What|Removed |Added CC||lio...@mamane.lu --- Comment #9 from Lionel Elie Mamane --- I think the EXTRACT function needs to be added to the SQL grammar of LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 Xisco Faulí changed: What|Removed |Added Blocks||116968 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116968 [Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118817] FIREBIRD: EXTRACT Function - WEEK, WEEKDAY, YEARDAY AND MILLISECOND
https://bugs.documentfoundation.org/show_bug.cgi?id=118817 Drew Jensen changed: What|Removed |Added Summary|FIREBIRD: EXTRACT Function |FIREBIRD: EXTRACT Function |- WEEK, WEEKDAY and YEARDAY |- WEEK, WEEKDAY, YEARDAY ||AND MILLISECOND Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #8 from Drew Jensen --- Sorry, twice in two days I couldn't see the tree for the forest or some such. MILLISECOND is also not recognized by the Base SQL parser. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
