[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2021-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Dipanshu Garg  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |dipan...@iitk.ac.in
   |desktop.org |

--- Comment #13 from Dipanshu Garg  ---
Hi, I would like to work on this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #12 from Timur  ---
*** Bug 134488 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #11 from Aron Budea  ---
(In reply to Timur from comment #10)
> I don't go into explanation of the bug, but I'm in favor of WontFix. 
> It's intuitive enough to press enter after "22 22".
Sure, this is a sample, and not a real document. In a real document perhaps you
have a table instead of "22 22", so you can't go and press enter after that.
And perhaps it's a Word document, there are smaller import problems, and all
you want for it to open and look closely the same in Writer, and if not, be
able to fix it with the bare minimum amount of steps, like adding a single line
break, and not having to do all kind of gymnastics that likely messes up the
document even further.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=66
   ||065

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2020-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #10 from Timur  ---
I don't go into explanation of the bug, but I'm in favor of WontFix. 
It's intuitive enough to press enter after "22 22".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2020-10-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Timur  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|louis.mey...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #9 from Timur  ---
(In reply to Louis Meyrat from comment #8)
> I'd like to take that one, and implement  Mike Kaganski's #2 solution. And
> thanks for the code pointers !
I guess I may remove Assigned, after such a long time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2020-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Louis Meyrat  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |louis.mey...@gmail.com
   |desktop.org |

--- Comment #8 from Louis Meyrat  ---
Hi! 
I'd like to take that one, and implement  Mike Kaganski's #2 solution. And
thanks for the code pointers !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2019-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||difficultyInteresting,
   ||easyHack, skillCpp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2019-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #7 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #6)
> Thanks for the code pointer. Is it an easyhack?

Likely.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2019-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #6 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #4)
> 1. Make only the very first position in the document special...
> 2. Make any paragraph's start special...
> 3. Introduce an "Insert paragraph above this" special function...

Hard to imagine that users can follow the arguments of position 0 vs 1, which
is your point here. So #2 sounds good to me. 

Thanks for the code pointer. Is it an easyhack?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2019-11-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #5 from Mike Kaganski  ---
Or maybe I'm just inventing problems, and option #2 is just fine.

The split is performed by DocumentContentOperationsManager::SplitNode (in
sw/source/core/doc/DocumentContentOperationsManager.cxx), and then in
SwTextNode::SplitContentNode (in sw/source/core/txtnode/ndtxt.cxx)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2019-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #4 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #3)
> Adding paragraphs above moves the object, so effectively the anchor is set
> to the end of the previous paragraph.

As far as I know, there is no "adding paragraphs above" function in writer's
normal text. When your cursor is inside a paragraph, it's *inside* the
paragraph; its position is "M leading paragraph characters to the left of the
cursor; N trailing paragraph characters to the right of the cursor". The M and
N vary, and M might be 0, but the principle doesn't change. And when the cursor
is at 3rd character, and Enter is pressed, no one would be surprised that the
image anchored to the paragraph stays with the first two characters that stay
where they were.

As I said in comment 1, special-casing of position 0 makes sense - because it
might be intuitive; or because it's currently no means to move images anchored
to very first paragraphs without re-anchoring. But the implementation needs
discussing. I see the following options:

1. Make only the very first position in the document special: because for other
places in the document, you always can insert paragraphs before this one by
putting cursor at the end of the previous paragraph.

2. Make any paragraph's start special (may possibly create other inconveniences
for users not expecting that, but I cannot invent a case at the moment).

3. Introduce an "Insert paragraph above this" special function, using
Alt+Enter, *consistent with behaviour in the beginning of a table*. IMO that
would introduce consistency and avoid special-casing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2018-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Heiko Tietze  ---
Adding paragraphs above moves the object, so effectively the anchor is set to
the end of the previous paragraph. So I agree with Aron's change request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2018-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2018-10-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #2 from Aron Budea  ---
(In reply to Mike Kaganski from comment #1)
> Well - technically you are not moving the paragraph, but split the existing
> one, creating *a new following paragraph* with the contents from previous...
> thus it's strictly speaking correct that all paragraph anchors continue to
> point to the paragraph object that has lost its content, but not its
> identity...

I'd say in this case we can safely say the identity moves along with all the
content (though yes, I'm primarily considering the user
experience/expectation).

Interestingly, our Word import is inconsistent, in DOCX files anchor to
paragraph is kept, while in DOC files they become anchored to character (the
first in the paragraph).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph

2018-10-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120469

--- Comment #1 from Mike Kaganski  ---
(In reply to Aron Budea from comment #0)
> If you press enter at the beginning of the paragraph, essentially moving the
> whole paragraph, the shape stays anchored to the empty paragraph.

Well - technically you are not moving the paragraph, but split the existing
one, creating *a new following paragraph* with the contents from previous...
thus it's strictly speaking correct that all paragraph anchors continue to
point to the paragraph object that has lost its content, but not its
identity...

I see the point from user's PoV though.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs