[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5873 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 --- Comment #11 from Xisco Faulí --- @Noel, thanks for fixing this issue!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #10 from Xisco Faulí --- in Version: 6.3.0.0.alpha1+ Build ID: e7fb44b8c86b4dce1d4c6f15752cc3bf62b14888 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded it takes real0m15,577s user0m14,067s sys 0m0,674s while in Version: 6.2.5.0.0+ Build ID: 6c3ceaf3e4d59c658d0f9e4e1b22204be25f74e2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded it takes real0m3,085s user0m2,390s sys 0m0,286s -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 --- Comment #9 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/319c57d2af5d26d3910db4b02dca145d8881af44%5E%21 tdf#120837 File saving at least 5 times slower It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #8 from Buovjaga --- Created attachment 150879 --> https://bugs.documentfoundation.org/attachment.cgi?id=150879&action=edit Perf flamegraph Graph plateaus are similar to bug 113042 (compression) Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: 1fee3f1da6291bfbcd75455512726215d41b3e83 CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 18 April 2019 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Buovjaga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||3042 Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Telesto changed: What|Removed |Added CC||qui...@gmail.com --- Comment #7 from Telesto --- Adding CC to: Tomaž Vajngerl > commit e02efb621fe672aa52e56caa916cf5c3fd0a9cb8 > Author: Tomaž Vajngerl > Date: Thu Feb 1 15:28:53 2018 +0900 > > Change bitmap table to store XBitmap instead of GraphicObject URL > > As we want to get rid of GraphicObject URLs for the more robust > image life-cycle handling, it was necessary to change the way > bitmap table stores and handles images, so that they always > store a Graphic object (wrapped in UNO object that provides the > XGraphic and XBitmap interface). > > In addition this changes loading and saving from ODF (xmloff) and > OOXML (oox) filters so they don't depend on GraphicObject URL > anymore, but load or save directly to / from XGraphic or XBitmap. > > Change-Id: I2b88e10056e7d6c920249d59188f86b1a5a32d21 > Reviewed-on: https://gerrit.libreoffice.org/49074 > Tested-by: Jenkins > Reviewed-by: Tomaž Vajngerl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Terrence Enger changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837
--- Comment #6 from Terrence Enger ---
Created attachment 147333
--> https://bugs.documentfoundation.org/attachment.cgi?id=147333&action=edit
files from callgrind
Included files are:
callgrind.out.{20223,20224}
from commands:
source instdir/program/ooenv
valgrind --tool=callgrind \
instdir/program/soffice.bin \
~/lo_hacking/notes/bug_12/bug_120837/Untitled\ 6.odt
callgrind_annotate.{20223,20224}
from commands:
callgrind_annotate --inclusive=yes callgrind.out.20223 \
> callgrind_annotate.20223
callgrind_annotate --inclusive=yes callgrind.out.20224 \
> callgrind_annotate.20224
callgind_annotate_tree.{20223,20224}
from commands
callgrind_annotate --inclusive=yes \
--tree=both callgrind.out.20223 \
> callgrind_annotate_tree.20223
callgrind_annotate --inclusive=yes \
--tree=both callgrind.out.20224 \
> callgrind_annotate_tree.20224
I collected these results from commit b7f1b4c0 (2018-12-05 22:23:49)
configured:
CC=ccache /usr/bin/gcc
CXX=ccache /usr/bin/g++
CCFLAGS=-Wshadow
--with-jdk-home=/usr/lib/jvm/default-java
--enable-split-debug
--enable-gdb-index
--enable-ld=gold
--enable-option-checking=fatal
#--enable-dbgutil
#--enable-debug
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
--without-package-format
built and running on debian-buster.
Outside of valgrind, this build used 18.276 CPU seconds to load and
save_as the test file.
In accord with comment 4, I am removing keyword bibisectRequest and
adding bibisected and bisedted.
HTH,
Terry.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 --- Comment #5 from Michael Meeks --- Would be great to have a callgrind profile of a build with symbols but without dbgutil here if possible; should make it much easier to fix. Thanks ! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1382 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Telesto changed: What|Removed |Added Blocks||116280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837
--- Comment #4 from Terrence Enger ---
Created attachment 146699
--> https://bugs.documentfoundation.org/attachment.cgi?id=146699&action=edit
bibisect in linux-64-6.1, tail of terminal output
Working on debian-buster in the bibisect-linux-64-6.1 repository, I
see that the bug came into LibreOffice:
commits-h datetime
-- -
good 10fffef2 a61747c2 2018-02-01 10:53:26
bad dcc8ce9e e02efb62 2018-02-01 10:54:22
and
commit e02efb621fe672aa52e56caa916cf5c3fd0a9cb8
Author: Tomaž Vajngerl
Date: Thu Feb 1 15:28:53 2018 +0900
Change bitmap table to store XBitmap instead of GraphicObject URL
As we want to get rid of GraphicObject URLs for the more robust
image life-cycle handling, it was necessary to change the way
bitmap table stores and handles images, so that they always
store a Graphic object (wrapped in UNO object that provides the
XGraphic and XBitmap interface).
In addition this changes loading and saving from ODF (xmloff) and
OOXML (oox) filters so they don't depend on GraphicObject URL
anymore, but load or save directly to / from XGraphic or XBitmap.
Change-Id: I2b88e10056e7d6c920249d59188f86b1a5a32d21
Reviewed-on: https://gerrit.libreoffice.org/49074
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
Within the bibisect process, the CPU time for Save-As in "good"
versions was from 2.37 to 2.52 seconds and in the versions I deemed
"bad" from 13.35 to 13.80 seconds.
I have not found the earlier slowdown that Xisco reported in comment
3, so I am leaving keyword bibisectRequest.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1063 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Telesto changed: What|Removed |Added Keywords||perf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 Xisco Faulí changed: What|Removed |Added Version|6.2.0.0.alpha1+ Master |6.1.0.0.alpha1+ Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisectRequest, regression CC||xiscofa...@libreoffice.org --- Comment #3 from Xisco Faulí --- So it seems the export time has increased over the time. In Version: 6.2.0.0.alpha1+ Build ID: cd6dd8c6f3562cbccbc971b916c6a8933840ffeb CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded and Version: 6.1.0.0.alpha1+ Build ID: 3a801799536e6870f2fb111b1cc00b9575a35a39 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group real0m32.163s user0m29.607s sys 0m1.467s in Version: 6.0.0.0.alpha1+ Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded real0m11.287s user0m7.251s sys 0m1.286s and Version: 5.4.0.0.alpha1+ Build ID: 9feb7f7039a3b59974cbf266922177e961a52dd1 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group real0m4.477s user0m3.426s sys 0m0.584s -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 --- Comment #2 from Telesto --- Issue also occurring when saving when exporting to PDF: Point::toPair -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120837] File saving at least 5 times slower
https://bugs.documentfoundation.org/show_bug.cgi?id=120837 --- Comment #1 from Telesto --- Created attachment 145935 --> https://bugs.documentfoundation.org/attachment.cgi?id=145935&action=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
