[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4285 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
Xisco Faulí changed:
What|Removed |Added
See Also||https://bugs.documentfounda
||tion.org/show_bug.cgi?id=15
||4284
--- Comment #18 from Xisco Faulí ---
(In reply to Mike Kaganski from comment #17)
> (In reply to Xisco Faulí from comment #16)
> > > IsNumeric(" ") returns True
> > @Mike, should it be reported as a separated bug ?
>
> Yes, indeed.
Done -> bug 154284
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
Mike Kaganski changed:
What|Removed |Added
Resolution|WORKSFORME |NOTABUG
--- Comment #17 from Mike Kaganski ---
(In reply to Leos Pohl from comment #8)
> (locale decimal separator is ",")
>
> IsNumeric(1,2) = True
> IsNumeric(1.2) = True
> IsNumeric("1.2") = False
> IsNumeric("1,2") = True
(In reply to eisa01 from comment #14)
> Created attachment 186081 [details]
(In reply to eisa01 from comment #15)
> Seems to work now?
First of all, let us not mix things and do the nonsensical testing.
1. IsNumeric(1,2) = True
This is an own bug, unrelated to this. The IsNumeric *here* is called with
*two* parameters, while it accepts only a single argument. Leos Pohl and eisa01
likely confused the (1,2) syntax for an alternative floating-point notation
using comma - but it's not: it's the same as IsNumeric(1, 2) (note the space
between the two arguments, which is simply missing in the confusing sample).
The bug is that functions must throw an error when the caller passes more
arguments than allowed. The resulting "True" is for the integer 1 that is
passed as the first parameter - in is indeed numeric.
2. IsNumeric(1.2) = True
This is a correct check is a floating-point number is numeric. The only correct
way of writing floating-point number literals in Basic is using decimal dot.
3. IsNumeric("1.2")
IsNumeric("1,2")
This is the whole essence of the issue discussed here. And it definitely
depends on the *locale* (as explained in comment 10), and so, when you test it
using a different locale, it doesn't tell you anything about reproducibility of
the original problem. Namely, the initial report used a locale with decimal
comma, and the test in comment 14 used a locale with decimal dot (and comma for
thousand separator). In Basic, the thousand separator can appear at any place,
not only separating groups of three digits -> hence the "1,2" is considered an
integer "12" with a thousand separator in unusual place. And "1.2" is
considered numeric, because it naturally matches the locale's floating-point
notation.
(In reply to Xisco Faulí from comment #16)
> > IsNumeric(" ") returns True
> @Mike, should it be reported as a separated bug ?
Yes, indeed.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
Xisco Faulí changed:
What|Removed |Added
CC||xiscofa...@libreoffice.org
--- Comment #16 from Xisco Faulí ---
(In reply to joesch04 from comment #12)
> it does not exactly belong to the topic of the bug, but may I add the
> following example:
>
> IsNumeric(" ") returns True
> IsNumeric("") returns False
>
> I think in both cases the result should be False.
This is still reproducble in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 06ebcfd5af22ae722bf2dd9918a6f6a83fe23b6e
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (es_ES.UTF-8); UI: en-US
Calc: threaded
@Mike, should it be reported as a separated bug ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 eisa01 changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #15 from eisa01 --- Seems to work now? Version: 7.5.1.2 (AARCH64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 10; OS: Mac OS X 13.2.1; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 --- Comment #14 from eisa01 --- Created attachment 186081 --> https://bugs.documentfoundation.org/attachment.cgi?id=186081=edit Testcase in LO 7.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 --- Comment #13 from QA Administrators --- Dear Leos Pohl, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
Alain Romedenne changed:
What|Removed |Added
Blocks||136801
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=136801
[Bug 136801] BASIC: CInt("+2") returns 0
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
--- Comment #12 from joesc...@web.de ---
it does not exactly belong to the topic of the bug, but may I add the following
example:
IsNumeric(" ") returns True
IsNumeric("") returns False
I think in both cases the result should be False.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 himajin100...@gmail.com changed: What|Removed |Added Blocks||127592 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127592 [Bug 127592] [META] LibreOffice Basic incl."Option Compatible" modules -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 --- Comment #11 from Mike Kaganski --- (In reply to Mike Kaganski from comment #10) > > The behavior has an effect on both the implicit conversion ( 1 + "2.3" = > > 3.3 ) > > as well as the function IsNumeric. The *different* problem here is that the implicit conversion seems to not behave like mentioned in the cited help topic (worth own bug). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 --- Comment #10 from Mike Kaganski --- But the help for IsNumeric [1] links to glossagy [2] for definition of Number; and the latter tells: > Decimal Point > When converting numbers, LibreOffice Basic uses the locale settings of the > system for determining the type of decimal and thousand separator. > > The behavior has an effect on both the implicit conversion ( 1 + "2.3" = 3.3 ) > as well as the function IsNumeric. Close NOTABUG? [1] https://help.libreoffice.org/6.4/en-US/text/sbasic/shared/03102700.html [2] https://help.libreoffice.org/6.4/en-US/text/sbasic/shared/0002.html#dezimal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
--- Comment #8 from Leos Pohl ---
To complement my full results:
Version: 6.1.5.2
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
CPU threads: 8; OS: Mac OS X 10.14.3; UI render: default;
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group threaded
(locale decimal separator is ",")
IsNumeric(1,2) = True
IsNumeric(1.2) = True
IsNumeric("1.2") = False
IsNumeric("1,2") = True
So maybe if the input is a String, it does depend on the Locale but regardless
of the input type, it needs to provide consistent results which it does not.
Whether it is correct to take into account the locale or not is a good question
because, if a the table has numbers stored as text (e.g. '1.2) then when such a
workbook is transported onto a system with such locale that the decimal
separator is "," these numbers are not automatically transformed to have the
correct decimal separator but it is still a number (at least it was supposed as
such on the other system), regardless of the fact that it is stored as text and
since the point of isNumeric is to determine whether a Variant type (i.e. even
a string) is a correct number, from this point of view both isNumber should be
insensitive to the locale.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158
--- Comment #9 from Leos Pohl ---
To complement my full results:
Version: 6.1.5.2
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
CPU threads: 8; OS: Mac OS X 10.14.3; UI render: default;
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group threaded
(locale decimal separator is ",")
IsNumeric(1,2) = True
IsNumeric(1.2) = True
IsNumeric("1.2") = False
IsNumeric("1,2") = True
So maybe if the input is a String, it does depend on the Locale but regardless
of the input type, it needs to provide consistent results which it does not.
Whether it is correct to take into account the locale or not is a good question
because, if a the table has numbers stored as text (e.g. '1.2) then when such a
workbook is transported onto a system with such locale that the decimal
separator is "," these numbers are not automatically transformed to have the
correct decimal separator but it is still a number (at least it was supposed as
such on the other system), regardless of the fact that it is stored as text and
since the point of isNumeric is to determine whether a Variant type (i.e. even
a string) is a correct number, from this point of view both isNumber should be
insensitive to the locale.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 --- Comment #7 from Takeshi Abe --- IsNumeric(a) is true with: Version: 6.2.0.3 Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; VCL: osx; Locale: ja-JP (en_JP.UTF-8); UI-Language: en-US Calc: threaded but false with: Version: 6.2.0.3 Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; VCL: osx; Locale: fr-FR (en_JP.UTF-8); UI-Language: en-US Calc: threaded i.e. on macOS it depends on your locale setting, which determines "." or "," as the decimal separator. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 --- Comment #6 from Alex Thurgood --- Also reproduced in Version: 5.2.6.2 Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc Threads CPU : 4; Version de l'OS :Mac OS X 10.14.2; UI Render : par défaut; Locale : fr-FR (fr_FR.UTF-8); Calc: group so, it would seem that the bug has always been present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 Alex Thurgood changed: What|Removed |Added Version|6.1.4.2 release |3.3.0 release --- Comment #5 from Alex Thurgood --- Tested with LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 I can reproduce the same behaviour here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 --- Comment #4 from Alex Thurgood --- I get the same result even if I set variable a as Any... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 Alex Thurgood changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Alex Thurgood --- Confirming with Version: 6.3.0.0.alpha0+ Build ID: e9db8eceff48290be72591f7422b4fc45e5752fc CPU threads: 4; OS: Mac OS X 10.14.2; UI render: default; VCL: osx; Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 Oliver Brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de --- Comment #2 from Oliver Brinzing --- with Version: 6.1.5.2 (x64) Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: result is True -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- https://help.libreoffice.org/Basic/IsNumeric_Function_Runtime indicates a variant not a string. Now, I think all envs should have the same behavior. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123158] isNumeric returns false if number is passed as String
https://bugs.documentfoundation.org/show_bug.cgi?id=123158 Leos Pohl changed: What|Removed |Added Hardware|All |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
