[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

--- Comment #9 from Mike Kaganski  ---
(In reply to Eike Rathke from comment #5)
> @Mike: could you test that on Windows?

Indeed, that was the problem. https://gerrit.libreoffice.org/71242 fixes that.
I have tested both in Win10 and Win7.

Eike: thank you very much!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

--- Comment #8 from Mike Kaganski  ---
(In reply to Eike Rathke from comment #7)

Thanks; I'll test on my Win7 VM with appropriate setting in "Region and
Language" -> "Format".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

--- Comment #7 from Eike Rathke  ---
Note that 0x0491 was introduced with commit
6b678c135da07f34da1bf7b19562366361e95085 in 2013, for which the commit message
says "a bunch of new definitions up to Windows 8.1", so it might be that
Windows 7 or earlier would not accept the new value (or not changing the msi
value was simply an oversight). However, as of Windows 8 it may really use the
new value. The lang.h comment aptly says "apparently it occurred to MS that
those are different languages" ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

--- Comment #6 from Mike Kaganski  ---
(In reply to Eike Rathke from comment #5)
> I think it's just a matter to update
> l10ntools/source/ulfconv/msi-encodinglist.txt to use 1169 (0x0491
> LANGUAGE_GAELIC_SCOTLAND) instead of 1084 (0x043C
> LANGUAGE_GAELIC_SCOTLAND_LEGACY) for 'gd' (which even has the comment Gaelic
> (Scotland)).

Thank you very much!

> @Mike: could you test that on Windows?

Definitely.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

--- Comment #5 from Eike Rathke  ---
I think it's just a matter to update
l10ntools/source/ulfconv/msi-encodinglist.txt to use 1169 (0x0491
LANGUAGE_GAELIC_SCOTLAND) instead of 1084 (0x043C
LANGUAGE_GAELIC_SCOTLAND_LEGACY) for 'gd' (which even has the comment Gaelic
(Scotland)).

@Mike: could you test that on Windows?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||113117


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113117
[Bug 113117] [META] Windows installer/uninstaller bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

--- Comment #4 from Michael Bauer  ---
Not much I can add at this stage other than LANGUAGE_GAELIC_SCOTLAND_LEGACY
being a result of Microsoft (I think) originally having lumped Irish Gaelic
together with Scottish Gaelic (they're not the same language, it's a bit like
the English <> Dutch relationship) and then having split them, eventually.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

--- Comment #3 from Mike Kaganski  ---
i18nlangtag/source/isolang/isolang.cxx lists two values for "gd", "GB":
LANGUAGE_GAELIC_SCOTLAND *and* LANGUAGE_GAELIC_SCOTLAND_LEGACY - the latter one
being defined in include/i18nlangtag/lang.h as LanguageType(0x043C) = 1084.
Somehow that latter one is picked instead of the other (proper) one - maybe
just by sorting the list somewhere and finding the first match. Shouldn't there
be some change in the language code?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

Mike Kaganski  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #2 from Mike Kaganski  ---
(In reply to Xisco Faulí from comment #1)
> @Mike Kaganski, any idea why it's happening ?

Looking at
https://gerrit.libreoffice.org/plugins/gitiles/translations/+/master/source/gd/instsetoo_native/inc_openoffice/windows/msi_languages.po#1688,
I see that the same strings are shown when I run installation using

> msiexec /i D:\Downloads\LibreOffice_6.2.3.1_Win_x64.msi ProductLanguage=1084

... so that 1084 must be the code that somehow arrives with the translation. It
doesn't look like proper gd LCID; gd-GB should be 1169 (0x0491) according to
[MS-LCID] (and simple gd is 145 (0x0091)).

I have no idea how translations are passed to MSI creation scripts; possibly
the process itself is even irrelevant, but the problem is somewhere in our
BCP-47-to-LCID conversion code... Eike, do you have an idea?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124791] LO installer is missing UI language codes

2019-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124791

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
@Mike Kaganski, any idea why it's happening ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs