[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

Kevin Suo  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |suokunl...@126.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #9 from Kevin Suo  ---
I've submitted the patch on gerrit:
https://gerrit.libreoffice.org/c/core/+/107965

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

--- Comment #8 from Heiko Tietze  ---
(In reply to Kevin Suo from comment #7)
> (In reply to Caolán McNamara from comment #6)
> 
> Thank you for the information. I tested and nothing bad for now.
> Heiko: Would you also take a look of this?

Please submit the patch to Gerrit and add me as reviewer. I'll check locally.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

Kevin Suo  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #7 from Kevin Suo  ---
(In reply to Caolán McNamara from comment #6)

Thank you for the information. I tested and nothing bad for now.
Heiko: Would you also take a look of this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

--- Comment #6 from Caolán McNamara  ---
wrt #4 setting the height to one row means they will take up the height of
whatever else is the tallest element in the dialog. Nothing wrong with that,
but there are other dialogs which contain just one of the pages you see in that
dialog. e.g. in the fields dialog insert from Document a "page field, then
right click the inserted field and select "edit fields" and a dialog with just
one of the tabpages used is shown.

So the thing to test is to insert a field from each page of the insert, fields
dialog and then right click and edit,fields each of them to gauge if the
suggested change is bad for that case

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

--- Comment #5 from Kevin Suo  ---
Created attachment 168225
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168225=edit
Full screenshot with the patch applied

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

--- Comment #4 from Kevin Suo  ---
Created attachment 168224
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168224=edit
a patch which works but need expert's revision

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

Kevin Suo  changed:

   What|Removed |Added

 CC||caol...@redhat.com
   Keywords||patch

--- Comment #3 from Kevin Suo  ---
I checked the .ui files and they seem to be with normal height. 
Then I tried to change the various places as shown in the attached patch file
(e.g., "auto nHeight = m_xTypeLB->get_height_rows(XX)" in
sw/source/ui/fldui/flddb.cxx etc). With this patch, this dialog becomes normal.
Since I do not know the code and this seems to be related to "weld", I am
adding Caolán to cc: would you please take a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

2020-12-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130275

Kevin Suo  changed:

   What|Removed |Added

Summary|Ctrl + F2 (i.e., insert |"Insert > Field > More
   |More Fields) dialog:  The   |Fields" dialog is too
   |confirmation buttons get|high/tall - the OK/Cancel
   |hidden behind the bottom|buttons get hidden behind
   |panel of 'gnome-panel'  |the bottom panel of
   ||'gnome-panel'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs