[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 Xisco Faulí changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3621 CC||nagy.tib...@nisz.hu --- Comment #11 from Xisco Faulí --- Issue fixed by author Tibor Nagy 2020-07-09 09:54:15 +0200 committer László Németh2020-07-15 16:22:38 +0200 commit ee6cd34eb3a2bd1f1340063ee4b90a72ff0c9532 (patch) tree21235b4bbf7f3b32fd1edd3d018ae33c0eeb parent ac90bb44f53e099bd8743662b20d0e5ae1752fa2 (diff) tdf#123621 sw: fix textbox position according to DOCX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 --- Comment #10 from Telesto --- No crash Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 239b4bb27fd8db26e8416045b3015688a8b1b0ae CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 Telesto changed: What|Removed |Added Blocks||133092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775
Miklos Vajna changed:
What|Removed |Added
Keywords|regression |implementationError
--- Comment #9 from Miklos Vajna ---
I looked at this, but then ran out of time, so I'm just dumping my notes here,
so in case I get back to this in the future or somebody else takes a look it's
not necessary to start from scratch.
The direct problem is that SwTextAdjuster::CalcRightMargin() works on a list of
portions, we set pLast to a value, then call CalcFlyPortion(), then we continue
using pLast. But this is not safe, because pLast may be deleted while
CalcFlyPortion() is called.
Here is how the delete happens:
#0 SwLinePortion::~SwLinePortion (this=0x6040007b4950) at
sw/source/core/text/porlin.cxx:57
#1 0x7fff55977768 in SwTextPortion::~SwTextPortion (this=0x6040007b4950)
at sw/source/core/text/portxt.hxx:27
#2 0x7fff55d4e445 in SwTextPortion::~SwTextPortion (this=0x6040007b4950)
at sw/source/core/text/portxt.hxx:27
#3 0x7fff55c90648 in SwLinePortion::Truncate_ (this=0x6183b080) at
sw/source/core/text/porlin.cxx:165
#4 0x7fff5591e6f2 in SwLinePortion::Truncate (this=0x6183b080) at
sw/source/core/text/porlin.hxx:199
#5 0x7fff55b97f97 in SwLineLayout::~SwLineLayout (this=0x6183b080) at
sw/source/core/text/porlay.cxx:201
#6 0x7fff55bd2013 in SwParaPortion::~SwParaPortion (this=0x6183b080)
at sw/source/core/text/porlay.cxx:2376
#7 0x7fff55bd2075 in SwParaPortion::~SwParaPortion (this=0x6183b080)
at sw/source/core/text/porlay.cxx:2375
#8 0x7fff55db3492 in std::default_delete::operator()
(this=0x6040012bafb8, __ptr=0x6183b080)
at
/home/vmiklos/git/libreoffice/lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:78
#9 0x7fff55db29fa in std::unique_ptr >::reset (this=0x6040012bafb8,
__p=0x6183b080)
at
/home/vmiklos/git/libreoffice/lode/opt_private/gcc-7.3.0/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:376
#10 0x7fff55db0fb1 in SwTextLine::SetPara (this=0x6040012baf90, pNew=0x0,
bDelete=true) at sw/source/core/text/txtcache.hxx:45
#11 0x7fff55daf0fc in SwTextFrame::ClearPara (this=0x61200040a140) at
sw/source/core/text/txtcache.cxx:112
#12 0x7fff55e5eacc in SwTextFrame::Init (this=0x61200040a140) at
sw/source/core/text/txtfrm.cxx:753
#13 0x7fff55eafc8a in SwTextFrame::Prepare (this=0x61200040a140,
ePrep=PrepareHint::FlyFrameArrive, pVoid=0x7fff8345f820, bNotify=true) at
sw/source/core/text/txtfrm.cxx:3071
#14 0x7fff54e6102c in lcl_NotifyContent (pThis=0x615000644900,
pCnt=0x61200040a140, rRect=SwRect = {...}, eHint=PrepareHint::FlyFrameArrive)
at sw/source/core/layout/frmtool.cxx:3146
#15 0x7fff54e59757 in Notify_Background (pObj=0x615000644900,
pPage=0x612000405640, rRect=SwRect = {...}, eHint=PrepareHint::FlyFrameArrive,
bInva=true)
at sw/source/core/layout/frmtool.cxx:3224
#16 0x7fff541560d6 in lcl_NotifyBackgroundOfObj (_rDrawContact=...,
_rObj=..., _pOldObjRect=0x0) at sw/source/core/draw/dcontact.cxx:937
#17 0x7fff5415ff07 in SwDrawContact::SwClientNotify (this=0x6130001cf700,
rMod=..., rHint=...) at sw/source/core/draw/dcontact.cxx:1437
#18 0x7fff522392c6 in SwModify::CallSwClientNotify (this=0x6130001cf380,
rHint=...) at sw/source/core/attr/calbck.cxx:373
#19 0x7fff522395c6 in sw::BroadcastingModify::CallSwClientNotify
(this=0x6130001cf380, rHint=...) at sw/source/core/attr/calbck.cxx:378
#20 0x7fff52240408 in SwModify::ModifyBroadcast (this=0x6130001cf380,
pOldValue=0x7fff8365bb00, pNewValue=0x7fff8365bb40) at sw/inc/calbck.hxx:199
#21 0x7fff52236818 in SwModify::NotifyClients (this=0x6130001cf380,
pOldValue=0x7fff8365bb00, pNewValue=0x7fff8365bb40) at
sw/source/core/attr/calbck.cxx:201
#22 0x7fff5227d9fb in SwFormat::Modify (this=0x6130001cf380,
pOldValue=0x7fff8365bb00, pNewValue=0x7fff8365bb40) at
sw/source/core/attr/format.cxx:322
#23 0x7fff54b6ceb2 in SwFrameFormat::Modify (this=0x6130001cf380,
pOld=0x7fff8365bb00, pNew=0x7fff8365bb40) at
sw/source/core/layout/atrfrm.cxx:2581
#24 0x7fff52244154 in SwClient::ModifyNotification (this=0x6130001cf380,
pOldValue=0x7fff8365bb00, pNewValue=0x7fff8365bb40) at sw/inc/calbck.hxx:154
#25 0x7fff52289492 in SwFormat::SetFormatAttr (this=0x6130001cf380,
rSet=SfxItemSet of pool 0x603001241f80 with parent 0x0 and Which ranges:
[(88, 130), (151, 151), (1014, 1033)] = {...}) at
sw/source/core/attr/format.cxx:643
#26 0x7fff52e04653 in lcl_SetFlyFrameAttr (rDoc=..., pSetFlyFrameAnchor=
(sal_Int8 (SwDoc::*)(SwDoc * const, SwFrameFormat &, SfxItemSet &, bool))
0x7fff52df8f40 ,
rFlyFormat=...,
rSet=SfxItemSet of pool 0x603001241f80 with parent 0x0 and Which ranges:
[(102, 103)] = {...}) at sw/source/core/doc/docfly.cxx:476
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|6.4.0.3 release |6.0 all versions Ever confirmed|0 |1 OS|Linux (All) |All Keywords|possibleRegression |bibisected, bisected, ||regression CC||vmik...@collabora.com Hardware|x86-64 (AMD64) |All See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||6132 --- Comment #8 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6f9f9491bdef676f969898bd653db9905d14f5e8 author Miklos Vajna 2017-07-11 09:04:23 +0200 committer Miklos Vajna 2017-07-11 14:10:13 +0200 commit 6f9f9491bdef676f969898bd653db9905d14f5e8 (patch) treeb0962fbec2172518069362c6332ac06d53f16d3f parent 2a22696546ace75c38a72ad13f7383aedd00e06a (diff) tdf#106132 DOCX import: fix handling of nested textbox margins Bisected with: bibisect-linux64-6.0 Adding Cc: to Miklos Vajna -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 --- Comment #7 from Xisco Faulí --- Created attachment 158783 --> https://bugs.documentfoundation.org/attachment.cgi?id=158783=edit minimized document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||104450 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104450 [Bug 104450] [META] DOCX (OOXML) file opening issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 --- Comment #6 from frank.buett...@mdc-berlin.de --- Hi Xisco, yes I can do this. But I need your S/MIME certificate or your gpg key for encryption. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 --- Comment #5 from Xisco Faulí --- ooh, my bad, I misread the commets... @Frank, would it be possible to privately send the document to me by email? I would only use it to investigate this issue without sharing it with a third party... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 Dieter changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME |--- --- Comment #4 from Dieter --- (In reply to Xisco Faulí from comment #3) > (In reply to frank.buettner from comment #2) > > Yes, 6.1.6.3 can open it without an crash. > > Thanks for checking > Closing as RESOLVED WORKSFORME Xisco, I don't understand, why you closed the report. If there is no crash in LO 6.1 and it crashes in 6.4 it is a bug with a regression, isn't it? => UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 Xisco Faulí changed: What|Removed |Added Resolution|--- |WORKSFORME CC||xiscofa...@libreoffice.org See Also||https://crashreport.libreof ||fice.org/stats/signature/Sw ||TextAdjuster::CalcRightMarg ||in Status|UNCONFIRMED |RESOLVED --- Comment #3 from Xisco Faulí --- (In reply to frank.buettner from comment #2) > Yes, 6.1.6.3 can open it without an crash. Thanks for checking Closing as RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 --- Comment #2 from frank.buett...@mdc-berlin.de --- Yes, 6.1.6.3 can open it without an crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
https://bugs.documentfoundation.org/show_bug.cgi?id=130775 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Summary|Crash in: |FILEOPEN DOCX: Crash in |SwTextAdjuster::CalcRightMa |SwTextAdjuster::CalcRightMa |rgin|rgin Keywords||possibleRegression --- Comment #1 from Dieter --- Regarding to https://bugs.documentfoundation.org/show_bug.cgi?id=130775# crashes started with LO 6.2. Is it possible for you, to check with LO 6.1? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
