[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 --- Comment #7 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f6328abe3fcd7fb2ec72779ba3754abe761f626b tdf#131190 Make custom page styles deletable again in Calc It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 --- Comment #6 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bb844eb299b614c1fa56e140630db070cf709a02 tdf#131190 Make custom page styles deletable again in Calc It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 Commit Notification changed: What|Removed |Added Whiteboard||target:7.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 --- Comment #5 from Jim Raykowski --- (In reply to Jim Raykowski from comment #4) > (In reply to Oliver Brinzing from comment #3) > Here is a patch to return the ability to delete custom page styles in Calc. > It doesn't solve the "isInUse" problem, it just changes all page style is in > use queries to return as not in use. It will cause your macro to not report > any page style in use instead of reporting all page styles in use. > My first approach, of returning page style queries as not in use, does not pass the CppunitTest_sc_subsequent_export_test ScExportTest::testHeaderImageODS test. I've taken a new approach that keeps the page style "isInUse" always true, as before. https://gerrit.libreoffice.org/c/core/+/90547 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 --- Comment #4 from Jim Raykowski --- (In reply to Oliver Brinzing from comment #3) > seems to have started with: > > https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit; > h=9cbc55167301cefe9889ad8e604439e0118b627f > > tdf#128557 Only show delete menu item when custom style is not in use > or it has a parent style so when a custom paragraph style is in use it > can be deleted and the style will revert to the parent > > I think the problem is: > Bug 108188 - PageStyle property "isInUse" is always true > I agree this is the problem. Here is a patch to return the ability to delete custom page styles in Calc. It doesn't solve the "isInUse" problem, it just changes all page style is in use queries to return as not in use. It will cause your macro to not report any page style in use instead of reporting all page styles in use. https://gerrit.libreoffice.org/c/core/+/90547 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 Oliver Brinzing changed: What|Removed |Added OS|Mac OS X (All) |All See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8557 Keywords|bibisectRequest |bibisected, bisected --- Comment #3 from Oliver Brinzing --- seems to have started with: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=9cbc55167301cefe9889ad8e604439e0118b627f tdf#128557 Only show delete menu item when custom style is not in use or it has a parent style so when a custom paragraph style is in use it can be deleted and the style will revert to the parent I think the problem is: Bug 108188 - PageStyle property "isInUse" is always true /cygdrive/d/sources/bibisect/bibisect-win64-6.4 $ git bisect good c5d11eba2bd1031fd6ef2cc85d959b167d7c4a34 is the first bad commit commit c5d11eba2bd1031fd6ef2cc85d959b167d7c4a34 Author: Norbert Thiebaud Date: Tue Nov 26 05:43:13 2019 -0800 source sha:9cbc55167301cefe9889ad8e604439e0118b627f source sha:9cbc55167301cefe9889ad8e604439e0118b627f :04 04 141135c044433ba1a22e82a37703da5a3ac61843 3ec897f966ae6f7cf910de91afa31f30cbc4a27f M instdir /cygdrive/d/sources/bibisect/bibisect-win64-6.4 $ git bisect log # bad: [75af2782b7f006d1c31ad11e84d5ab6bd7f74ed0] source sha:20be5cd0bdc57d812bf34a2debfe48caa51de881 # good: [8d1eaf05d47fd1c56ddecbe57a9a7c8289ede7f4] source sha:c98b1f1cd43b3e109bcaf6324ef2d1f449b34099 git bisect start 'master' 'oldest' # good: [e13037966b62b9d258d5cf6d96586de5e2bafea8] source sha:4a0b2b8024fa6fb8a0ab3e474b7d64fc455028b5 git bisect good e13037966b62b9d258d5cf6d96586de5e2bafea8 # good: [7cba838374e1acd7b8a6e114d7b12bf6370cd7ab] source sha:d6ea967e040d01ec69649ac689472018e477db34 git bisect good 7cba838374e1acd7b8a6e114d7b12bf6370cd7ab # good: [39293e77bf2d89be2f2f7afeb4c0c65f7231ff3a] source sha:9b400e84b1689997378f6738b97b71b09cdb7be6 git bisect good 39293e77bf2d89be2f2f7afeb4c0c65f7231ff3a # good: [e312d3a1be007a0fc008d7d39270cec23d31859c] source sha:8bd15459527b527454900dd781f1226dade5b118 git bisect good e312d3a1be007a0fc008d7d39270cec23d31859c # bad: [2597df5132e9b5daee0008c022050fc3c55b6dd3] source sha:fd212d59d7cf9fb8c46bb73f4c21148b61c5c53e git bisect bad 2597df5132e9b5daee0008c022050fc3c55b6dd3 # good: [6ee62b8c59266830077e378a1d946804ebaf23c1] source sha:4d7a66f24dfbe4b97f88dd79b020025ebcd48f1c git bisect good 6ee62b8c59266830077e378a1d946804ebaf23c1 # good: [b3c855959deaed6bfc8fe201efc9301ed7c862e5] source sha:1908393e7861f45aea616a192059ccbd9b62b5a4 git bisect good b3c855959deaed6bfc8fe201efc9301ed7c862e5 # good: [6fb58d40603d7d90b10995ff895041fa983ccb50] source sha:5d7be7fdbd1f94b2056f8b4adc7722addb9e7fc9 git bisect good 6fb58d40603d7d90b10995ff895041fa983ccb50 # good: [b73c79bb7cad88ff5c74fbed38d0f5686f2ee00b] source sha:8a18bed665bfc081a728c017e27a925c914c97f6 git bisect good b73c79bb7cad88ff5c74fbed38d0f5686f2ee00b # good: [b885129965c88e1515f98cd17c29f32d478c3647] source sha:509732f06df3d9ddef535daaeb9e6780b14c8431 git bisect good b885129965c88e1515f98cd17c29f32d478c3647 # bad: [c5d11eba2bd1031fd6ef2cc85d959b167d7c4a34] source sha:9cbc55167301cefe9889ad8e604439e0118b627f git bisect bad c5d11eba2bd1031fd6ef2cc85d959b167d7c4a34 # good: [c927bced147dd414cad9317393c549d0ab0b08a9] source sha:de0924073824e1e38d35f78f5f8de2a4feceae8e git bisect good c927bced147dd414cad9317393c549d0ab0b08a9 # first bad commit: [c5d11eba2bd1031fd6ef2cc85d959b167d7c4a34] source sha:9cbc55167301cefe9889ad8e604439e0118b627f -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 Oliver Brinzing changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8188 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 --- Comment #2 from Oliver Brinzing --- Created attachment 158456 --> https://bugs.documentfoundation.org/attachment.cgi?id=158456=edit test_pagestyle.ods -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=131190 Oliver Brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression Ever confirmed|0 |1 --- Comment #1 from Oliver Brinzing --- reproducible with: Version: 6.4.1.2 (x64) Build-ID: 4d224e95b98b138af42a64d84056446d09082932 CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: but *not* reproducible with: Version: 6.3.5.2 (x64) Build-ID: dd0751754f11728f69b42ee2af66670068624673 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
