[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #21 from Xisco Faulí --- Setting to VERIFIED based on comment 18 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #20 from Andreas Heinisch --- Wrong number sry :( ofc Bug tdf#131455 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #19 from Andreas Heinisch --- Thank you for the feedback! I will investigate your report for tdf#131445 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #18 from Daniel Baran --- Confirming the fix in: Version: 7.0.0.0.alpha0+ (x86) Build ID: 9163755e9f64a0b1dd5f2090e0702c19e31c12c9 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded PS: Please see report - Bug 131455 (yet unconfirmed). The same behavior as in 6.4.2.2 is present in this alpha. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Andreas Heinisch changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #17 from Commit Notification --- Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/16b0bbb671a8080655e27542e576478486810404 tdf#131296: get numeric value with its data type in StepLOADNC It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Commit Notification changed: What|Removed |Added Whiteboard||target:7.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #16 from Andreas Heinisch --- https://gerrit.libreoffice.org/c/core/+/90858 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #15 from Mike Kaganski --- @DrRobotto: to keep the binary compatibility with previous versions, taking into account that the SbiRuntime::StepLOADI is 1-argument operation that takes 32-bit value, but casts it to 16-bit value, we could write old value to lower 16 bits, and string identifier in upper 16 bits in SbiExprNode::Gen for Integer case (which is the problem), and handle that in the SbiRuntime::StepLOADI (if upper 16 bits are 0, then use lower 16 bits). But then how to tell case SbxLONG? Maybe simply stop generating SbiRuntime::StepLOADI at all, revert its handling to old way (for files created in older versions), and only generate SbiOpcode::NUMBER_ for both Integer and Long? then you'd need to implement type detection in SbiRuntime::StepLOADNC to restore the type? SbiStringPool::Add( double n, SbxDataType t ) could safely write type character after the number, and the code reading the number could take it into account (old code will just read up to non-numeric characters, so would be safe). That would also handle bug 129596 comment 6. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Mike Kaganski changed: What|Removed |Added Attachment #158626|0 |1 is obsolete|| Attachment #158788|0 |1 is obsolete|| --- Comment #14 from Mike Kaganski --- Created attachment 158792 --> https://bugs.documentfoundation.org/attachment.cgi?id=158792=edit Password-protected macro showing message with an Integer literal Even simpler test case: clicking the button must show 123, but shows 0 in master -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #13 from Mike Kaganski --- By the way, the same is true in the opposite direction: unprotecting the library in master toward 7.0, saving the spreadsheet, then opening it in 6.4, the macro does not work correctly until unprotected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Mike Kaganski changed: What|Removed |Added Attachment #158788|Password-protected macro|Password-protected macro description|does not work in master |created in earlier versions |toward 7.0 unless unlocked |does not work in master ||toward 7.0 unless unlocked -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Mike Kaganski changed: What|Removed |Added Attachment #158788|A sample with the problem |Password-protected macro description||does not work in master ||toward 7.0 unless unlocked -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #12 from Mike Kaganski --- (In reply to Mike Kaganski from comment #11) > Created attachment 158788 [details] @DrRobotto: please could you take a look at this? See also comment 4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #11 from Mike Kaganski --- Created attachment 158788 --> https://bugs.documentfoundation.org/attachment.cgi?id=158788=edit A sample with the problem This sample spreadsheet has a library with password "1234" (no quotes). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #10 from Daniel Baran --- File with unlocked library has been sent to: xiscofa...@libreoffice.org and mike.kagan...@collabora.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #9 from Daniel Baran --- Just checked for this bug in (pre-release 6.4.2.2): Version: 6.4.2.2 (x64) Build ID: 4e471d8c02c9c90f512f7f9ead8875b57fcb1ec3 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded Macro execution problem seen in 7.0.0.0 is NOT seen in 6.4.2.2. No other bugs are evident at this time in this test case (timespreader file). That is, all macros, computations and data display seem to be as expected when in 6.4.2.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #7 from Daniel Baran --- Additional info has been sent to: xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #6 from Xisco Faulí --- Hello Daniel, Could you please provide the password ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #5 from Daniel Baran --- I can confirm Mike Kaganski's suspicion. When I unprotected the library, the three malfuctioning macros all worked normally. Happy to provide more info or testing as needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Mike Kaganski changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Mike Kaganski --- The problem seems to be related to the password-protected library in the ODS (so a pre-compiled blob is used to execute the macro). As it was created in an older version, the blob is likely not having the data expected by newer code. The password is required to check what is the original code that fails now (setting NEEDINFO); I suspect that unlocking the library then saving the file would "fix" the problem (which is not a fix for the bug, which likely needs something to enable interoperability both backwards (if possible) and forward; see https://git.libreoffice.org/core/commit/4abb191916916c7003deedcfdcf46287faccaf01 for some inspiration). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9596 Status|UNCONFIRMED |NEW Keywords||bibisected, bisected, ||regression CC||andreas.heini...@yahoo.de, ||mikekagan...@hotmail.com, ||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0b4f8bf571baf2ccd5a8aafdc4deb41867420be3 author U-DESKTOP-8OSNV7R\DrRobotto 2019-12-24 12:22:34 +0100 committer Mike Kaganski 2020-01-05 21:42:27 +0100 commit 0b4f8bf571baf2ccd5a8aafdc4deb41867420be3 (patch) tree5f5af8179e6180f118000df70f49e9783bf66c98 parent 5fbc89478eb91d9b97f0c3d65d9946a5cec31ea3 (diff) tdf#129596 Distinguish between integer and long while loading immediate values Bisected with: bibisect-linux64-6.5 Adding Cc: to Andreas Heinisch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 --- Comment #2 from Daniel Baran --- Some additional testing shows that three different macros are not working. Importantly (I suspect), each of the three involve a jump to another sheet. The other six macros (that do not include a sheet jump), seem to be working normally. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131296] Macro for copying data from protected cells and then selecting a different sheet no longer works.
https://bugs.documentfoundation.org/show_bug.cgi?id=131296 Daniel Baran changed: What|Removed |Added CC||d.j.ba...@frontier.com --- Comment #1 from Daniel Baran --- Created attachment 158626 --> https://bugs.documentfoundation.org/attachment.cgi?id=158626=edit Macro enabled ODS workbook with partially protected cells. This file can be used for testing this or other bugs as desired. All embedded macros were functioning properly through LO 6.2.8 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
