[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Heiko Tietze changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |kain...@gmail.com |desktop.org | --- Comment #21 from Heiko Tietze --- (In reply to andreas_k from comment #20) > No I'm work on the sidebar theme. Multiple patches for one ticket sounds like a mistake. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Heiko Tietze changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #20 from andreas_k --- (In reply to Heiko Tietze from comment #19) > (In reply to Commit Notification from comment #18) > > andreas kainz committed a patch related to this issue. > > Assuming it's fixed. No I'm work on the sidebar theme. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #19 from Heiko Tietze --- (In reply to Commit Notification from comment #18) > andreas kainz committed a patch related to this issue. Assuming it's fixed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #18 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cf361c7af5aca5978f8aaf4b1e101b2feb2aaf03 tdf#133690 remove thin border in sidebar It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Commit Notification changed: What|Removed |Added Whiteboard||target:7.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #17 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b6d2db52ea963615c1323a031694123c9d2a2534 tdf#133690 Hide surrounding border frame at sidebar It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #16 from andreas_k --- I added Noel Grandin cause he edited this file a lot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #15 from andreas_k --- should be something in yeah in vcl/source/window/splitwin.cxx ImplCalcBorder, SplitWindow::ImplDrawBorder, SplitWindow::ImplDrawGrip and functons like that -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Thomas Lendo changed: What|Removed |Added CC||thomas.le...@gmail.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #14 from Thomas Lendo --- (In reply to Tomaz Vajngerl from comment #13) > I agree with Andreas, we draw too much lines. Definitely something we should > improve. +1 for cosmetic improvement Changing the status to NEW according to the last comments from Tomaz and Heiko. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #13 from Tomaz Vajngerl --- I agree with Andreas, we draw too much lines. Definitely something we should improve. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #12 from Heiko Tietze --- Buttons are placed on frames that in turn have borders. Sidebars have a border as well. Let's turn this around: No objection from UX to improve. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 andreas_k changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WONTFIX |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #11 from andreas_k --- Created attachment 162347 --> https://bugs.documentfoundation.org/attachment.cgi?id=162347=edit Frame around Sidebar in Dark mode As you can see in Darkmode (qt backend) the frame around the sidebar didn't follow any other style. for example at the statusbar there is a 1px thin line at the bottom of the toolbar there is no line at all. Only at the sidebar's (Sliders on the left and sidebar on the right) there is a "fat" frame around the sidebar. And at the > button with two lines. I'D like to reopen this bug report and hope that this bug can be fixed with reduce the usage of the frame for the sidebar, as everywhere else there is also no "fat" line available. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #10 from V Stuart Foote --- > > but 116298 s/but/bug 116298 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||103459 --- Comment #9 from V Stuart Foote --- When Tomaž implemented the Sidebar Hide/Show grips (reused in several UI elements, Draw Page pane, Impress Slide pane) that are defined/bounded by this "separator", considerable effort went into getting it to have consistent visual handling in all DE. See refs. Frankly this is purely a cosmetic change, not meriting the dev effort rework of the Hide/Show grips would require. See no reason to fiddle with it now. +1 for the WF =-refs-= bug 83527 but 116298 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103459 [Bug 103459] [META] Sidebar UI and UX bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #8 from Heiko Tietze --- (In reply to andreas_k from comment #7) > I am complete against close the bug No obvious disadvantage but some effort and special handling that might have side-effects. But feel free to reopen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #7 from andreas_k --- I am complete against close the bug cause remove the borders didn't have any disadvantage see the mockup but refresh the libo UI a lot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Heiko Tietze --- In addition to Gerhard's comment: it looks better without the bevel, for example in WPS and Freeoffice. But we introduced a button that can be used to collapse/expand the sidebar (this small grey rectangle in the middle). And replacing this by a toolbar button (as LOOL or competitors does) is not so simple unless we go with special solutions such as Notebookbars. So let's resolve as WF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #5 from Gerhard Weydt --- There is one importnat difference between LibO and LOOL: the sidebar in LibO has several panes which can be brought to the front by using the option buttons on the right, whereas the LOOL pane only shows the properties. The frame surrounding the fields and separating them from the buttons, which is simlarly used in many dialogs, hence makes sense. The double vertical separator is also used on the color bar (where normally it is horizontal) and the pages pane in Draw and Impress. The space is needed any way for the collapse button, and the two lines emphasize the collapse button and the border between sidebar and the workspace. What's wrong with that? I cannot support the proposed changes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 --- Comment #4 from andreas_k --- (In reply to Heiko Tietze from comment #3) > Let's have one request per ticket only (and keep LOOL separate). The request is to improve the separator so it's only one request. For the toolbars I wrote Bug 133691 > > There is a faint line around the sidebar that might be removed when docked > (actually it's not much difference in floating state). But it looks not too > bad with my theme. this very faint line is no big showstopper but it's there and shouldn't be there cause the line has any usage. > And you talk about two horizontal separator lines at the bottom, which I > cannot confirm. One horizontal separator line come from the sidebar (cause the sidebar has an frame line around it) and the second one come from the status bar cause the statusbar has an separator line on top. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133690] Hide surrounding border frame at sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=133690 Heiko Tietze changed: What|Removed |Added Severity|normal |enhancement Summary|Visual improvements:|Hide surrounding border |Sidebar |frame at sidebar --- Comment #3 from Heiko Tietze --- Let's have one request per ticket only (and keep LOOL separate). There is a faint line around the sidebar that might be removed when docked (actually it's not much difference in floating state). But it looks not too bad with my theme. And you talk about two horizontal separator lines at the bottom, which I cannot confirm. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
