[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Dieter changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #27 from Dieter --- VERIFIED with Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 742b8befecbcfc0cfab87cfcd87c83b7d8ef32ab CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Mike Kaganski changed: What|Removed |Added CC||johnsmithbeat...@gmail.com --- Comment #26 from Mike Kaganski --- *** Bug 144638 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Mike Kaganski changed: What|Removed |Added CC||norb...@gmail.com --- Comment #25 from Mike Kaganski --- *** Bug 145176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Justin L changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #24 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/08ede5d51a33f83ededee8a03c10f9bb8244690e tdf#134426 tdf#138873 sw: Revert "tdf#79717 ... It will be available in 7.1.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.2.3 |target:7.3.0 target:7.2.3 ||target:7.1.7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #23 from David --- Thank-you, Justin! Looks Good! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #22 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/49e8691530ea93174fd88727c2451e98a3bd tdf#134426 tdf#138873 sw: Revert "tdf#79717 ... It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 target:7.2.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #21 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/036d45b602c2f554f9bcc21fecbc3e3ac5b834da tdf#134426 tdf#138873 sw: Revert "tdf#79717 ... It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #20 from Justin L --- revert proposed at http://gerrit.libreoffice.org/c/core/+/123566 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||1498 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Justin L changed: What|Removed |Added CC||michael.st...@allotropia.de --- Comment #19 from Justin L --- mstahl could probably fix this properly within an hour. I've spent several hours looking for alternative functions that could snapshot the existing direct formatting and re-apply it, but I've come up empty. SW is just too complex for me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #18 from Justin L --- (In reply to David from comment #17) > I could send someone a modified file if I knew who to send it to. You send it to Gerrit :-) https://wiki.documentfoundation.org/Development/gerrit -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #17 from David --- I could send someone a modified file if I knew who to send it to. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #16 from Justin L --- (In reply to Timur from comment #8) > Fix seems worse than the original issue. I'm in favor of revert. Me too. David, are you interested in crafting the revert? (Unit test, then 04bd1925706360414438b814046b543c5e317d0a, then 6abed0ea006f3616e40faf2ae782cf64f8ac2914 I assume.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Justin L changed: What|Removed |Added CC||goodgu...@zoho.com --- Comment #15 from Justin L --- *** Bug 144456 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #14 from David --- A programmer needs to determine how to handle this. A.) The problem line can be commented out. This would revert the program to behaving like before 6.3 until it's dealt with properly later. B.) All the code associated with tdf#79717 could be removed (currently about 10 lines). Personally I never thought it was a bug to begin with. C.) The problem line could be re-programmed to detect if a character style is used. I don't know how to do that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #13 from Mike Kaganski --- (In reply to David from comment #12) David, it's great that you handle this. Do you need assistance to provide your patch to gerrit? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #12 from David --- I think comment 11 can be disregarded. The issue mentioned in that comment seems to no longer be happening after another re-compile. The problem line seems to be 'aCharAttrSet, SetAttrMode::DEFAULT, );' in wrtsh1.cxx. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #11 from David --- It seems like the line #248 (GetPaMAttr(, aCharAttrSet);) also needs to be executed only if no character styles are used, otherwise if a whole word is replaced it still won't use the automatic character style. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #10 from David --- It seems like in the file 'master/sw/source/uibase/wrtsh/wrtsh1.cxx' that line #269 (SetAttrSet(aCharAttrSet, SetAttrMode::DEFAULT, );) in the function 'bDeleted' should only be executed if there is no character style already set. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4456 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #9 from Telesto --- @Xisco Any change to revert this? Already multiple people in favor of this: 1) Comment 8 2) Same opinion (of Mike Kaganski): bug 144638 comment 11 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4638 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8873 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #8 from Timur --- Fix seems worse than the original issue. I'm in favor of revert. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Timur changed: What|Removed |Added CC||mart.c...@gmail.com --- Comment #7 from Timur --- *** Bug 140521 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||717, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||7532 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #6 from Xisco Faulí --- Still reproducible in Version: 7.1.0.0.alpha1+ Build ID: 9c8ed8c8526b9b696d0bf592eb7d963950f3cef4 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded after fix for bug 137532 regressed from same commit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Mike Kaganski changed: What|Removed |Added Version|6.4.4.2 release |6.3.0.0.alpha0+ CC||phil.kry...@gmail.com Hardware|x86-64 (AMD64) |All Keywords|bibisectRequest |bibisected, bisected --- Comment #5 from Mike Kaganski --- Regression after https://git.libreoffice.org/core/+/6abed0ea006f3616e40faf2ae782cf64f8ac2914 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Mike Kaganski changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #4 from Mike Kaganski --- This is a bug and a regression: was OK in Version: 5.0.0.5 (x64) Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b Locale: ru-RU (ru_RU) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||mikekagan...@hotmail.com Keywords|needsUXEval | --- Comment #3 from Heiko Tietze --- Situation after changing "World" into "Me" Hello Me Smells like a bug. Or what do you think, Mike? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Dieter changed: What|Removed |Added Blocks||107833 Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #2 from Dieter --- I confirm it with Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: he-IL (de_DE); UI: en-GB Calc: threaded It seems, that the substitution is treated as direct formatting. Personally I won't understand it as direct formatting, if you change a word. So I change status to NEW, but add also design-team for further input and decision. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107833 [Bug 107833] [META] Writer paragraph style bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #1 from Georg Jansing --- Created attachment 162549 --> https://bugs.documentfoundation.org/attachment.cgi?id=162549=edit Resulting ODT file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
