[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 Heiko Tietze changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |urss...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #8 from Heiko Tietze --- (In reply to Siddhant Chaudhary from comment #7) > Hi. I would like to work on this issue. Great! To learn how exactly the code works you could debug uui/source/iahndl.cxx UUIInteractionHelper::replaceMessageWithArguments(). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 --- Comment #7 from Siddhant Chaudhary --- Hi. I would like to work on this issue. As of now I can see that STR_OPENLOCKED_MSG (in this file: https://opengrok.libreoffice.org/xref/core/uui/inc/strings.hrc?r=f9ab3136) takes three arguments, of which ARG1 is the file, ARG2 is the username. I'm not sure what ARG3 is. Can someone please clarify this? Then we can probably split this into two strings in which ARG1 and ARG2 go into the "Show Details" expander, and ARG3 remains visible in the dialogue by default. Also, in the handleLockedDocumentRequest_ function in /core/uui/source/iahndl-locking.cxx, can someone tell me exactly how the dialog box is created and how the arguments are passed to STR_OPENLOCKED_MSG to create the dialogue string? Seeing the function for the first time is a bit confusing. Also, what should I learn to be able to add the "Show Details" expander? Thanks for any help! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval |difficultyMedium, easyHack, ||skillCpp, topicUI Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Severity|minor |enhancement Ever confirmed|0 |1 --- Comment #6 from Heiko Tietze --- The topic was on the agenda for the design team meeting. We agree that hiding sensible information would be nice to have. Such a "Show Details" expander could be easily implemented. uui/source/iahndl-locking.cxx uses STR_OPENLOCKED_MSG that needs to be split into two parts, one sentence being always shown the other enclosed in an expander. Difficulty medium since it is a standard dialog now that could be replaced by a UI based dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 --- Comment #5 from Matheod --- The name displayed is the computer name and OS session name and not the name set in Libreoffice option. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 --- Comment #4 from Mike Kaganski --- (In reply to Heiko Tietze from comment #3) The problem of @Matheod was that the normal message telling the user who has locked the file was "nickname used on Internet". This was a user error, when user opened a file on some system, then was attempting to open the same file on another system (and got a legitimate warning - usually in a network environment, this message allows one to know whom to ask to close the file), and the specific situation was that the display was demonstrated to some other people at that time, and user wanted to not show the nickname to those other people. Quite a complex combination, with a simple solution: in your LibreOffice, enter "nickname *not* used on Internet" in Options, instead of "nickname used on Internet". However, the idea to hide the details under a "[+] Show Details" in the dialog looks unproblematic, and if someone wants to implement it, please do. So both WONTFIX and EASYHACK seem appropriate to me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 --- Comment #3 from Heiko Tietze --- (In reply to Mike Kaganski from comment #2) > I think that it's easy not to use nickname used on the Internet. It only > takes a change in Options. Please elaborate. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 Xisco Faulí changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||xiscofa...@libreoffice.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 --- Comment #2 from Mike Kaganski --- I think that it's easy not to use nickname used on the Internet. It only takes a change in Options. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)
https://bugs.documentfoundation.org/show_bug.cgi?id=141026 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||114300 CC||79045_79...@mail.ru, ||mikekagan...@hotmail.com --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Mike, what do you think here? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114300 [Bug 114300] [META] Bugs and enhancements involving lock files or file locking -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
