[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2022-12-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #24 from Buovjaga  ---
*** Bug 137735 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2022-12-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

Lars Jødal  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #23 from Lars Jødal  ---
(In reply to Mike Kaganski from comment #20)
> Fixed by commit 1fe08ae6b383c178a21c926480a055a87f99
> 
> ... which implies that it would likely still fail with more than 200 charts
> on screen (as opposed to 20 before the change).
> Possibly that's OK.

Fine, we are now three people confirming that it works, and >200 charts is
indeed a very high number. Should a new report one day pop up by somebody using
that high number, perhaps this thread will be found, and Mike's report on the
specific commit can be used.

So I'm closing this now as fixed. Thanks for the good work!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2022-12-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #22 from VLB  ---
I have test in
Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

and it works fine now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2022-12-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #21 from matthewn...@yahoo.co.uk ---
Thanks for the notice about which commit (date and tdf#).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2022-12-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1740

--- Comment #20 from Mike Kaganski  ---
Fixed by commit 1fe08ae6b383c178a21c926480a055a87f99

... which implies that it would likely still fail with more than 200 charts on
screen (as opposed to 20 before the change).
Possibly that's OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2022-12-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #19 from Lars Jødal  ---
This bug appears to be solved with the shift from 7.3 to 7.4.

Using LO 7.3.7.2, I reproduce the problem.

Version: 7.3.7.2 (x64) / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: da-DK (da_DK); UI: da-DK
Calc: threaded

However, I do NOT reproduce the bug with LO 7.4.3.2.

Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: da-DK (da_DK); UI: da-DK
Calc: threaded

Mostly for curiosity, testing with a very early 7.4 version, LO 7.4.0.0.alpha1,
I also not reproduce the problem, i.e. the difference seems to be 7.3 -> 7.4.
(But if it can be confirmed that the bug is solved, it becomes less important
exactly what version fixed it - the 7.3.7.2 version was the last in the 7.3.x
line anyway.)

Version: 7.4.0.0.alpha1 (x64) / LibreOffice Community
Build ID: b871abad383583f02eb49c7e49aeae01f6941072
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: da-DK (da_DK); UI: da-DK
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2021-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #18 from Mike Kaganski  ---
(In reply to Xisco Faulí from comment #16)
Heh, f657454b69c813b90a8b3c1adb2feef1066dbd35 still looks strange. Reverting it
does not change things for me (it still does not update some of the charts,
actually not only the top row, but ~randomly); and anyway, functionally it
should not change behavior after initial loading (IIUC).

Just in case: this is not to try to deny things, just something is strange
here. I honestly do not have an idea what's going on here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2021-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #17 from Xisco Faulí  ---
(In reply to Mike Kaganski from comment #15)
> (In reply to Xisco Faulí from comment #14)
> The code changed in 3e6519714abebf00637c953dbba055d620cfe6f7 doesn't get
> called during the updating of the charts in attachment 171427 [details] when
> source data values (e.g., B2) are modified. Is the bibisect correct?

Yep, was incorrect. See comment 16

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2021-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #16 from Xisco Faulí  ---
not a real regression here. As mentioned in
https://bugs.documentfoundation.org/show_bug.cgi?id=86321#c29, This was fixed
(maybe by mistake ) in

https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc28e90d200a839d4017d548217ee5ce8a23f84

author  Noel Grandin  2014-12-25 15:17:55 +0200
committer   Noel Grandin  2015-01-06 10:59:41 +0200
commit  dc28e90d200a839d4017d548217ee5ce8a23f848 (patch)
treea6ae872fb19a046292d96d280da286a20a397def
parent  465356ecc81e23016b4289ab16e99084f2a7b84e (diff)
fdo#84938: convert IMPORT_ constants to 'enum class'

and later reintroduced again in

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f657454b69c813b90a8b3c1adb2feef1066dbd35

author  Mike Kaganski  2017-11-07 13:33:48
+0300
committer   Noel Grandin  2017-11-07
14:26:11 +0100
commit  f657454b69c813b90a8b3c1adb2feef1066dbd35 (patch)
treed1c57e8dc220ae1a5e7d1a2b49025685042318f3
parent  55d00081d0dc4cfa3361fa9da9389042f98773b5 (diff)
tdf#31231: properly check for SvXMLImportFlags::ALL

Adding Cc: to Mike Kaganski

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2021-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #15 from Mike Kaganski  ---
(In reply to Xisco Faulí from comment #14)
The code changed in 3e6519714abebf00637c953dbba055d620cfe6f7 doesn't get called
during the updating of the charts in attachment 171427 when source data values
(e.g., B2) are modified. Is the bibisect correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2021-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=31
   ||231
 CC||mikekagan...@hotmail.com
   Keywords|bibisectRequest, regression |bibisected, bisected

--- Comment #14 from Xisco Faulí  ---
not a real regression here. As mentioned in
https://bugs.documentfoundation.org/show_bug.cgi?id=86321#c29, This was fixed
(maybe by mistake ) in

https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc28e90d200a839d4017d548217ee5ce8a23f84

author  Noel Grandin  2014-12-25 15:17:55 +0200
committer   Noel Grandin  2015-01-06 10:59:41 +0200
commit  dc28e90d200a839d4017d548217ee5ce8a23f848 (patch)
treea6ae872fb19a046292d96d280da286a20a397def
parent  465356ecc81e23016b4289ab16e99084f2a7b84e (diff)
fdo#84938: convert IMPORT_ constants to 'enum class'

and later reintroduced again in

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3e6519714abebf00637c953dbba055d620cfe6f7

author  Mike Kaganski  2020-07-20 19:00:13
+0300
committer   Mike Kaganski  2020-07-20
21:22:48 +0200
commit  3e6519714abebf00637c953dbba055d620cfe6f7 (patch)
tree58a9292c1ff167edd9e1620d205d5383bfff3e18
parent  4d41b22135904e81f847c1cbf00abc82a414095f (diff)
tdf#31231: don't set charts modified state when !IsEnableSetModified

Adding Cc: to Mike Kaganski

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, ( steps in comment 13 )

2021-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141799

Xisco Faulí  changed:

   What|Removed |Added

Summary|Editing: Charts didn't  |Editing: Charts didn't
   |automatic update when   |automatic update when
   |change variable in multiple |change variable in multiple
   |sheets, Must be activated   |sheets, ( steps in comment
   |with F9 or scroll in 7.2.0  |13 )

--- Comment #13 from Xisco Faulí  ---
Steps to reproduce:
1. Open attached document
2. Zoom out so all charts are visible
3. Change B2 to 10

-> The first charts are not updated. Scroll down and up fixes the issue. See
screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs