[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #23 from Xisco Faulí  ---
I wrote a unittest for this issue
 but it hits an assert.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0 target:7.2.2   |target:7.3.0 target:7.2.1
   |target:7.1.6 target:7.2.1   |target:7.1.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #22 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-2-1":

https://git.libreoffice.org/core/commit/25bdfc5404f210ed889e452cb3b7deb016c6c0d3

tdf#143940: the style index might be -1

It will be available in 7.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0 target:7.2.2   |target:7.3.0 target:7.2.2
   |target:7.1.6|target:7.1.6 target:7.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0 target:7.1.7   |target:7.3.0 target:7.2.2
   |target:7.2.2 target:7.1.6   |target:7.1.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #21 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-1-6":

https://git.libreoffice.org/core/commit/105e241b0173bd4e110a73f1f9306616fb64a69b

tdf#143940: the style index might be -1

It will be available in 7.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0 target:7.1.7   |target:7.3.0 target:7.1.7
   |target:7.2.2|target:7.2.2 target:7.1.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #20 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/aecdbb01ea6d89d1e3e25707b0dcd2bedaeb64a6

tdf#143940: the style index might be -1

It will be available in 7.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #19 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/476ad4fe6f62e7b5880f70aa67bfba702fbdef4e

tdf#143940: the style index might be -1

It will be available in 7.1.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0 target:7.1.7   |target:7.3.0 target:7.1.7
   ||target:7.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0|target:7.3.0 target:7.1.7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Timur  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #18 from Heather Ellsworth  ---
Thank you so much for fixing this issue :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://crashreport.libreof
   ||fice.org/stats/signature/rt
   ||l_uString_acquire
Crash report or||["rtl_uString_acquire"]
crash signature||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #17 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7246759822aff30e4e4e1bca7949eae3b0d960ef

tdf#143940: the style index might be -1

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Julien Nabet  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #16 from Julien Nabet  ---
If you remove 1 line and save, then you add a line and save it works.

Eike: I added some traces in ScXMLExport::ExportFormatRanges (see
https://opengrok.libreoffice.org/xref/core/sc/source/filter/xml/xmlexprt.cxx?r=581b2cf7=59108=1525#1525)

OK case when adding a new row after I delete one or more rows first:
...
TODO ExportFormatRanges nStartCol=9 nEndCol=-1 nStartRow=837 nEndRow=838
TODO ExportFormatRanges nStartCol=9 nEndCol=5 nStartRow=838 nEndRow=841
TODO ExportFormatRanges nStartCol=7 nEndCol=1023 nStartRow=841 nEndRow=1048575
TODO ExportFormatRanges nStartCol=0 nEndCol=0 nStartRow=0 nEndRow=0
TODO ExportFormatRanges nStartCol=0 nEndCol=0 nStartRow=0 nEndRow=0

KO case when adding a new row without deleting any rows before:
...
TODO ExportFormatRanges nStartCol=9 nEndCol=-1 nStartRow=836 nEndRow=838
TODO ExportFormatRanges nStartCol=9 nEndCol=-1 nStartRow=838 nEndRow=839
TODO ExportFormatRanges nStartCol=9 nEndCol=5 nStartRow=839 nEndRow=842
TODO ExportFormatRanges nStartCol=7 nEndCol=1023 nStartRow=842 nEndRow=1048576
soffice.bin:
/home/julien/lo/libreoffice/sc/source/filter/xml/xmlexprt.cxx:1499: void
ScXMLExport::OpenRow(const sal_Int32, const sal_Int32, const sal_Int32,
ScXMLCachedRowAttrAccess &): Assertion `nIndex >= 0 && "coverity#1438402"'
failed.

It seems the pb appears when nEndRow=1048576

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #15 from Julien Nabet  ---
I reverted the patch manually + removed an assert instruction, I don't
reproduce the crash indeed.
However, I noticed this log:
warn:legacy.osl:92035:92035:sc/source/filter/xml/XMLStylesExportHelper.cxx:976:
GetStyleNameByIndex: invalid index

OUString* ScColumnRowStylesBase::GetStyleNameByIndex(const sal_Int32 nIndex)
{
if ( nIndex < 0 || nIndex >= sal::static_int_cast(
aStyleNames.size() ) )
{
// should no longer happen, use first style then
OSL_FAIL("GetStyleNameByIndex: invalid index");
return aStyleNames[0];
}
return aStyleNames[nIndex];
}

I may be wrong but IMHO the Noel's patch uncovered an already existing bug
here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Timur  changed:

   What|Removed |Added

Version|7.2.0.1 rc  |6.2.8.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Timur  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com
   Keywords||bibisected, bisected

--- Comment #14 from Timur  ---
6.2 Linux
commit 5e777f23fd0118f6649f0d9e30eb77a72f1099e4
Date:   Fri Aug 17 09:44:34 2018 +0200
source sha:1b95eb30f6358a9ebdedee2888be8273120669c8
pre sha:7125c6798f94a8b7345372ba36dbabd89bab8820

author  Noel Grandin  2018-08-16 
committer   Noel Grandin  2018-08-17 
commit  1b95eb30f6358a9ebdedee2888be8273120669c8 (patch)
tree45ddd96753d0fac4311529da5af61994dfd56181
parent  7125c6798f94a8b7345372ba36dbabd89bab8820 (diff)
loplugin:useuniqueptr in ScColumnRowStylesBase

Hi Noel, please see this Calc crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #13 from Julien Nabet  ---
Created attachment 174403
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174403=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I got an assertion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #12 from Timur  ---
I'll try with bibisect.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Timur  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #11 from Timur  ---
No repro 6.1, repro LO 6.2, 7.2.0 and 7.3+ master in Win 7 64-bit and Lin GTK3
Mint 19 64-bit. Regression.
I added a row above 828.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Timur  changed:

   What|Removed |Added

   Severity|normal  |critical
   Priority|medium  |highest
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #10 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #9 from Heather Ellsworth  ---
I did not test with Windows and unfortunately I don't have a Windows
environment for testing, but the issue is present in Ubuntu 20.04 and newer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #8 from m.a.riosv  ---
I cannot repro with
Version: 7.2.0.4 (x64) / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

Please test with a clean profile, Menu/Help/Restart in Safe Mode

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

Heather Ellsworth  changed:

   What|Removed |Added

 Attachment #174389|0   |1
is obsolete||

--- Comment #7 from Heather Ellsworth  ---
Created attachment 174396
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174396=edit
faulty-spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #6 from Heather Ellsworth  ---
Created attachment 174395
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174395=edit
proc maps

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #5 from Heather Ellsworth  ---
Created attachment 174394
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174394=edit
proc status

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #4 from Heather Ellsworth  ---
Created attachment 174393
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174393=edit
registers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #3 from Heather Ellsworth  ---
Created attachment 174392
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174392=edit
segv analysis

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #2 from Heather Ellsworth  ---
Created attachment 174391
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174391=edit
top of stacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143940] FILESAVE: add a new line in a large spreadsheet and save causes crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143940

--- Comment #1 from Heather Ellsworth  ---
Created attachment 174390
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174390=edit
stacktrace signature

-- 
You are receiving this mail because:
You are the assignee for the bug.