[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 --- Comment #9 from Commit Notification --- Liu Hao committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e3d120e2ba991897bf7d8eff6cc4eba00f7d749e tdf#148430 Use std math functions instead of rtl::math It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 --- Comment #8 from Commit Notification --- Liu Hao committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/466f86abb7208e853ad48ae46e97a2455667fa42 tdf#148430 Use std math functions instead of rtl::math It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0 reviewed:2022 |target:7.4.0 reviewed:2022 ||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 Hossein changed: What|Removed |Added Keywords|difficultyMedium, easyHack, | |skillCpp| Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Hossein --- This issue is discussed in the latest ESC call, as there were concerns on how precise the std implementations of atanh/acosh are on different platforms. The decision was to close the EasyHack. ESC meeting minutes: 2022-08-18 https://lists.freedesktop.org/archives/libreoffice/2022-August/089274.html Therefore, I remove the EasyHack tag from this issue, and also close the issue to keep the internal implementation for now. I think this issue can re-opened if we can make sure the precision of the std implementation of these functions are acceptable on different platforms. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 --- Comment #6 from Hao Liu --- (In reply to Hao Liu from comment #5) > I recently tried fixing this bug, and I found more hidden problems here. > https://gerrit.libreoffice.org/c/core/+/138294 > > The rtl sin/cos/tan implementations are different from std, rtl functions > check the argument with isValidArcArg(), so these three functions can't be > replaced. > > The rtl asin/acos implementations are better than std in some cases > according to > https://bz.apache.org/ooo/show_bug.cgi?id=97605, and It can't pass the unit > tests on some environments. So these two functions can't be replaced too. > > Maybe this bug report is a bit unnecessary? There are not many benefits to > replacing rtl math functions considering these trick problems. Should be asinh/acosh. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 --- Comment #5 from Hao Liu --- I recently tried fixing this bug, and I found more hidden problems here. https://gerrit.libreoffice.org/c/core/+/138294 The rtl sin/cos/tan implementations are different from std, rtl functions check the argument with isValidArcArg(), so these three functions can't be replaced. The rtl asin/acos implementations are better than std in some cases according to https://bz.apache.org/ooo/show_bug.cgi?id=97605, and It can't pass the unit tests on some environments. So these two functions can't be replaced too. Maybe this bug report is a bit unnecessary? There are not many benefits to replacing rtl math functions considering these trick problems. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 --- Comment #4 from Eike Rathke --- Do NOT replace rtl::math::sin(), cos() and tan() with their std::... counterparts. Note that the rtl implementations check the argument with isValidArcArg(), see that comment in include/rtl/math.hxx, and if it's out of range set a NaN at the double, which callers rely on (if aware). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 Hossein changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 reviewed:2022 --- Comment #3 from Hossein --- Re-evaluating the EasyHack in 2022 This enhancement is still relevant. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 --- Comment #2 from Commit Notification --- offtkp committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6f75ec6115f0152517be634070607bc61bf96dd0 tdf#148430 Use atanh from instead of our own It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148430] Use std functions instead of our own implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=148430 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Set to NEW -- You are receiving this mail because: You are the assignee for the bug.
