[Libreoffice-bugs] [Bug 149044] Autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 BogdanB changed: What|Removed |Added Blocks||103369, 105948 Summary|autonumbering and the |Autonumbering and the |action which caused it are |action which caused it are |combined into a single undo |combined into a single undo |step|step CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103369 [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 lvm changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #10 from lvm --- (In reply to Heiko Tietze from comment #9) > (In reply to lvm from comment #8) > > When a keystroke modifies the document and triggers autoformatting... > > That's not true, you enter a paragraph break and the new paragraph is layout > as defined in the style. => NAB Ok, when enter is pressed two things happen: 1. paragraph is split into two 2. style of both is modified to include a list Undo should undo step 2, then step 1, not both together in a single step. If you are implying that under the hood it actually happens the other way around: style changed first, then paragraph is split, that's too bad - underlying technical design is not a consideration in UX. From user's POV enter is pressed to split a paragraph and then list style is applied, and that's how it should be undone. Also this bug was already confirmed (comment 1) so it is NEW, not UNCONFIRMED. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #9 from Heiko Tietze --- (In reply to lvm from comment #8) > When a keystroke modifies the document and triggers autoformatting... That's not true, you enter a paragraph break and the new paragraph is layout as defined in the style. => NAB -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 Dieter changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 lvm changed: What|Removed |Added Status|RESOLVED|NEW Resolution|NOTABUG |--- --- Comment #8 from lvm --- bug 152624 is completely related at all, nor the styles. This bug is about undo's inability to restore the document to the desired state. When a keystroke modifies the document and triggers autoformatting, the first undo step must undo autoformatting only and leave the document in the state after the keystroke modified the document but before autoformatting was applied in case it was applied erroneously, and undo the keystroke itself in a second separate step. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044
Heiko Tietze changed:
What|Removed |Added
Resolution|--- |NOTABUG
Status|NEEDINFO|RESOLVED
--- Comment #7 from Heiko Tietze ---
(In reply to lvm from comment #6)
> (In reply to Heiko Tietze from comment #5)
> > With "autonumbering" do you mean ordered (aka numbered) list?
>
> Yes, but it is the same for bulleted lists. And when undoing 7.4.3.2 now
> selects the trigger expression ("1. " or "* "). If something is already
> selected you get two selections!
The list style (LS) is an attribute of the paragraph style (PS). PS do have
another attribute which defines what PS follows (eg. Text Body after Heading).
If you have a PS with LS that is follows at itself, the usual situation for
ordinary text, it will continue the numbering. There are no two functions.
To "remove" the number you may just toggle the ordered/unordered list off (aka
numbers/bullets) or apply a different PS, depending on how you applied the LS.
See also bug 152624.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044
--- Comment #6 from lvm ---
(In reply to Heiko Tietze from comment #5)
> With "autonumbering" do you mean ordered (aka numbered) list?
Yes, but it is the same for bulleted lists. And when undoing 7.4.3.2 now
selects the trigger expression ("1. " or "* "). If something is already
selected you get two selections!
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Heiko Tietze --- With "autonumbering" do you mean ordered (aka numbered) list? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 Buovjaga changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 --- Comment #4 from lvm --- Actually, we are both correct and the problem is deeper: if after an URL-like text is typed or pasted space bar is pressed, undo undoes only URL autoformatting, to undo the space one has to press ^Z once more. If however one presses enter, undo not only undoes both autoformatting and a new line in a single step, but also for some reason selects the URL text - why? There is no selection after autonumbering is undone. And there is another issue: URL autoformatting is triggered after the first non-URL character is typed, auto numbering however only after a new paragraph - inconsistency again, autonumbering should've been applied as soon as the trigger text "1. " is typed at the beginning of the line. In short, autoformatting and its undo is an inconsistent spaghetti and a good candidate for refactoring, if you ask me. Back to the original point: I am of a very firm opinion that autoformatting and the action which triggered it may not be combined into a single undo step because autoformatting is often wrong and there should be an easy way to undo only autoformatting but not the action which triggered it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 --- Comment #3 from Dieter --- (In reply to lvm from comment #2) > I believe I already explained why it is a bug - it is inconsistent with undo > behaviour for other types of autoformatting in LO e.g. URL recognition. I don't understand. If I type www.example.com and press enter, a new paragraph is inserted and text is recognized as link. Undo deletes paragraph and URL recognition. Perhaps another user understands your argument in a better way. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 lvm changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED CC||lmiro...@yandex.ru Resolution|NOTABUG |--- --- Comment #2 from lvm --- I believe I already explained why it is a bug - it is inconsistent with undo behaviour for other types of autoformatting in LO e.g. URL recognition. This and only this is the correct undo behaviour because it allows one to undo autoformatting if it was not needed without undoing the action which caused it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step
https://bugs.documentfoundation.org/show_bug.cgi?id=149044 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Dieter --- I confirm the observed behaviour with Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL but for me it's the expected behaviour, because you've enabled autonumbering. But it's still possible to ad a line brakt with Ctrl+Enter => NAB Feel free to change i back to UNCONFIRMED with a short reasoning, if you disagree. -- You are receiving this mail because: You are the assignee for the bug.
