[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

Stephan Bergmann  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #10 from Stephan Bergmann  ---
(In reply to Laurent BP from comment #0)
> Description:
> When I tried to customize a menu in LibO 7.4.0 RC1, it freezes LibO

@Laurent:  So, contrary to the bug title "Crash when customizing Menu", this is
about LO freezing rather than crashing?

(In reply to Caolán McNamara from comment #9)
> frame #7 and frame #23 both lock the same std::mutex so that's the hang
> anyway.

...which would be fallout from

"osl::Mutex->std::mutex in ModuleUIConfigurationManager".

@Noel:  Are you confident that that change was sound, and it was guaranteed
that ModuleUIConfigurationManager::m_mutex would never be locked recursively?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

--- Comment #9 from Caolán McNamara  ---
frame #7 and frame #23 both lock the same std::mutex so that's the hang anyway.
Trying a std::recursive_mutex as a quick and easy solution doesn't look trivial
in this case with the various calls to things that only take std::mutex,
alternatively unlocking and relocking before/after elementReplaced etc looks
unappealing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

--- Comment #8 from Heiko Tietze  ---
No crash with 

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: cae349e4770862b36176b601d7d572844c215d4f
CPU threads: 8; OS: Mac OS X 12.4; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded

(build from master with debug information)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

Xisco Faulí  changed:

   What|Removed |Added

   Severity|major   |critical
   Priority|high|highest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7668
 CC||sberg...@redhat.com,
   ||xiscofa...@libreoffice.org
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #7 from Xisco Faulí  ---
Regression introduced by:

author  Stephan Bergmann   2022-03-24 13:52:44 +0100
committer   Stephan Bergmann   2022-03-25 08:21:14
+0100
commit  6e135909d398a08105e2df4cae834e73f253b440 (patch)
tree51bcfd722ca5f18947b0e707150206e6d38b072d
parent  9fd5446c6f3281789ed21847f25cf56ce84dd395 (diff)
tdf#147668: Destroy still needs to do its work when called from disposing

Bisected with: bibisect-linux64-7.4

Adding Cc: to Stephan Bergmann

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #6 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

The location where it freezes is here:
#6  0x7f6ed8dc1911 in
std::unique_lock::unique_lock(std::mutex&) (this=0x7ffc5d950b38,
__m=...) at
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_lock.h:69
#7  0x7f6ed9067c39 in (anonymous
namespace)::ModuleUIConfigurationManager::removeConfigurationListener(com::sun::star::uno::Reference
const&)
(this=0x5a42f30, xListener=uno::Reference to ((anonymous
namespace)::ResourceMenuController *) 0x62269f0) at
framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx:976
#8  0x7f6ed9104633 in (anonymous
namespace)::ResourceMenuController::disposing() (this=0x6226920) at
framework/source/uielement/resourcemenucontroller.cxx:338
#9  0x7f6ed9e7d07d in cppu::WeakComponentImplHelperBase::dispose()
(this=0x6226920) at cppuhelper/source/implbase.cxx:104
#10 0x7f6ed90bb9d5 in
cppu::PartialWeakComponentImplHelper::dispose() (this=0x6226920) at
include/cppuhelper/compbase.hxx:90
#11 0x7f6ed90d6cbf in framework::MenuBarManager::RemoveListener()
(this=0x5b9c740) at framework/source/uielement/menubarmanager.cxx:427
#12 0x7f6ed90d6576 in
framework::MenuBarManager::disposing(std::unique_lock&)
(this=0x5b9c740) at framework/source/uielement/menubarmanager.cxx:151
#13 0x7f6eda3d87ed in comphelper::WeakComponentImplHelperBase::dispose()
(this=0x5b9c740) at comphelper/source/misc/compbase.cxx:25
#14 0x7f6ed8f3a805 in
comphelper::WeakComponentImplHelper::dispose() (this=0x5b9c740) at
include/comphelper/compbase.hxx:71
#15 0x7f6ed90d6e6f in framework::MenuBarManager::RemoveListener()
(this=0x5b958c0) at framework/source/uielement/menubarmanager.cxx:444
#16 0x7f6ed90d6576 in
framework::MenuBarManager::disposing(std::unique_lock&)
(this=0x5b958c0) at framework/source/uielement/menubarmanager.cxx:151
#17 0x7f6eda3d87ed in comphelper::WeakComponentImplHelperBase::dispose()
(this=0x5b958c0) at comphelper/source/misc/compbase.cxx:25
#18 0x7f6ed8f3a805 in
comphelper::WeakComponentImplHelper::dispose() (this=0x5b958c0) at
include/comphelper/compbase.hxx:71
#19 0x7f6ed90d6e6f in framework::MenuBarManager::RemoveListener()
(this=0x5b90900) at framework/source/uielement/menubarmanager.cxx:444
#20 0x7f6ed90dc4ab in
framework::MenuBarManager::SetItemContainer(com::sun::star::uno::Reference
const&)
(this=0x5b90900, rItemContainer=uno::Reference to
(framework::ConstItemContainer *) 0x61adb48) at
framework/source/uielement/menubarmanager.cxx:1446
#21 0x7f6ed90ef5fe in framework::MenuBarWrapper::updateSettings()
(this=0x5b1bc00) at framework/source/uielement/menubarwrapper.cxx:244
#22 0x7f6ed8f39113 in
framework::LayoutManager::elementReplaced(com::sun::star::ui::ConfigurationEvent
const&) (this=0x24d1be0, Event=...) at
framework/source/layoutmanager/layoutmanager.cxx:2993
#23 0x7f6ed9070278 in (anonymous
namespace)::ModuleUIConfigurationManager::implts_notifyContainerListener(com::sun::star::ui::ConfigurationEvent
const&, (anonymous namespace)::ModuleUIConfigurationManager::NotifyOp)
(this=0x5a42f30, aEvent=..., eOp=(anonymous
namespace)::ModuleUIConfigurationManager::NotifyOp_Replace) at
framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx:1636
#24 0x7f6ed9069f8d in (anonymous
namespace)::ModuleUIConfigurationManager::replaceSettings(rtl::OUString const&,
com::sun::star::uno::Reference const&)
(this=0x5a42f30, ResourceURL="private:resource/menubar/menubar",
aNewData=uno::Reference to (framework::RootItemContainer *) 0x87bace8)
at framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx:1258


I don't know enough about mutex mechanism so can't help here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149966] Crash when customizing Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149966

Laurent BP  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
Version|7.5.0.0 alpha0+ Master  |7.4.0.0 alpha1+
 OS|Linux (All) |All
Summary|Customize Menu freezes  |Crash when customizing Menu
   Priority|medium  |high
   Severity|normal  |major

--- Comment #5 from Laurent BP  ---
Reproduced on Win10 with crash with:
- Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: eea7038c182cc1f6cd792359053ea2561a200026
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL
- Version: 7.4.0.1 (x64) / LibreOffice Community
Build ID: 43e5fcfbbadd18fccee5a6f42ddd533e40151bcf
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL
- Version: 7.4.0.0.beta1 (x64) / LibreOffice Community
Build ID: cec1fe9b57a55c032f9f118c907f34e22a63d040
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL
- Version: 7.4.0.0.alpha1 (x64) / LibreOffice Community
Build ID: b871abad383583f02eb49c7e49aeae01f6941072
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL

Change OS to all. Change title freeze to crash. Change version

-- 
You are receiving this mail because:
You are the assignee for the bug.