[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #24 from Stéphane Guillou (stragu) 
 ---
(In reply to Stephan Bergmann from comment #15)
> To avoid guesswork, please always state which repo was used for bibisecting.

Thanks Stephan, will do from now on. It was the Linux 7.4 repo.

Thanks Noel for the fix, and Adolfo for the heads up.

I can verify the fix in:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: da3dd48eaf9086f8ab28d6a6655f9a638e51433a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

wzpdisp: yes, feel free to use 7.3.7 for now, as that branch did not have the
bug you described. Moving forward, you can upgrade to the fixed versions 7.4.4
or 7.5.0 when they are released.

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #23 from Adolfo Jayme Barrientos  ---
Fix merged as commit 80ef2a46f4ac2ac6f3b14561a195262156fe4b85 for trunk
(upcoming 7.5.x series) and as commit 3883454e64d8723d27d357f5fa3c213df59773ca
for 7.4.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #22 from wzpd...@gmail.com ---
Stephane, thanks for the help. Have moved to v7.3.7.2 and can confirm that
version works.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #21 from wzpd...@gmail.com ---
Sorry, names are similar and I was asleep at the switch. Thanks for the help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

Adolfo Jayme Barrientos  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0 target:7.4.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #20 from Stephan Bergmann  ---
(In reply to wzpdisp from comment #19)
> Sorry, My bad.

(Just to make it clear, my request in comment 15 had been directed at the
author of comment 14.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #19 from wzpd...@gmail.com ---
Sorry, My bad.  I thought it obvious since I followed the suggested v7.4.3 D/L
from https://www.libreoffice.org/download/download-libreoffice/ presuming that
was sufficient designation (latest public build of the code).
To be clear is v7.3.7.2 the latest version where this Assign function will work
properly?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #18 from Stephan Bergmann  ---
(In reply to wzpdisp from comment #17)
> Re comment 15, Please note comment 12 identifies specific failing
> version as 7.4.3.

Still, it avoids any unnecessary guesswork if you state the repo that has been
used.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #17 from wzpd...@gmail.com ---
Thanks. Re comment 15, Please note comment 12 identifies specific failing
version as 7.4.3.
Re comment 16 "fix" ??  Is this a coding fix suggestion for LO internal?
Is this fixed in v7.4.3 ?? for the user?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #16 from Noel Grandin  ---
fix at https://gerrit.libreoffice.org/c/core/+/143671

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #15 from Stephan Bergmann  ---
(In reply to Stéphane Guillou (stragu) from comment #14)
> Bisected to:
>  db884ee9f4a730c81d95afbd83283fa786c26b05 is the first bad commit
> commit db884ee9f4a730c81d95afbd83283fa786c26b05
> Author: Jenkins Build User 
> Date:   Fri Mar 25 08:28:04 2022 +0100
> 
> source sha:6e135909d398a08105e2df4cae834e73f253b440

To avoid guesswork, please always state which repo was used for bibisecting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice

2022-12-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Customize: assign user  |Customize: assign user
   |macro to Tools menu fails   |macro to menu fails and
   |and hangs LibreOffice   |hangs LibreOffice
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7668
   Keywords|bibisectRequest |bibisected, bisected
  Regression By||Stephan Bergmann
 CC||noelgran...@gmail.com,
   ||sberg...@redhat.com

--- Comment #14 from Stéphane Guillou (stragu) 
 ---
Not specific to the Tool menu, I can reproduce with others e.g. File.

Bisected to:

db884ee9f4a730c81d95afbd83283fa786c26b05 is the first bad commit
commit db884ee9f4a730c81d95afbd83283fa786c26b05
Author: Jenkins Build User 
Date:   Fri Mar 25 08:28:04 2022 +0100

source sha:6e135909d398a08105e2df4cae834e73f253b440

 instdir/program/libfwklo.so | Bin 5393512 -> 5393512 bytes
 instdir/program/setuprc |   2 +-
 instdir/program/versionrc   |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)

Which points to:

commit  6e135909d398a08105e2df4cae834e73f253b440
author  Stephan Bergmann   Thu Mar 24 13:52:44 2022 +0100
committer   Stephan Bergmann   Fri Mar 25 08:21:14
2022 +0100
tree51bcfd722ca5f18947b0e707150206e6d38b072d
parent  9fd5446c6f3281789ed21847f25cf56ce84dd395

tdf#147668: Destroy still needs to do its work when called from disposing

Which was itself a fix for a regression introduced by:

commit  d4257daba1155ebccbfebea99bad0e4152ca9b08
author  Noel Grandin Fri Dec 24 20:58:28 2021 +0200
committer   Noel Grandin  Sat Dec 25
19:34:05 2021 +0100
treede234db817ce25b7196bde62339d9b76da24dd7e
parent  98dbe250d7d5e3ebe626e8c8650e7fdccd399869

use comphelper::WeakComponentImplHelper in MenuBarManager

Stephan and Noel, could you please have a look? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.