[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3949

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #21 from Caolán McNamara  ---
ah yes, forgot about that recent change, provides some hope.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #20 from Patrick Luby  ---
(In reply to Caolán McNamara from comment #18)
> It's certainly plausible there some "Auto" related problem wrt comment #16
> and buttons in normal dialogs, doesn't happen for me if I manually toggle
> the system from dark to light while it is open, but maybe there is some
> notification we miss if Auto is enabled and that triggers. I wonder if there
> is a way to control the "Auto" so that can be freely tested at any time
> rather than waiting for sunrise :-)

I think that my fix in the following patch may possible be a fix for comment
#16:

https://gerrit.libreoffice.org/c/core/+/148570

LibreOffice uses macOS' HITheme functions to draw native buttons, comboboxes,
listboxes, etc. It seems that HITheme doesn't always properly sense that the
window's dark/light mode setting has changed so I added code to forcefully
update the data/light mode setting when a window becomes the focus window.

I never did find a notification for "auto" dark/light mode in my NeoOffice work
but I am curious if the above patch will fix this bug. The patch should already
be in the LibreOffice 7.6 (master) nightly build if you want to try my fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

steve  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #19 from steve  ---
Stragu and Caolán: thanks for chiming in here.

I agree with Caolán's assessment of this here being a dupe of
https://bugs.documentfoundation.org/show_bug.cgi?id=152486 i.e. white on white
button in notification banner.

In turn that means https://bugs.documentfoundation.org/show_bug.cgi?id=153949
is a different problem. Removed duplicate from that so that we can use it to
track the remaining problem with white on white buttons in dialogs.

Hope this was the right thing to move forward with a sane bug structure.

*** This bug has been marked as a duplicate of bug 152486 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2486

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #18 from Caolán McNamara  ---
I think there's a mix of different things in here, the original one in comment
#1, and comment #11 is a button in an infobar and that looks like a duplicate
of bug #152486

It's certainly plausible there some "Auto" related problem wrt comment #16 and
buttons in normal dialogs, doesn't happen for me if I manually toggle the
system from dark to light while it is open, but maybe there is some
notification we miss if Auto is enabled and that triggers. I wonder if there is
a way to control the "Auto" so that can be freely tested at any time rather
than waiting for sunrise :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||plub...@neooffice.org

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
Caolán and Patrick, what are your thoughts on this one?
Seems to affect both the banner and some dialogs.
Note that duplicate bug 153949 and attachment 185951 might be triggered when
the OS theme switches automatically depending on time of day, whereas OP and
comment 11 are in OS light mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Attachment #185501|Screenshot 3(3) – Start   |Screenshot 3(3) â Start
   filename|Center – Document Preview |Center â Document Preview â
   |– Mouse cursor inside |Mouse cursor inside Start
   |Start Center and inside the |Center and inside the
   |Preview's canvas, hovered   |Preview's canvas, hovered
   |over the Preview's button   |over the Preview's button
   |(visible red button with|(visible red button with
   |white cross, while  |white cross, while
   |document's canvas changed   |document's canvas changed
   |to blue).png|to blue).png
 Attachment #185501|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Attachment #185500|Screenshot 2(3) – Start   |Screenshot 2(3) â Start
   filename|Center – Document Preview |Center â Document Preview â
   |– Mouse cursor inside |Mouse cursor inside Start
   |Start Center and inside the |Center and inside the
   |Preview's canvas, hovered   |Preview's canvas, hovered
   |out of the Preview's button |out of the Preview's button
   |(white or light gray button |(white or light gray button
   |with white cross, while |with white cross, while
   |document's canvas is|document's canvas is
   |blue).png   |blue).png
 Attachment #185500|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Attachment #185499|Screenshot 1(3) – Start   |Screenshot 1(3) â Start
   filename|Center – Document Preview |Center â Document Preview â
   |– Mouse cursor inside |Mouse cursor inside Start
   |Start Center and outside|Center and outside the
   |the Preview's canvas, not   |Preview's canvas, not in
   |in the near of the  |the near of the Preview's
   |Preview's button (any   |button (any button at all
   |button at all visible,  |visible, while document's
   |while document's canvas is  |canvas is light gray).png
   |light gray).png |
 Attachment #185499|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #16 from steve  ---
Created attachment 185951
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185951=edit
page properties dialog using dark mode after a while

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

steve  changed:

   What|Removed |Added

Summary|Some buttons are|Some buttons are
   |white-on-white on macOS in  |white-on-white on macOS
   |light mode  |
   Priority|medium  |high

--- Comment #15 from steve  ---
Not limited to light mode.

https://bugs.documentfoundation.org/show_bug.cgi?id=153949 reports this problem
for dark mode dialog buttons and I can confirm also running into this problem
using dark mode.

Upping priority, since the buttons become unreadable and by that unusable. The
easy workaround is to restart LibreOffice, but that is not really convenient.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS in light mode

2023-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

steve  changed:

   What|Removed |Added

 CC||st...@78ff.de

--- Comment #14 from steve  ---
*** Bug 153949 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS in light mode

2023-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||bun...@gmail.com

--- Comment #13 from Stéphane Guillou (stragu) 
 ---
*** Bug 153594 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS in light mode

2023-03-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #12 from Sierk Bornemann  ---
(In reply to Stéphane Guillou (stragu) from comment #11)

> Sierk, I would recommend opening a new ticket about the issue you are seeing
> in the start centre, because they are quite different (this issue in light
> mode, your issue in dark mode), and therefore unlikely to be fixed in one
> go. You can still link to this issue from there.
> Thank you!

Done. See new bug #153943.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS in light mode

2023-03-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Sierk Bornemann  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3943

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS in light mode

2023-03-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Hardware|ARM |All
   Keywords||accessibility
Summary|Some buttons are|Some buttons are
   |white-on-white on macOS |white-on-white on macOS in
   ||light mode

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
Thank you Ken, I can now reproduce the issue as seen in attachment 185158 when
macOS is in light mode, for the Release Notes banner.

Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 2; OS: Mac OS X 12.6.1; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Sierk, I would recommend opening a new ticket about the issue you are seeing in
the start centre, because they are quite different (this issue in light mode,
your issue in dark mode), and therefore unlikely to be fixed in one go. You can
still link to this issue from there.
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #10 from Ken Shirriff  ---
Stéphane, I'm using light mode in macOS. I haven't done any customization of
toolbars beyond maybe enabling some of them. The problem happens in Safe Mode
too, which I think bypasses customization?

Version information:
Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 8; OS: Mac OS X 13.0.1; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Sierk Bornemann  changed:

   What|Removed |Added

 Blocks||42082


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=42082
[Bug 42082] [META] Make LibreOffice shine and glow on macOS
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #9 from Sierk Bornemann  ---
Comment #4 to #8:

Version: 7.5.1.1 (AARCH64) / LibreOffice Community
Build ID: bd819218336a5be54a11b986ea4dd2db2efb120e
CPU threads: 10; OS: Mac OS X 13.2.1; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

Version: 7.6.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 16a35542aa07ed69c6c699d1c17f076d87708958
CPU threads: 10; OS: Mac OS X 13.2.1; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Sierk Bornemann  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #8 from Sierk Bornemann  ---
Created attachment 185501
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185501=edit
Screenshot 3(3) – Start Center – Document Preview

Screenshot 3(3) – Start Center – Document Preview – Mouse cursor inside Start
Center and inside the Preview's canvas, hovered over the Preview's button
(visible red button with white cross, while document's canvas changed to blue)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #7 from Sierk Bornemann  ---
Created attachment 185500
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185500=edit
Screenshot 2(3) – Start Center – Document Preview

Screenshot 2(3) – Start Center – Document Preview – Mouse cursor inside Start
Center and inside the Preview's canvas, hovered out of the Preview's button
(white or light gray button with white cross, while document's canvas is blue)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #6 from Sierk Bornemann  ---
Created attachment 185499
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185499=edit
Screenshot 1(3) – Start Center – Document Preview

Screenshot 1(3) – Start Center – Document Preview – Mouse cursor inside Start
Center and outside the Preview's canvas, not in the near of the Preview's
button (any button at all visible, while document's canvas is light gray)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #5 from Sierk Bornemann  ---
(In reply to Sierk Bornemann from comment #4)

> Screenshot 1(3) – Start Center – Document Preview – Mouse cursor inside
> Start Center and outside the Preview's canvas, not in the near of the
> Preview's button (any button at all visible, while document's canvas is
> light gray)

Correction:

Screenshot 3(3) – Start Center – Document Preview – Mouse cursor inside Start
Center and inside the Preview's canvas, hovered over the Preview's button
(visible red button with white cross, while document's canvas changed to blue)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #4 from Sierk Bornemann  ---
I can't reproduce the given example above (if I don't err, it has been fixed
several days ago), but

I can reproduce and confirm the issue in question at an example of another kind
of button (Preview view of document in Start Center), that I see unfixed since
several weeks, see screenshots:

Screenshot 1(3) – Start Center – Document Preview – Mouse cursor inside Start
Center and outside the Preview's canvas, not in the near of the Preview's
button (any button at all visible, while document's canvas is light gray)

Screenshot 2(3) – Start Center – Document Preview – Mouse cursor inside Start
Center and inside the Preview's canvas, hovered out of the Preview's button
(white or light gray button with white cross, while document's canvas is blue)

Screenshot 1(3) – Start Center – Document Preview – Mouse cursor inside Start
Center and outside the Preview's canvas, not in the near of the Preview's
button (any button at all visible, while document's canvas is light gray)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
I haven't managed to reproduce the issue with:

Version: 7.4.5.1 / LibreOffice Community
Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f
CPU threads: 2; OS: Mac OS X 12.6.1; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 2; OS: Mac OS X 12.6.1; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

- Do you use dark or light theme in macOS?
- Did you change the user interface / customise the toolbars?
- Can you please paste here the information copied from LibreOffice > About
LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #2 from Ken Shirriff  ---
The Release Notes button is white-on-white in Safe Mode too, by the way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS

2023-02-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153416

--- Comment #1 from Ken Shirriff  ---
Sometimes buttons show up unreadable as white-on-white. The screenshot shows
the Release Notes button as a white oval.

I have seen this occasionally on earlier versions. Often the "Save Document"
dialog will show the "Don't Save" and "Cancel" buttons but the "Save" button is
white-on-white. So this seems to be associated with highlighted buttons.

Repeatability: it happens often enough that I decided to file a bug, but I
can't make it happen on demand.

I'm not doing anything strange with my display or themes that might make this
happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.