[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #11 from maison  ---
Thanks for the update, but having the empty field is not les destructive than
having it populated with any other value, as you can still replace your data
with an empty string if you accidentally click the Replace buttons. If you want
to avoid potential damage (if someone can’t undo), then it should be the search
string to be reset, not the replace string.

It’ll be a peculiarity for LO compared to other software.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #10 from Heiko Tietze  ---
We discussed the topic in the design meeting and decided to resolve WF.

It might be a common use case to search for different content and replace it by
the same value. But it is definitely not the most relevant. It is easy to
select the last used item, and we should protect potentially destructive
actions (with the preselection wit risk accidental replacing).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Version|7.5.2.2 release |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #9 from maison  ---
(In reply to Heiko Tietze from comment #8)
> (In reply to maison from comment #7)
> > As a side note, what do you mean by Alt P?
> The mnemonic is the character in a label that can be used to activate the
> item per alt+. The letter is typically underlined but depending on the
> OS and desktop environment not visible until you press alt.
> 
> https://en.wikipedia.org/wiki/Mnemonics_(keyboard)

That’s what I thought. You were mentioning how to trigger the Replace button,
whereas Eyal and all the conversation here is how to have the replacement text
ready for the Replace button. That’s different.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #8 from Heiko Tietze  ---
(In reply to maison from comment #7)
> As a side note, what do you mean by Alt P?
The mnemonic is the character in a label that can be used to activate the item
per alt+. The letter is typically underlined but depending on the OS and
desktop environment not visible until you press alt.

https://en.wikipedia.org/wiki/Mnemonics_(keyboard)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #7 from maison  ---
(In reply to Heiko Tietze from comment #6)
> > * It's easy to re-select the search term if you're actively using the mouse
> Or the alt+P mnemonic (depending on the localization) 

As a side note, what do you mean by Alt P? In my localisation, it triggers the
Rep͟lace button rather than recall the last replacement item.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #6 from Heiko Tietze  ---
(In reply to Eyal Rozenberg from comment #5)
> * It's easy to re-select the search term if you're actively using the mouse
Or the alt+P mnemonic (depending on the localization) 

> 1. You replace "somethingfoo" with "anotherfoo"...
All good example. We need to balance the benefit from _preselecting_ the last
replacement with the odds of doing so. And I tend to disagree with the
importance of the repeated replacement workflow.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #5 from Eyal Rozenberg  ---
Points in favor:

* I find benefit in having the same replace-string again (see below).
* All sorts of other apps have this, e.g. CLion IDE, gedit, Geany IDE
* It's annoying to re-select the replace term in calc

Points against:

* It's easy to re-select the search term if you're actively using the mouse
* It not difficult to re-select the replace term in Writer
* Some apps don't have this feature e.g. Thunderbird
* User might accidentally replace with a term they did not intend to use

(In reply to Heiko Tietze from comment #3)
> I wonder what workflow requires to repeat search / replace operations.

Oh, come on, that's obvious!

1. You replace "somethingfoo" with "anotherfoo"; then you want to replace
"somethingbar" with "anotherbar". So you start with "anotherbar" and edit just
the suffix.
2. You replace some complex regexp with another complex pattern using matched
subexpressions. But then you notice that first search pattern only captures
some of the cases, so you modify it, while still replacing with the exact same
pattern
3. You're replacing with a term like "N/A" or "0"; and there are multiple kinds
of things you want to "reset to default" that way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

maison  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #4 from maison  ---
(In reply to Heiko Tietze from comment #3)
> I wonder what workflow requires to repeat search / replace operations.
> Neither it's a "quirkiness" to me (haven't checked Microsoft apps). Do you
> have a real life example to support the enhancement need?

Or see it in the opposite way, what workflow example there is where you want to
search for the same thing, but this time delete your text rather than replace
it with what was previously set? Deleting your search text (which happens when
you don’t have a replacement text set) is a very strong assumption, which is
very unlikely that it is what the user wants the second time.
Or why set the search text again & all the other options in the popup window,
but not the replace text?

It makes no sense to me (and indeed Microsoft Office users are not used to
having some of their setting disappear). Also let’s speak about several
software as diverse as advanced text editors, Calibre, Directory Opus, Abbyy
FineReader… I can hardly find something that deletes half of the Search &
Replace settings.

Anyway as an easy to understand workflow, you search and replace a few things,
then you realise that you need more attention for this place, so you close the
window to work on it properly, then you want to resume your search, and now you
have to press Tab Tab Tab Tab Tab… (don’t press too automatically or you have
to start over!)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Heiko Tietze  ---
I wonder what workflow requires to repeat search / replace operations. Neither
it's a "quirkiness" to me (haven't checked Microsoft apps). Do you have a real
life example to support the enhancement need?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

--- Comment #2 from maison  ---
(In reply to V Stuart Foote from comment #1)
> Sorry, not seeing the need.
> 
> On open the dialog, cursor focus is in the Find field
> 
> Three  (to pass over find configuration check-boxes) to position to
> the Replace field
> 
> Cursor  (or up) to fill items from Replacement stack.

Maybe because you use Writer. I mostly use Calc, which has more (too many) Tabs
to press until you reach that box, then press another key, which is enough to
interrupt the workflow.

Even today it’s risk free as the first assigned button is Search for next and
not Replace as you suggest.

But that statement is also not true, as with the replace field empty you can
still delete your data if you inadvertently click the Replace all button.

Anyway, as I said, it’s an interface quirkiness that no other software that I’m
aware of chose.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from V Stuart Foote  ---
Sorry, not seeing the need.

On open the dialog, cursor focus is in the Find field

Three  (to pass over find configuration check-boxes) to position to the
Replace field

Cursor  (or up) to fill items from Replacement stack.

This is functional, both with mouse pointer and with keyboard selection.

Also, it is risk free.  With nothing selected for the replacement string--no
inadvertent replacement can occur (necessitation UNDO if caught, or loss of
data if not).

I suppose we could refactor to optionally prefill the replace field--but it
would need to be off by default and an Expert configuration. Not clear it is
worth the effort or risk to the "Benjamin" users.

IMHO => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |2847|
 Blocks||102847
   Severity|normal  |enhancement


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
[Bug 102847] [META] Quick Find, Search and Replace
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154831] Replace string is empty

2023-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154831

maison  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2847

-- 
You are receiving this mail because:
You are the assignee for the bug.