[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #15 from Stéphane Guillou (stragu) 
 ---
Thanks for checking, Jim.

Not sure what the grey area is... maybe denoting the wrap spacing? Should
probably be documented, maybe something for another ticket.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

Jim Avera  changed:

   What|Removed |Added

 Attachment #190051|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #14 from Jim Avera  ---
Ignore that.  The alt2.odt test case had Vertical Position referenced to
"Character" not "Baseline", so the rectangle is correct in that case.

So I now also confirm the problem as reported is fixed.  Thank you.


P.S. What does the small grey-filled box in the middle denote?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #13 from Jim Avera  ---
I used different test case when dis-confirming -- which I just uploaded as
noredline_alt2.odt
This one initially shows a red box, not line. 

However switching the anchor to something else and back to "As Character" makes
the line appear.   Do you think this is an unrelated bug?

In summary: We saw different results because of the instability noted by
Stéphane in Comment 11.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #12 from Jim Avera  ---
Created attachment 190051
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190051=edit
noredline_alt2.odt (a different test case which shows rectangle initially)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
(In reply to Jim Avera from comment #8)
> DIS-CONFIRMING!  I downloaded 7.6.3 daily -- the build page says it includes
> Noel's commit 375258b.

What exact steps are you using?
I can see a case where a box is shown instead of a line, but that predates the
regression (I can reproduce in LO 7.3):
1. Open attachment 189455
2. Open frame's Properties > Type: line is shown
3. Click on "To character"
4. Click back on "As character"

Result: a box is shown instead of a line.
But this should be reported separately, if not already reported.

Can you provide an example that is not reproducible before 7.4 alpha?
As far as I can tell, the regression is fixed in both 24.2 and 7.6.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #10 from Jim Avera  ---
Created attachment 190023
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190023=edit
Screenshot showing red box but no Baseline

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

Jim Avera  changed:

   What|Removed |Added

 Attachment #190022|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #9 from Jim Avera  ---
Created attachment 190022
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190022=edit
Screenshot showing red box but not baseline

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #8 from Jim Avera  ---
DIS-CONFIRMING!  I downloaded 7.6.3 daily -- the build page says it includes
Noel's commit 375258b.

I see only a red *rectangle* around the whole text; no Baseline is shown in any
color.  

(Baseline means the vertical position of the bottom of characters which have no
descender, as shown at
https://en.wikipedia.org/wiki/Baseline_(typography)#/media/File:Typography_Line_Terms.svg)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Thanks Noel, verified the fix in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f95c3994f0b6a82a3bc2ddfb68822b74479ae185
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #6 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/375258bd740f6193b7756c086c7fd08985e22e84

tdf#157164 Vertical Position preview does not show red line for baseline

It will be available in 7.6.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0   |target:24.2.0 target:7.6.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

--- Comment #5 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5b2ae79edde95f485e381741f816d45248798778

tdf#157164 Vertical Position preview does not show red line for baseline

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157164] Frame > Position and Size > Vertical Position preview does not show red line for baseline anymore

2023-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157164

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Whiteboard| QA:needsComment|
Version|7.5.5.2 release |7.4.0.0 alpha0+
  Regression By||Noel Grandin
Summary|Frame Vertical Posn preview |Frame > Position and Size >
   |does not look like  |Vertical Position preview
   |documentation says  |does not show red line for
   ||baseline anymore
  Component|Documentation   |Writer
 Ever confirmed|0   |1
 Blocks||103305
 Status|UNCONFIRMED |NEW
   Keywords||bibisected, bisected,
   ||regression

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Thank you for the report, Jim!
Seems we lost the red line in version 7.4.

Bibisected with linux-64-7.4 repo to first bad commit
1579738cb8c7d4928f9e887ea6641f21e2921333 which points to core commit:

commit  f510ea2d7962a4325055c6380a0032331b4e87cf
author  Noel Grandin Wed Jan 12 11:49:35 2022 +0200
committer   Noel Grandin Wed Jan 12 14:06:28 2022 +0100
don't bother trying to draw stuff which is effectively invisible
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128312

Noel, can you please have a look?

Repro in recent master:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2902ab24ecc5ffbf4907ea83b2028508b9de6364
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103305
[Bug 103305] [META] Frame dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.