[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View, deletes slides
https://bugs.freedesktop.org/show_bug.cgi?id=49610 --- Comment #19 from Michael Meeks michael.me...@novell.com --- Looks like it just needs a simple back-port to -3-6 ... :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View, deletes slides
https://bugs.freedesktop.org/show_bug.cgi?id=49610 Michael Meeks michael.me...@novell.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #20 from Michael Meeks michael.me...@novell.com --- Pushed to -3-6 and closed; looks like this just needed a back-port. Thanks for the report ! :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View, deletes slides
https://bugs.freedesktop.org/show_bug.cgi?id=49610
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
Summary|EDITING: Terminating 'Find' |EDITING: Terminating 'Find'
| when reached end of| when reached end of
|document second time brings |document second time brings
|up Master View|up Master View, deletes
||slides
--- Comment #17 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
Damages still [Reproducible] with LibreOffice 3.6.3.1” German UI/ German
Locale [Build-ID: f8fce0b] on German WIN7 Home Premium (64bit),
but ok with parallel installation of Master LOdev 3.7.0.0.alpha0+ -
ENGLISH UI / German Locale [Build ID: 370m0(Build:0)] {tinderbox: @6, pull
time 2012-10-20 14:21:35} on German WIN7 Home Premium (64bit) with separate
User Profile for Master Branch
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View, deletes slides
https://bugs.freedesktop.org/show_bug.cgi?id=49610 --- Comment #18 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- I nominated this one as HardHack on http://wiki.documentfoundation.org/HardHacks#General -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View
https://bugs.freedesktop.org/show_bug.cgi?id=49610 --- Comment #16 from Radek Doulik r...@novell.com 2012-06-28 01:53:43 PDT --- I have pushed fix to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca644612762921e772ca95d5e8737325d9f343d2 It changes the behavior of spell/find to remember only the starting position. I have also tried hard to find the difference the Commit bdfbbb33a491f3ce34375de14ba33436b04 slidesorter1: #i116014# Outliner holds ViewShell as weak_ptr. introduced. The change happens deep inside the framework::FrameworkHelper::Instance(rBase)-RequestSynchronousUpdate(); call. It goes down to void DrawViewShell::ReadFrameViewData(FrameView* pView) where master page edit mode is used B+│311 EditMode eNewEditMode = pView-GetViewShEditMode(mePageKind); │ │312 sal_Bool bNewLayerMode = pView-IsLayerMode(); │ │313 ChangeEditMode(eNewEditMode, bNewLayerMode); It comes from meStandardEditMode, which I wasn't able to find out why it was set differently compared to the time before the bisected commit. So I guess it might be either result of syncing the asynchronous events differently or some change we missed in the problematic commit. After I changed the behavior with my fix, it works as expected, at least I hope so. Hopefully it will not introduce other regressions. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View
https://bugs.freedesktop.org/show_bug.cgi?id=49610 --- Comment #15 from pjacq...@gmx.ch 2012-06-23 03:03:25 PDT --- @Radek: Here some extract of mails in lib-dev list, between me and Thorsten: * goal of this patch and the fact it is the suspect:Answer from Thorsten: well the goal was to decouple live cycles of Outliner and ViewShell - sadly the change mixes a lot of reformatting with that fix. Hard to tell if that is now causing some ripple effects. :/ Later I wrote: --- I locally reverted bdfbbb33a491f3ce34375de14ba33436b04 [..] I can confirm this is the origin of the problem. [..] I also have to say honestly that fixing this patch is beyond my knowledge of LibO code in this area. So if you say OK, I will push my revert to master. This is not the most polite way of fixing it. destroying your correction, but the one that fit to my knowledge there. Or have you time to investigate it and fix it ? Sorry, this sounds not very constructive, but in this period I do not have a lot of free time, so I can not offer more. So if you have time / knowledge to do it, it would be the best. Else reverting it would destroy the change mentioned above. But I think for users, this is less problematic than the current status. Your input? Thanks -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View
https://bugs.freedesktop.org/show_bug.cgi?id=49610 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Severity|critical|normal Priority|highest |medium Summary|EDITING: Terminating 'Find' |EDITING: Terminating 'Find' | when reached end of| when reached end of |document second time|document second time brings |deletes slides, replaces|up Master View |contents by templates | --- Comment #13 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-22 03:23:02 PDT --- @Radek: You are absolutely right - where have I had my eyes?! That's still annoying and worrying, but definitively not critical. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49610] EDITING: Terminating 'Find' when reached end of document second time brings up Master View
https://bugs.freedesktop.org/show_bug.cgi?id=49610 --- Comment #14 from Radek Doulik r...@novell.com 2012-06-22 04:48:22 PDT --- Commit bdfbbb33a491f3ce34375de14ba33436b04 slidesorter1: #i116014# Outliner holds ViewShell as weak_ptr. indeed introduces this problem/regression. pjacq...@gmx.ch, do you want to work on it, or should I try fix it? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
