[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343
Bug 67343 depends on bug 112677, which changed state.

Bug 112677 Summary: [UI] Help button should be on the left of dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=112677

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

Gabor Kelemen  changed:

   What|Removed |Added

 Depends on||112677


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112677
[Bug 112677] [UI] Help button should be on the left of dialog
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

--- Comment #10 from Xisco Faulí  ---
Extract from IRC:
 x1sc0: on tdf#67343, the remaining dialogs (if any) are deeply
burried into corner cases. To get all of them we need a script on the ui files
and detect the position of the Help button - modulo if buttons are verticaly
aligned -  and extract the faulty.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #9 from Xisco Faulí  ---
Hi,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

--- Comment #7 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c5ee428672ec63dc97d7e92f32c112bd9347fdbd

tdf#67343 Standardize order of dialog buttons

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

--- Comment #8 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a6f876d45bd4e41a7143594a6cb11b6893a0f620

tdf#67343 Standardize order of dialog buttons

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:4.5.0 target:5.1.0  | target:4.5.0 target:5.1.0
   ||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

--- Comment #6 from Timur gti...@gmail.com ---
Also, buttons should behave properly. For example, Cancel should cancel the
operation, as in Bug 86671, where Cancel now behaves as No.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard| target:4.5.0   | target:4.5.0 target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67343

--- Comment #5 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b9ece6a182bc116c1fe4c842514e85f219b1f4d3

tdf#67343 Arrange Help button in a seconday group (extensions)

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67343

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|| target:4.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67343

--- Comment #4 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=adfc260b4bdce558855a12cb3985c2da026d3a8d

fdo#67343 Arrange Help button in a secondary group

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67343

Jorendc jore...@libreoffice.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Severity|normal  |enhancement
 CC||jore...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #3 from Jorendc jore...@libreoffice.org ---
Ok, lets mark as NEW for the moment. If this task is done (after all dialogs
are converted) we can mark it as fixed. Until now still a valid and new
enhancement request.

Kind regards,
Joren

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67343

Caolán McNamara caol...@redhat.com changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #1 from Caolán McNamara caol...@redhat.com ---
The plan is to convert everything to .ui format, keeping the button order
unchanged from pre .ui to post .ui until we are complete, or near complete, and
then sort the button ordering automatically in the native order of the
platform/desktop environment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67343] Standardize order of OK, Cancel, Help buttons in all dialog windows

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67343

--- Comment #2 from Owen Genat owen.ge...@gmail.com ---
This matter was raised on the LO Design list about a month ago. This page of
illustrative dialog examples was provided:

https://wiki.documentfoundation.org/User:Eresus

Thanks for the information Caolán about the manner in which this is to occur.
This part of the Guidelines section of TDF Development WidgetLayout page
(https://wiki.documentfoundation.org/Development/WidgetLayout#Guidelines)
appears to relate to what you mention:

Use ok, help, cancel, close, save, etc. as the names for the gtk-ok, 
gtk-help, gtk-cancel, etc buttons. This is important to allow button 
reordering 
to match the current windowing environment rules. For message boxes, the 
button 
names of discard, cancel and save enable the Windows+KDE save-discard-
cancel vs GNOME+MacOSX discard-cancel-save layout rules.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs