[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Tor Lillqvist  changed:

   What|Removed |Added

   Keywords|difficultyBeginner, |
   |easyHack, skillCpp, |
   |topicCleanup|

--- Comment #25 from Tor Lillqvist  ---
Lots of this has already been handled by Mike Kaganski (who was not aware there
was an Easy Hack for it). What remains is not an Easy Hack any more, he says,
so removing those keywords.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #24 from Tor Lillqvist  ---
This is certainly not a "large scale cosmetic change".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #23 from jan iversen  ---
Please be aware, that this easyhack is considered an important but large scale
cosmetic change as described in
https://wiki.documentfoundation.org/Development/LargeScaleChanges

It was in decided by the ESC to close this kind of easyhacks, and send them
directly as mail, to new contributors.
https://lists.freedesktop.org/archives/libreoffice/2016-August/074920.html

Please do not submit patches with many files !!

This particular easyhack is kept open as an exception to the rule

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #22 from jan iversen  ---
Still a lot of .mk files to correct

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #21 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a17c118f312699ab26147148cd2e7844c41a777

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #20 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a50cdeb70ec19369f42ed08abfd4a5301d05edb5

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Michael Stahl  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #19 from Michael Stahl  ---
there are still lots of TCHARs being used, see "git grep TCHAR"

most of them are in "workben" and "test" directories that
are not actually built currently but there are a bunch in
desktop, dtrans, embedserv, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

jan iversen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from jan iversen  ---
Seems solved

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #17 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=29e0b587df4e509558c22fa478992b07486828d1

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #16 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7fe92c766adf97bdeb4d844ffe6d0650a964572e

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0|target:5.2.0 target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #15 from Stuart Swales  ---
Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

setup_native/source/win32/customactions/shellextensions in MSI Installer
compiled as UNICODE

Functions suffixed with A/W (ANSI/Wide) as needed for clarity

Please find patch at:

https://gerrit.libreoffice.org/#/c/25556/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #14 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=68502698d29e577a7a451f1a796677128901cfe3

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #13 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=074bd09ee6f3113792b60ee721aabb731c5d7ace

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #12 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=163dcad72e03e214d842e74d1f71ed025cbdd870

Work towards tdf#72606

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #11 from Stuart Swales  ---
More work towards _tstring/TCHAR elimination

Used explicit A/W suffixes on functions for clarity and consistency in sellang
module of MSI Installer

Please find this patch at https://gerrit.libreoffice.org/25167

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #10 from Stuart Swales  ---
More work towards _tstring/TCHAR elimination

Quickstarter code in MSI Installer compiled UNICODE

Used explicit A/W suffixes on functions for clarity

Please find this patch at https://gerrit.libreoffice.org/25153

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #9 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a4dd6f45b12e7d44ad595bc0fadc37075061119

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #8 from Stuart Swales  ---
As a first step towards addressing this issue I have eliminated the TCHAR mess
from one of the modules used in the Windows MSI installer.

Built OK and the resulting installer worked correctly.

If this style is acceptable to progress in LibreOffice I will do so.

Please find patch at:

https://gerrit.libreoffice.org/#/c/24707/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Robinson Tryon (qubit)  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp,
   ||topicCleanup

--- Comment #6 from Robinson Tryon (qubit)  ---
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp,
topicCleanup)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Robinson Tryon (qubit)  changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |
   |SkillCpp TopicCleanup   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #4 from Michael Stahl  ---
maybe it would be better to move directly to removing the #ifdef UNICODE
everywhere, e.g. look at this nonsense all over
setup_native/source/win32/customactions/shellextensions/

#ifdef UNICODE
#define _UNICODE
#define _tstringwstring
#else
#define _tstringstring
#endif

that requires other headers to be included in a particular order, etc.

just call *W functions and use std::wstring.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #5 from Tor Lillqvist  ---
Also, related to this, we should not use any of the  madness anywhere.
No _TCHAR, TEXT(), _tcs*(). Just use wchar_t and the wcs*() functions directly
if that is what is meant. (Or, char and str*() if not.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=72606

--- Comment #1 from vancuvit vitek.c...@seznam.cz ---
Hello, I would like to participate on this bug, is there any progress made by
someone else (to cooperate work...)? Thanks for feedback

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=72606

vancuvit vitek.c...@seznam.cz changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |vitek.c...@seznam.cz
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=72606

vancuvit vitek.c...@seznam.cz changed:

   What|Removed |Added

   Assignee|vitek.c...@seznam.cz|libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=72606

--- Comment #3 from vancuvit vitek.c...@seznam.cz ---
(In reply to comment #2)
 Please don't assign a bug to yourself unless you are very sure that you
 actually will be fixing it in a reasonable timeframe. If you just want to
 try, but don't know if you will succeed or not, it's enough to leave a
 comment.
 
 (The above is obviously just my personal opinion, not some official rule.)

Ok sorry for that, i changed it back. I will work on that...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=72606

Michael Stahl mst...@redhat.com changed:

   What|Removed |Added

 Whiteboard||EasyHack DifficultyBeginner
   ||SkillCpp TopicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs