[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Michael Meeks michael.me...@collabora.com --- Hi Hussain - thanks for that ! =) one reason we do this is to gain vertical space - so more can be seen on the screen; it'd be great to have a second clean-up to have just single lines between the functions in framework you touched there I guess. Anyhow - I've pushed it for now; can you send a license statement to the developers' mailing list: https://wiki.documentfoundation.org/Development/Developers#Example_Statement And great to have you involved ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 --- Comment #6 from Hussian Alamri husain.a...@gmail.com --- Greetings, Thank you for accepting my patch. Sure, I will gladly do another cleanup to have single lines between functions. Where should I send the patch once I'm done? This bug seem to have been closed. I sent an email to the developers list regarding the license. All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Once I'm familiar with LibreOffice I want to contribute in fixing more advanced bugs and/or implementing features. -- Alamri Hussian -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 --- Comment #1 from Hussian Alamri husain.a...@gmail.com --- Hello everyone, I am new as a contributor to LibreOffice but have been a user for many years. I love the work everyone has been doing. Does this bug require building LibreOffice? If not I will start working on it right away. -- Hussian -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 --- Comment #2 from Michael Meeks michael.me...@collabora.com --- Building is not so hard =) but no it doesn't really require building. Just get a git checkout, and poke at those files ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 --- Comment #3 from Hussian Alamri husain.a...@gmail.com --- (In reply to comment #2) Building is not so hard =) but no it doesn't really require building. Just get a git checkout, and poke at those files ... I have experience developing and building projects on Linux but at the moment I'm on a Mac (10.9.2) and make failed when I tried to build. Plus I have a slow machine so I don't want to build on it, last time I compiled a project from source it took near 4 hours. I will look further into it but I wanted something I can contribute to quick. I finished removing the comments. I'm new to git. I did git checkout, is that all or do I also need to do git format-patch origin/master? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 --- Comment #4 from Hussian Alamri husain.a...@gmail.com --- Created attachment 98998 -- https://bugs.freedesktop.org/attachment.cgi?id=98998action=edit Removed redundant comments I am new to git and LibreOffice source base. I have removed the redundant comments as in the bug's description. If rejected please let me know how I can fix it. If accepted, I will be more than glad to do any janitorial work (code cleanup, redundant comments, formatting, etc...). -- Alamri Hussian -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Whiteboard||EasyHack DifficultyBeginner ||SkillCpp TopicCleanup -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
