[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

Michael Meeks  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #9 from Michael Meeks  ---
Thanks Deb - good point; closing ... =)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

--- Comment #8 from Deb  ---
There's no longer a maType member in  OOXMLPropertySet. I think this is fixed.
Can we close it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

--- Comment #7 from Miklos Vajna  ---
I think the only user of that name is the SW_DEBUG_WRITERFILTER=1 ./soffice.bin
foo.docx code which creates a /tmp/foo.docx.DOMAINMAPPER.xml file; and sure,
having the type info there manually is probably pointless. Please just test
this writerfilter XML token dump when you do changes in the tokenizer (see if
you break it), as that debug code has no testcase coverage.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

--- Comment #6 from Michael Meeks  ---
Interesting; this task got simpler, and the class got renamed:

class OOXMLPropertySet : public writerfilter::Reference
...

Can we remove the maType member ? which is now an OUString (for no apparent
reason) and gets intialized and deleted along with that class for no benefit at
all (that I can see ;-). But needs some code-reading.

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

--- Comment #5 from Ekansh Jha  ---
Hi! I would like to work on this issue. I have found some
"writerfilter::Reference" but couldn't find anything sort of
"OOXMLPropertySetImpl::OOXMLPropertySetImpl()
". 
>It'd be nice to have this compiled out of the relevant writerfilter::Reference
>etc. vtables and/or removed completely.

Could you please brief about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

Robinson Tryon (qubit)  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp,
   ||topicCleanup

--- Comment #3 from Robinson Tryon (qubit)  ---
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp,
topicCleanup)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80798

Robinson Tryon (qubit)  changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |
   |SkillCpp TopicCleanup   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=80798

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #2 from Björn Michaelsen bjoern.michael...@canonical.com ---
adding LibreOffice developer list as CC to unresolved Writer EasyHacks for
better visibility.

see e.g.
http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for
details

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80798] cleanup debug methods

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=80798

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

Summary|simple re-factor for|cleanup debug methods
   |speed-up ...|

--- Comment #1 from Michael Meeks michael.me...@collabora.com ---
I've pushed the speedup part; so dropping that from the title for now - even
though not doing this OUString thrash would save quite some time really.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs