[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard||target:4.4.0

--- Comment #13 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dffe40bc4e8be7c845d66a8118248d02dd70a707

Related: fdo#83572 Improve zoom mode



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #14 from Maxim Monastirsky momonas...@gmail.com ---
So I moved the zoom mode to a dedicated button, and made it permanent (until
the user press escape or click the selection tool). Also added zoom out (by
holding Ctrl), and pan (by holding Shift). I didn't use space for pan, because
it isn't a modifier key, so I wasn't sure how to implement this. Also the
pressed/unpressed stuff isn't fixed - I had a lot of headache with this, so
left this out by now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

Maxim Monastirsky momonas...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

--- Comment #15 from Maxim Monastirsky momonas...@gmail.com ---
Reopening because a feedback is needed on this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #12 from Jay Philips philip...@hotmail.com ---
(In reply to comment #11)
 (In reply to comment #10)
  I just tried double-clicking on zoom in button and when doing so, it does
  have a pressed in state
 Good catch.

In addition to it not working while double-pressed, i wasnt able to unpress its
state as well. :)

  So what say we change this bug to an enhancement request for the replacement
  of the group button with a single zoom/pan mode button
 If we decide to retain some zoom related button on the toolbar, there is no
 need to remove the group button, it's possible to simply set some command as
 the default for that button, similar to the custom shapes buttons. But I'm
 not sure if we can combine both zoom and pan in one button, since the zoom
 mode allows you to select a specific area to zoom by dragging, so this
 conflicts with panning.

Well i was suggesting this according to how gimp and photoshop do it with the
zoom tool. In gimp when zoom mode is active, left click or left click drag
zooms in, ctrl + left click zooms out, and space bar + mouse movement does pan.
In photoshop, left click or left click drag zooms in, alt + left click zooms
out, and space bar + left click mouse movement does pan. I think this type of
zoom mode would be really beneficial in Draw.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #11 from Maxim Monastirsky momonas...@gmail.com ---
(In reply to comment #10)
 I just tried double-clicking on zoom in button and when doing so, it does
 have a pressed in state
Good catch.

 So what say we change this bug to an enhancement request for the replacement
 of the group button with a single zoom/pan mode button
If we decide to retain some zoom related button on the toolbar, there is no
need to remove the group button, it's possible to simply set some command as
the default for that button, similar to the custom shapes buttons. But I'm not
sure if we can combine both zoom and pan in one button, since the zoom mode
allows you to select a specific area to zoom by dragging, so this conflicts
with panning.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #7 from Maxim Monastirsky momonas...@gmail.com ---
(In reply to comment #6)
 I think most people would be confused/unaware with the single/double
 clicking of a zoom mode button. As it is a mode, the mode should be
 functional until the mode is turned off.
Yes it might be a bit confusing. There is even a proposal in Bug 39268 to get
rid of those single/double click differences completely.

 Any ideas why it was removed and in which commit?
I gave a link to that commit.

 The only functionality
 that i see missing from the statusbar and scrollbars is the zoom in mode,
 but its not that difficult to zoom into a particular area with the a
 combination of shift + scrollwheel (pan left/right), scrollwheel (pan
 up/down) and ctrl + scrollwheel (zoom in/out).
Thinking of it again, you probably right. It's not worth keeping this button
visible by default.

 Unfortunately i cant find that tooltip. :(
You must enable extended tooltips at Tools-Options...-LibreOffice-General.
Anyway you don't need the tooltip, as you can judge from its behavior - it
always zoom by 200% of the current zoom. (Just a speculation - maybe those 200%
are the reason it was made to work in one use way, because when you zoom 200%
each time, it turns too much zoomed very quickly.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #8 from Jay Philips philip...@hotmail.com ---
(In reply to comment #7)
 Yes it might be a bit confusing. There is even a proposal in Bug 39268 to
 get rid of those single/double click differences completely.

I think the behaviour for some buttons like format painter are fine, but think
it would be confusing for a zoom mode, just as it is silly to have to click the
shift button each time i've finished a shift, as most people pan multiple
times.

  Any ideas why it was removed and in which commit?
 I gave a link to that commit.

Was looking for the commit where it was removed. :)

 Thinking of it again, you probably right. It's not worth keeping this button
 visible by default.

Yep it isnt worth having it visible by default as more useful buttons should be
placed in the toolbar, which are easily understandable. I was going over the
stats from OOo on the button usage and here are where all the clicks are going.

.uno:ZoomPlus38.27%
.uno:ZoomMinus21.21%
.uno:Zoom100Percent14.96%
.uno:ZoomPage11.13%
.uno:ZoomPageWidth 7.76%
.uno:ZoomOptimal 3.99%
.uno:ZoomObjects 0.96%
.uno:ZoomPanning 1.71%

Its hard to judge .uno:ZoomPlus's click ratio, as i'd assume many users would
be mistakenly click it multiple times thinking that it does zoom in (me
included :D). What makes it quite confusing also is that the icon and tooltip
are the same as in writer's page preview mode, but they have different
behaviours.


 You must enable extended tooltips at
 Tools-Options...-LibreOffice-General. Anyway you don't need the tooltip,
 as you can judge from its behavior - it always zoom by 200% of the current
 zoom. (Just a speculation - maybe those 200% are the reason it was made to
 work in one use way, because when you zoom 200% each time, it turns too much
 zoomed very quickly.)

Thanks for the info, though i enabled it and it still didnt appear. Maybe i
need to restart LibO. I think the behaviour of zoom out to decrease by half is
way to much.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #9 from Maxim Monastirsky momonas...@gmail.com ---
(In reply to comment #8)
 Was looking for the commit where it was removed. :)
This one -
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b4558b508141af16d335f45a0f12bdd34521e944
?

 Thanks for the info, though i enabled it and it still didnt appear.
I think it depens on the offline help pack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #10 from Jay Philips philip...@hotmail.com ---
(In reply to comment #9)
 This one -
 http://cgit.freedesktop.org/libreoffice/core/commit/
 ?id=b4558b508141af16d335f45a0f12bdd34521e944 ?

Thanks. I thought it might be Samuel who removed it. :)

 I think it depens on the offline help pack.

Yep i dont have that. :)

I just tried double-clicking on zoom in button and when doing so, it does have
a pressed in state, but unfortunately it doesnt stay active after a single
click. :D

So what say we change this bug to an enhancement request for the replacement of
the group button with a single zoom/pan mode button, which can be disable by
pressing the button again, pressing Esc and a context menu option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

Maxim Monastirsky momonas...@gmail.com changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #1 from Maxim Monastirsky momonas...@gmail.com ---
Actually it does work, but not in the way you expect. It enters into zoom
mode, so you able to choose which area you want to zoom. If you'll hover the
pointer over the slide, you'll see it changed into a magnifying glass. The only
bug I see here is that the button doesn't change into pressed state, so a
user has no way to know he's entered into this zoom mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #2 from Jay Philips philip...@hotmail.com ---
Yes i see what you mean about zoom in mode, but think it should act similar to
all the rest of the buttons in the drop down.

If a real zoom mode button is needed, it should be its own dedicated button and
should stay active until a user changes from the zoom mode, so i could zoom in
(left click or left click drag) and zoom out (shift + left click or right
click) without the need to re-enable zoom mode each time. You can find this
zoom behaviour in most photo editors and document viewers.

As the button is removed in 4.4, this isnt a big deal and the zoom facility is
already in the statusbar. So if you want to close this, its fine by me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

Maxim Monastirsky momonas...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Maxim Monastirsky momonas...@gmail.com ---
(In reply to comment #2)
 but think it should act similar
 to all the rest of the buttons in the drop down.
Note that the last button (named Shift) also acts in a similar way. But it's
indeed very odd that the zoom in button acts differently than the zoom out one.

 If a real zoom mode button is needed, it should be its own dedicated button
 and should stay active until a user changes from the zoom mode, so i could
 zoom in (left click or left click drag) and zoom out (shift + left click or
 right click) without the need to re-enable zoom mode each time.
Agree. Also it could depend on single/double click as other tools in
Impress/Draw. (For example - if you click on a rectangle once, it allows you to
draw only one rectangle. But if you double-click, you can draw as many as you
want, until you click the Select tool or press escape.)

 As the button is removed in 4.4, this isnt a big deal
It was reverted in
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae218332b13a82e13f1a9a9f0fb79ef76a51ce39,
so by now it's there. (And since it provides functionality that is not present
on status bar, I wonder whether it's good idea to remove it.)

 So if you want to close this, its fine by me.
Why close? If it could be improved, it should be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #4 from Maxim Monastirsky momonas...@gmail.com ---
(In reply to comment #3)
 (And
 since it provides functionality that is not present on status bar, I wonder
 whether it's good idea to remove it.)
Also note that the extended tooltip says Displays the slide at two times its
current size, so it's a quick way to get 200% of the current zoom, which is
not easily possible using the status bar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

Maxim Monastirsky momonas...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Maxim Monastirsky momonas...@gmail.com ---
...and turns out it was already reported earlier in Bug 55903.

*** This bug has been marked as a duplicate of bug 55903 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83572] Increase zoom button in toolbar doesnt work

2014-09-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83572

--- Comment #6 from Jay Philips philip...@hotmail.com ---
(In reply to comment #3)
 Note that the last button (named Shift) also acts in a similar way. But
 it's indeed very odd that the zoom in button acts differently than the zoom
 out one.

Yes i just saw the shift works in the same one use way, which is quite silly. I
was going to suggest a shift type option with the one button zoom mode type
button. I normally use zoom and pan quite a bit in gimp and photoshop. :)

 Agree. Also it could depend on single/double click as other tools in
 Impress/Draw. (For example - if you click on a rectangle once, it allows you
 to draw only one rectangle. But if you double-click, you can draw as many as
 you want, until you click the Select tool or press escape.)

I think most people would be confused/unaware with the single/double clicking
of a zoom mode button. As it is a mode, the mode should be functional until the
mode is turned off.

 It was reverted in
 http://cgit.freedesktop.org/libreoffice/core/commit/
 ?id=ae218332b13a82e13f1a9a9f0fb79ef76a51ce39, so by now it's there. (And
 since it provides functionality that is not present on status bar, I wonder
 whether it's good idea to remove it.)

Any ideas why it was removed and in which commit? Yep i'm running 2014-09-02,
as i wait for a new build on @45-TDF. The only functionality that i see missing
from the statusbar and scrollbars is the zoom in mode, but its not that
difficult to zoom into a particular area with the a combination of shift +
scrollwheel (pan left/right), scrollwheel (pan up/down) and ctrl + scrollwheel
(zoom in/out).

 Why close? If it could be improved, it should be done.

Well i wasnt that keen on improving it thinking that it was being removed in
4.4. :)

(In reply to comment #4)
 Also note that the extended tooltip says Displays the slide at two times
 its current size, so it's a quick way to get 200% of the current zoom,
 which is not easily possible using the status bar.

Unfortunately i cant find that tooltip. :(

(In reply to comment #5)
 ...and turns out it was already reported earlier in Bug 55903.

Well from this discussion, i would have likely change this bug to 'replacing
zoom group button with zoom/pan mode button', which wouldnt be a duplicate. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs