[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #12 from Michael Meeks --- Unfortunately as you say the patch rather significantly breaks indentation all across the file - not just on whitespace lines (did you read the diff) ? =) So - you need to do: 'git stash' (which will save t

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #17 from Michael Meeks --- Pushed; as a next step - it'd be great to start pushing to gerrit if you can get that setup - it's much easier to review / merge from there =) Thanks ! -- You are receiving this mail because: You are the

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #16 from Vinicius Vendramini --- Created attachment 108249 --> https://bugs.freedesktop.org/attachment.cgi?id=108249&action=edit Removed extra newlines between functions. And here's the last patch, removing extra newlines betwe

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Vinicius Vendramini changed: What|Removed |Added Attachment #108142|0 |1 is obsolete|

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Michael Meeks changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #13 from Vinicius Vendramini --- Created attachment 108229 --> https://bugs.freedesktop.org/attachment.cgi?id=108229&action=edit Removed the comments without changing the indentation Ok, let's try this again =) This time I used mo

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #11 from Vinicius Vendramini --- Created attachment 108142 --> https://bugs.freedesktop.org/attachment.cgi?id=108142&action=edit Cleaned up the first comments on the files. I cleaned up the first type of comments and tried to creat

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #10 from Michael Meeks --- Just do: git diff > /tmp/changes.diff and attach that file. For a more advanced version do: git commit -a enter a commit message git format-patch -1 And please try to do only -one- kind of cleanup in ea

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #9 from Vinicius Vendramini --- Ok, I'll leave the vim comments alone :) I suppose the emacs comments are these guys: /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ So I'll just leave them alone too.

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #8 from Michael Meeks --- Thanks =) Please make sure you separate concerns; ie. just remove one class of silly types of commits in each commit [ are you setup with gerrit eg. - if not just attach a patch here ]. This guy: /* vim:set

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #7 from Vinicius Vendramini --- There are also a few blocks like this: /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ I'm removing those too. -- You are receiving this mail because: You are the assignee for the bug. _

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #6 from Vinicius Vendramini --- Oh, now I get it. It's a folder and there's a bunch of weird files in there. I'll take care of them, and then look for similar comments in other places. Cheers! -- You are receiving this mail because

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #5 from Vinicius Vendramini --- Ok... I'm gonna take a look at this file, try to find some patterns in these comments and look for them in other files. Sounds ok? =D Off I go. -- You are receiving this mail because: You are the assi

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Michael Meeks changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Michael Meeks -

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #3 from Vinicius Vendramini --- Oops, sorry, accidental double post. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #2 from Vinicius Vendramini --- Hi, I'd like to try this out as my first contribution to the project, but I have a few simple questions: is this file the only one that needs changing, or have you found more comments like these on oth

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Vinicius Vendramini changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Vinic

[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...

2014-09-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Michael Meeks changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard|