[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #12 from Michael Meeks michael.me...@collabora.com --- Unfortunately as you say the patch rather significantly breaks indentation all across the file - not just on whitespace lines (did you read the diff) ? =) So - you need to do: 'git stash' (which will save that) and start again I think - using a better editor, or perhaps a perl/sed script to help =) Sorry - but thanks for trying looking forward to success here ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #17 from Michael Meeks michael.me...@collabora.com --- Pushed; as a next step - it'd be great to start pushing to gerrit if you can get that setup - it's much easier to review / merge from there =) Thanks ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #13 from Vinicius Vendramini viniven...@gmail.com --- Created attachment 108229 -- https://bugs.freedesktop.org/attachment.cgi?id=108229action=edit Removed the comments without changing the indentation Ok, let's try this again =) This time I used mostly perl and vim, so no indentation should have been affected. I double checked it, so I really hope there's nothing wrong this time... I'm gonna upload two other patches next, one removing the comments at the end of the files and one fixing the whitespace between functions, as requested =D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #14 from Michael Meeks michael.me...@collabora.com --- Lovely - thanks for that :-) pushed to master. Please check that you've sent a license confirmation to the developers mailing list cf. https://wiki.documentfoundation.org/Development/Developers Thanks ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Vinicius Vendramini viniven...@gmail.com changed: What|Removed |Added Attachment #108142|0 |1 is obsolete|| --- Comment #15 from Vinicius Vendramini viniven...@gmail.com --- Created attachment 108237 -- https://bugs.freedesktop.org/attachment.cgi?id=108237action=edit Removed the comments at the end of some files Ok, great! I've sent an email to the devs with the statement from that page. Here's the second patch, removing the comments from the end of the files; last one should be coming right up =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #16 from Vinicius Vendramini viniven...@gmail.com --- Created attachment 108249 -- https://bugs.freedesktop.org/attachment.cgi?id=108249action=edit Removed extra newlines between functions. And here's the last patch, removing extra newlines between functions to improve readability :D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #11 from Vinicius Vendramini viniven...@gmail.com --- Created attachment 108142 -- https://bugs.freedesktop.org/attachment.cgi?id=108142action=edit Cleaned up the first comments on the files. I cleaned up the first type of comments and tried to create a patch, but that didn't quite work out so this is the diff file (git diff changes.diff). I think my IDE accidentaly changed some of the indentation (mostly in whitespace-only lines), so sorry about that =P. I can recreate the changes in vim if needed (to avoid this problem), but it might take some time. If this is ok, I'll post the second part soon (cleaning up the other comments) =D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #9 from Vinicius Vendramini viniven...@gmail.com --- Ok, I'll leave the vim comments alone :) I suppose the emacs comments are these guys: /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ So I'll just leave them alone too. I'm not set up with garret, so I'll attach a patch when I'm done. Should I just attach a zip or tar with the changed files or is there any standard procedure for this? Thanks for all the help =D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #10 from Michael Meeks michael.me...@collabora.com --- Just do: git diff /tmp/changes.diff and attach that file. For a more advanced version do: git commit -a enter a commit message git format-patch -1 And please try to do only -one- kind of cleanup in each commit - so we can review them, improve, revert, edit each separately. Thanks =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #5 from Vinicius Vendramini viniven...@gmail.com --- Ok... I'm gonna take a look at this file, try to find some patterns in these comments and look for them in other files. Sounds ok? =D Off I go. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #6 from Vinicius Vendramini viniven...@gmail.com --- Oh, now I get it. It's a folder and there's a bunch of weird files in there. I'll take care of them, and then look for similar comments in other places. Cheers! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #7 from Vinicius Vendramini viniven...@gmail.com --- There are also a few blocks like this: /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ I'm removing those too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #8 from Michael Meeks michael.me...@collabora.com --- Thanks =) Please make sure you separate concerns; ie. just remove one class of silly types of commits in each commit [ are you setup with gerrit eg. - if not just attach a patch here ]. This guy: /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ is vitally important for vim users, and we have an emacs version at the head of each file that's intended - so I'd leave those alone ;-) Looking forward to your patch. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Vinicius Vendramini viniven...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Vinicius Vendramini viniven...@gmail.com --- Hi, I'd like to try this out as my first contribution to the project, but I have a few simple questions: is this file the only one that needs changing, or have you found more comments like these on other files? Should I look for other files? Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #2 from Vinicius Vendramini viniven...@gmail.com --- Hi, I'd like to try this out as my first contribution to the project, but I have a few simple questions: is this file the only one that needs changing, or have you found more comments like these on other files? Should I look for other files? Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 --- Comment #3 from Vinicius Vendramini viniven...@gmail.com --- Oops, sorry, accidental double post. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Michael Meeks michael.me...@collabora.com --- Can you think of a simple way that would help you answer your own question ? =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83991] remove bogus folding comments...
https://bugs.freedesktop.org/show_bug.cgi?id=83991 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard||EasyHack DifficultyBeginner ||SkillCpp TopicCleanup Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
