[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #23 from Justin L  ---
Documented API CHANGE in 7.6 release notes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #22 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/70d9e7eadb1069b5e7a1909c671b9348b740cca1

tdf#85592 android: .uno:BackColor deprecated, use .uno:CharBackColor

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #21 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/be3d34b5d6b97c3eb12ab3f84ce2da2ef965a928

[API CHANGE] tdf#85592: deprecate .uno:BackColor, use .uno:CharBackColor

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #20 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ba8eb90925aa31be4029b5486a6f5dcd2e9573fd

[API CHANGE] related tdf#85592: drop duplicate use of .uno:CharBackgroundExt

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0 target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #19 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e93b7f6a5c5f9ee86546d95d7fe70ecc26b71b91

NFC related tdf#85592: simplify SID_ATTR_CHAR_COLOR_BACKGROUND_EXT

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #18 from Justin L  ---
Exploratory proposal at http://gerrit.libreoffice.org/c/core/+/137334

(In reply to Justin L from comment #15)
> Nothing "fixed" the toolbar disabling when in a comment/textbox. HELP!
The key to this is defining CharBackColor in the .sdi files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #17 from Justin L  ---
(In reply to Justin L from comment #15)
> .uno:BackColor is enabled with body text. It is associated with SvxBrushItem
> and SID_ATTR_BRUSH_CHAR.
That's not 100% accurate either. From sw/sdi/swriter.sdi:

SvxColorItem BackColor SID_ATTR_CHAR_COLOR_BACKGROUND

but in the code this is typically changed to SvxBrushItem and associated with
Writer's RES_CHRATR_BACKGROUND. 

> .uno:CharBackColor is enabled with comments / textboxes / draw-stuff and
> associated with SvxColorItem and SID_ATTR_CHAR_BACK_COLOR.
SvxColorItem CharBackColor SID_ATTR_CHAR_BACK_COLOR

which in the code is keep as a ColorItem and pretty much is exclusively
associated with editeng's EE_CHAR_BKGCOLOR.


In sw UNO, PROP_NAME_CHAR_BACK_COLOR maps to RES_CHRATR_BACKGROUND.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #16 from Telesto  ---
(In reply to Justin L from comment #15)
Just to rule something out: The comment box is capable of rendering Character
Highlighting. Inspired by bug 93789

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #15 from Justin L  ---
(In reply to Justin L from comment #14)
> There are two Character Highlighting Color objects: .uno:BackColor (works
> with comments) and .uno:CharBackColor (works with body text).
I got this completely backwards:
.uno:BackColor is enabled with body text. It is associated with SvxBrushItem
and SID_ATTR_BRUSH_CHAR.
.uno:CharBackColor is enabled with comments / textboxes / draw-stuff and
associated with SvxColorItem and SID_ATTR_CHAR_BACK_COLOR.

I changed EVERY reference of .uno:CharBackColor to .uno:BackColor and that
STILL did not "fix" the toolbar disabling when in a comment/textbox. HELP!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #14 from Justin L  ---
The sidebar is basically being replaced by a different set of options when
switching to comments. (Some paragraph stuff disappears, and the Character
Highlighting Color visibly changes position when moving between body text and
comment.)

Comments also disable other paragraph items like numbering on the toolbar.
There are two Character Highlighting Color objects: .uno:BackColor (works with
comments) and .uno:CharBackColor (works with body text). Likely there is no
(easy) solution for the disabled toolbar button.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Justin L  changed:

   What|Removed |Added

 OS|Windows (All)   |All
Version|4.2.6.3 release |unspecified
 CC||jl...@mail.com
   Hardware|Other   |All

--- Comment #13 from Justin L  ---
Hmm - I wonder how it is being disabled. It is NOT via rSet.disableItem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #12 from Telesto  ---
(In reply to Lucas from comment #11)
> Chill, man, I'm not attached. We're in this together :)
> Hope the bug can be fixed!
I have nicely asked developer team called NISZ. The do quite some nice work on
DOCX lately.. it should be pretty simple/ quick to solve... with the right
expertise.. we will see. I'm adding you to the CC list of the new created bug..
This way you will be informed if things are moving..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #11 from Lucas  ---
(In reply to Telesto from comment #10)
> (In reply to Lucas from comment #9)
> I might have misunderstood.
> 
> I read you're bug as : highlight color is disabled in toolbar and enabled in
> sidebar. If you where talking about DOCX/DOC import (and export) then you're
> right. It doesn't function. Kind of created bug 139759 for that.. but if
> you're attached having you're own report.. I'm happy to revive that one

Chill, man, I'm not attached. We're in this together :)

Hope the bug can be fixed!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #10 from Telesto  ---
(In reply to Lucas from comment #9)
I might have misunderstood.

I read you're bug as : highlight color is disabled in toolbar and enabled in
sidebar. If you where talking about DOCX/DOC import (and export) then you're
right. It doesn't function. Kind of created bug 139759 for that.. but if you're
attached having you're own report.. I'm happy to revive that one

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #9 from lucas...@gmail.com ---
(In reply to Telesto from comment #8)
> Not totally getting what the hold-up here is..
> menu/format/character does work. 
> 
> Makes sense to add character to the right click context menu of a comment,
> IMHO.
> And working toolbar button might help too..
> 
> 
> Biggest issue is DOCX ex and/or importer not handling highlighting inside
> comment box.. So it will vanish. Obviously not great either.. but no reason
> for the current state, IMHO.

I tested it on my version of Writer now (7.0.4.2 x64), and the bug remains.

Like others said, font color in the toolbar work; highlight color is disabled
in toolbar and enabled in sidebar.

Really the function of importing the highlighted comments from DOCX is not
working, I tested it here too.

What did you mean by it will vanish?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||9759

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #8 from Telesto  ---
Not totally getting what the hold-up here is..
menu/format/character does work. 

Makes sense to add character to the right click context menu of a comment,
IMHO.
And working toolbar button might help too..


Biggest issue is DOCX ex and/or importer not handling highlighting inside
comment box.. So it will vanish. Obviously not great either.. but no reason for
the current state, IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Telesto  changed:

   What|Removed |Added

 CC||lucas...@gmail.com

--- Comment #7 from Telesto  ---
*** Bug 139748 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #6 from QA Administrators  ---
Dear peter josvai,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

--- Comment #5 from Regina Henschel  ---
Comments are  elements. Allowed content is  and
 and the meta data ,  and . So
from file format there would be no problem to use all styling that are possible
for lists and paragraphs.
Comments are handled as callout shapes internally (AFAIK), so all restrictions
known for them (e.g. bug 96706) hold here too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Heiko Tietze  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de,
   ||tietze.he...@gmail.com

--- Comment #4 from Heiko Tietze  ---
I wonder if font attributes are allowed in comments. Regina?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85592] Font and highlight colour toolbar buttons dont work in comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85592

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||momonas...@gmail.com
Summary|[Editing comments]: Font|Font and highlight colour
   |Colour and Highlight Colour |toolbar buttons dont work
   |are not available in the|in comments
   |toolbar, but only in the|
   |sidebar |

--- Comment #3 from Yousuf Philips (jay)  ---
Tested 6.0 and font color in the toolbar does work. Highlight color is disabled
in toolbar and enabled in sidebar, so its likely using a different uno command.
Maxim: thoughts?

Version: 6.0.0.0.alpha1+
Build ID: 43d6b11a5c1dda0cc2c1e06c768eece25051a56c
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs