[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #24 from Timur  ---
Not easy to reproduce but I did per Comment 4, crash in 5.2 and formatting lost
in 5.5.+. So, if crash was fixed, styles was not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #23 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=91646b10315e2ee64b25fb8a604012c729343c07

tdf#88555 sw: use safe IsAlive function in Undo code

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #22 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d31f114327e77c48c8cdc804e1e399ebeadd27c

tdf#88555 sw: reduce usage of dynamic_cast in SwFormatsModifyBase::Contains

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #21 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=01575a06725648188d51de90323a6f1da97ef7a9

tdf#88555 sw: remove dynamic_cast from SwFrameFormats::Contains

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #20 from Commit Notification 
 ---
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-5-3-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d866bb51927b8b75718438a63138834bb7ea2f6c=libreoffice-5-3-3

tdf#88555: band-aid fix, using GetPos/find instead of Contains

It will be available in 5.3.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0 target:5.3.4   |target:5.4.0 target:5.3.4
   ||target:5.3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #19 from Commit Notification 
 ---
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e7068a7d9b945e0c6d4965445b6d951038e9c987=libreoffice-5-3

tdf#88555: band-aid fix, using GetPos/find instead of Contains

It will be available in 5.3.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #18 from Michael Stahl  ---
regarding the crash, it is because commit
0f98299f7aa44bbb55c1bfeddca7799f727d14b0 inserted a dynamic_cast in the
Contains function.

Undo of the style creation deletes the SwFormat:

#0  0x7f08164adf1b in SwFormat::~SwFormat() (this=0x3d63770,
__in_chrg=) at
/work/lo/libreoffice-5-3/sw/source/core/attr/format.cxx:214
#1  0x7f0816614874 in SwFormatColl::~SwFormatColl() (this=0x3d63770,
__in_chrg=) at /work/lo/libreoffice-5-3/sw/inc/fmtcol.hxx:33
#2  0x7f0816746f16 in SwTextFormatColl::~SwTextFormatColl()
(this=0x3d63770, __in_chrg=) at
/work/lo/libreoffice-5-3/sw/inc/fmtcol.hxx:54
#3  0x7f0816746f32 in SwTextFormatColl::~SwTextFormatColl()
(this=0x3d63770, __in_chrg=) at
/work/lo/libreoffice-5-3/sw/inc/fmtcol.hxx:54
#4  0x7f081660e8f5 in SwDoc::DelTextFormatColl(unsigned long, bool)
(this=0x36cb7e0, nFormatColl=7, bBroadcast=true) at
/work/lo/libreoffice-5-3/sw/source/core/doc/docfmt.cxx:991
#5  0x7f081660ea11 in SwDoc::DelTextFormatColl(SwTextFormatColl*, bool)
(this=0x36cb7e0, pColl=0x3d63770, bBroadcast=true) at
/work/lo/libreoffice-5-3/sw/source/core/doc/docfmt.cxx:999
#6  0x7f0816c98836 in SwUndoTextFormatCollCreate::Delete() (this=0x3d4f130)
at /work/lo/libreoffice-5-3/sw/source/core/undo/SwUndoFmt.cxx:206
#7  0x7f0816c97f77 in SwUndoFormatCreate::UndoImpl(sw::UndoRedoContext&)
(this=0x3d4f130) at
/work/lo/libreoffice-5-3/sw/source/core/undo/SwUndoFmt.cxx:63

the call to SwFormatsModifyBase::Contains effectively wants to check if
the SwFormat has been deleted; i think every SwFormat is in some SwDoc
member array for as long as it is alive.

of course with the dynamic_cast in Contains, the check if it's
still alive turns into use-after-free crash.

the patch in commit #17 should fix this crash but every other
call to Contains probably either crashes or is pointless because
it will always return true.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Michael Stahl  changed:

   What|Removed |Added

 Attachment #131532|text/x-log  |text/plain
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #17 from Commit Notification 
 ---
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1df637bde32c484b681ecdfebf56fdca03db7fc1

tdf#88555: band-aid fix, using GetPos/find instead of Contains

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Phil Krylov  changed:

   What|Removed |Added

 Blocks||100371


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100371
[Bug 100371] [META] Improve Undo handling
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #16 from Xisco Faulí  ---
(In reply to Katarina Behrens (CIB) from comment #14)
> Okay guys, I can make the crash go away, but I can't fix non-functional
> redo. I lack deeper knowledge of Writer to actually do that ... shall I do
> at least that?

IMHO, we should make the crash go away despite of the fact the functionally
doesn't work. Better to have a functionally not working than a crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||783

--- Comment #15 from Timur  ---
Makes sense if crash is your regression from 5.0 and redo is some older problem
from 4.4, like Bug 93045.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #14 from Katarina Behrens (CIB)  ---
Okay guys, I can make the crash go away, but I can't fix non-functional redo. I
lack deeper knowledge of Writer to actually do that ... shall I do at least
that?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
   Priority|medium  |highest
 CC||katarina.behr...@cib.de
   Severity|major   |critical

--- Comment #13 from Xisco Faulí  ---
Crash introduced by:

author  Katarina Behrens   2015-05-03 21:25:52
(GMT)
committer   Katarina Behrens   2015-05-03
21:31:53 (GMT)
commit  98436c4b53639d86f261ac630c46d32e3c7b8e28 (patch)
treebe3be3fb1cdd44ad92c8a171ef72e00a96815be2
parent  bc9d02b0ca6244b46c9e2c59b7cc3618eb0f0148 (diff)
tdf#89783: Adjust to new GetPos retval (size_t vs. sal_uInt16)
Some of the usages of GetPos were just misusing it to find out
whether a vector contains given element -- use Contains() in those
cases

This patch is partially based on work of Christoph Lutz

Adding Cc: to Katarina Behrens

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #12 from Xisco Faulí  ---
Created attachment 131532
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131532=edit
gdb backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #11 from Xisco Faulí  ---
Still reproducible in

Version: 5.4.0.0.alpha0+
Build ID: eb7b03b052ffe8c2c577b2349987653db6c53f76
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-02-26_22:34:18
Locale: es-ES (es_ES); Calc: group

and

Version: 5.4.0.0.alpha0+
Build ID: bd8c68c99cce51a3368d8ddfd6e11dccb72d8f49
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Timur  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #10 from Timur  ---
Created attachment 127434
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127434=edit
backtrace master 5.3 from Windbg.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Timur  changed:

   What|Removed |Added

 CC||gti...@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||045

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

--- Comment #9 from Phil Krylov  ---
Crash backtrace:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0007a0008030
0x7fff85e4bb22 in __dynamic_cast ()
(gdb) bt
#0  0x7fff85e4bb22 in __dynamic_cast ()
#1  0x0001157518a3 in SwUndoFormatAttr::IsFormatInDoc ()
#2  0x0001157516c7 in SwUndoFormatAttr::UndoImpl ()
#3  0x00011575e2a6 in SwUndo::RedoWithContext ()
#4  0x000101349915 in SfxUndoManager::ImplRedo ()
#5  0x00011574af9a in sw::UndoManager::impl_DoUndoRedo ()
#6  0x00011574b17e in sw::UndoManager::Redo ()
#7  0x00011553a47c in SwEditShell::Redo ()
#8  0x000115c2f94e in SwWrtShell::Do ()
#9  0x000115b05e39 in SwBaseShell::ExecUndo ()
#10 0x000100d12408 in SfxDispatcher::Call_Impl ()
#11 0x000100d0d39c in SfxBindings::Execute_Impl ()
#12 0x000100d457fc in SfxDispatchController_Impl::dispatch ()
#13 0x000100d43f27 in SfxOfficeDispatch::dispatch ()
#14 0x000101f8e4a2 in svt::ToolboxController::execute ()
#15 0x000100f0a8e6 in SfxToolBoxControl::execute ()
#16 0x000111ebcd6e in framework::ToolBarManager::Select ()
#17 0x000102a8485e in ToolBox::Select ()
#18 0x000102a93622 in ToolBox::ImplHandleMouseButtonUp ()
#19 0x000102a94ad3 in ToolBox::Tracking ()
#20 0x000102a9ba54 in vcl::Window::EndTracking ()
#21 0x000102ab16aa in ImplHandleMouseEvent ()
#22 0x000102ab3397 in ImplWindowFrameProc ()
#23 0x000102d7ef84 in -[SalFrameView
sendMouseEventToFrame:button:eventtype:] ()
#24 0x7fff8d392145 in -[NSWindow sendEvent:] ()
#25 0x7fff8d3335d4 in -[NSApplication sendEvent:] ()
#26 0x000102d758c7 in -[VCL_NSApplication sendEvent:] ()
#27 0x000102d411b6 in AquaSalInstance::DoYield ()
#28 0x000102cce29e in Application::Yield ()
#29 0x000102cce238 in Application::Execute ()
#30 0x00010007c7a2 in desktop::Desktop::Main ()
#31 0x000102cd2472 in ImplSVMain ()
#32 0x000102d40be4 in AquaSalInstance::handleAppDefinedEvent ()
#33 0x000102d758a4 in -[VCL_NSApplication sendEvent:] ()
#34 0x7fff8d1839f9 in -[NSApplication run] ()
#35 0x7fff8d16e783 in NSApplicationMain ()
#36 0x000102d3fef9 in ImplSVMainHook ()
#37 0x000102cd309a in SVMain ()
#38 0x0001000a71b9 in soffice_main ()
#39 0x00010f20 in main ()

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88555] FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88555

Phil Krylov  changed:

   What|Removed |Added

Summary|FORMATTING: When undo and   |FORMATTING: When undo and
   |redo, custom styles and |redo, custom styles and
   |formatting lost.|formatting lost, or full
   ||crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs