[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 Muhammet Kara changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |muhammet.k...@pardus.org.tr |desktop.org | --- Comment #13 from Muhammet Kara --- Fixed on master (5.2.0) and backported to fresh (5.1.3.). I have also tested it on Win10 64 bit with a daily build. Seems OK. [0] http://cgit.freedesktop.org/libreoffice/core/commit/?id=97dee1df42dc2933d1350eb1e67361674614417a [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=95a8f1bb0ad7c040b2c96ef0a509dd74dfe16fd7&h=libreoffice-5-1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 --- Comment #12 from Commit Notification --- Muhammet Kara committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=95a8f1bb0ad7c040b2c96ef0a509dd74dfe16fd7&h=libreoffice-5-1 tdf#89609 Ignore subsecond precision in iso8601_date_to_local_date It will be available in 5.1.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 Commit Notification changed: What|Removed |Added Whiteboard|target:5.2.0|target:5.2.0 target:5.1.3 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 --- Comment #11 from Commit Notification --- Muhammet Kara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=97dee1df42dc2933d1350eb1e67361674614417a WIP tdf#89609 Ignore subsecond precision in iso8601 It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 Commit Notification changed: What|Removed |Added Whiteboard||target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 --- Comment #10 from Muhammet Kara --- (In reply to Christian Lohmaier from comment #9) I have added an if block to check if the milliseconds part exists, and to remove if so. Please see it on gerrit: https://gerrit.libreoffice.org/24220 What do you think? Is it too complicated? The alternative would be something like just replacing "==" with ">=". -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 --- Comment #9 from Christian Lohmaier --- milliseconds and even seconds are irrelevant to the user (as this is for the tooltip in Windows explorer) The patch should ignore the milliseconds/produce the same result as on windows 7 or older: expected behavior: "23.02.2015 13:56" so the conversion function linked above should just ignore the fraction of seconds as it does now (it just sets milliseconds to 0) - but of course it must be changed to except that longer string as valid input. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 --- Comment #8 from Muhammet Kara --- What should we do here? * Ignore the milliseconds, and parse the inputted ISO date down to seconds? * Or check for existence of the milliseconds part, and also parse it? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 jan iversen changed: What|Removed |Added Whiteboard|ToBeReviewed| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 Muhammet Kara changed: What|Removed |Added CC||muhammet.k...@pardus.org.tr --- Comment #7 from Muhammet Kara --- I confirm the bug exists in LO 5.0.4.2 (x64) on Windows 10. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 jan iversen changed: What|Removed |Added Whiteboard||ToBeReviewed -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 pierre-yves samyn changed: What|Removed |Added CC||pierre-yves.samyn@laposte.n ||et --- Comment #4 from pierre-yves samyn --- Hi I do not reproduce on windows 7/64 & Version: 5.0.0.2.0+ (x64) Build ID: 18d6d789cae7cd684156dbd41d473892bc17392c Locale: fr-FR (fr_FR) Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89609] Explorer shell extension fails to convert date into locale specific string (sub-second precision ISO date → "strange date-information")
https://bugs.documentfoundation.org/show_bug.cgi?id=89609 Christian Lohmaier changed: What|Removed |Added CC||cl...@documentfoundation.or ||g, ||libreoffice@lists.freedeskt ||op.org Summary|strange date-information|Explorer shell extension |stored files Windows 8.1|fails to convert date into ||locale specific string ||(sub-second precision ISO ||date → "strange ||date-information") Whiteboard||EasyHack DifficultyBeginner ||SkillCpp --- Comment #3 from Christian Lohmaier --- Code that retrieves the date for the tooltip is in http://opengrok.libreoffice.org/xref/core/shell/source/win32/shlxthandler/infotips/infotips.cxx#258 where it gets the modified date and tries to convert it into a local representation by calling the corresponding helper function: msg += iso8601_date_to_local_date(meta_info_accessor.getTagData(META_INFO_MODIFIED )); However, iso8601_date_to_local_date as implemented here http://opengrok.libreoffice.org/xref/core/shell/source/win32/shlxthandler/util/iso8601_converter.cxx#iso8601_date_to_local_date doesn't expect sub-second precision date-string, but instead only expects 19 characters. As the passed date is longer, the function doesn't do anything and instead returns the ISO date as it was passed into. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
