[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #17 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- ritztro committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #18 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Eike Rathke committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-06-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 Eike Rathke er...@redhat.com changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #16 from David Tardon dtar...@redhat.com --- (In reply to Brent Ritzema from comment #15) I have submitted a patch to gerrit for this, however I will amend what I did to accommodate these new suggestions. I will use

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #15 from Brent Ritzema brentritztr...@gmail.com --- I have submitted a patch to gerrit for this, however I will amend what I did to accommodate these new suggestions. I will use CPPUNIT_ASSERT_MESSAGE instead. However I will be

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #14 from Markus Mohrhard markus.mohrh...@googlemail.com --- (In reply to David Tardon from comment #13) (In reply to Markus Mohrhard from comment #0) ucalc is one of the mail calc tests and is split between many files in

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 Tor Lillqvist t...@iki.fi changed: What|Removed |Added Assignee|tapanpraka...@gmail.com

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #11 from Brent Ritzema brentritztr...@gmail.com --- Okay thank you for the information. However, I am also a GSOC hopeful haha :). I have submitted a patch however I can submit another one that will use your suggestions. I just

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 Brent Ritzema brentritztr...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW --

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #12 from Tor Lillqvist t...@iki.fi --- Brent: The line number and file name in messages about failed unit tests come (in the examples in the initial comment) from where the CPPUNIT_FAIL macro is called. So if CPPUNIT_FAIL is

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-04-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 David Tardon dtar...@redhat.com changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-03-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 Tapan Prakash T tapanpraka...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-03-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 --- Comment #1 from Markus Mohrhard markus.mohrh...@googlemail.com --- And inside of the checkFormula implementation we should use CPPUNIT_ASSERT_EQUAL_MESSAGE which will print the expected and actual string in case of a failure. -- You

[Libreoffice-bugs] [Bug 90290] reduce some copypaste code in ucalc

2015-03-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90290 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added Status|UNCONFIRMED