[Libreoffice-bugs] [Bug 95489] Character styles applied through the Styles menu does not function in some locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95489

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |philip...@hotmail.com
   |desktop.org |

--- Comment #12 from Yousuf Philips (jay)  ---
Patch is in, but wont be able to be backported as it would trigger
retranslation.
https://gerrit.libreoffice.org/#/c/38655/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95489] Character styles applied through the Styles menu does not function in some locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95489

--- Comment #11 from Yousuf Philips (jay)  ---
(In reply to Maxim Monastirsky from comment #10)
> The Add commands dialog uses the right names. You can insert a toolbar
> button, and then look at the xml.

Roger.

> Currently bug 108301 seems like a mix of different issues with commands,
> labels etc. I don't mind if we reopen bugs, but each bug needs to be
> concentrated on a single issue.

Well Thomas created bug 108449 think that was the issue and you closed it, so
please create a new bug with the specific issue that needs to be addressed, as
you know best. :D

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95489] Character styles applied through the Styles menu does not function in some locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95489

--- Comment #10 from Maxim Monastirsky  ---
(In reply to Yousuf Philips (jay) from comment #9)
> So where can i find these internal names so i can correct all of them.
The Add commands dialog uses the right names. You can insert a toolbar button,
and then look at the xml.

> > wrt "Default Style" (comment 3 and Bug 108301 comment 0), Writer seems to
> > return the translatable name also when asking for the internal name. So we
> > need to change that, so it won't return it unless we explicitly ask for the
> > display name.
> 
> So i guess i should reopen bug 108301 for that issue right?
Currently bug 108301 seems like a mix of different issues with commands, labels
etc. I don't mind if we reopen bugs, but each bug needs to be concentrated on a
single issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95489] Character styles applied through the Styles menu does not function in some locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95489

--- Comment #9 from Yousuf Philips (jay)  ---
(In reply to Maxim Monastirsky from comment #8)
> Each built-in style has 2 names. One is "internal" non-localizable name, and
> another "display" name which can be translated (and some styles have also a
> third name, i.e. the label we give to style commands in *Commands.xcu). In
> order to work with all locales, the .uno:StyleApply command should get the
> internal name. So "Quotation" is the display name, and should be replaced
> with the internal name which is "Citation".

So where can i find these internal names so i can correct all of them.

> wrt "Default Style" (comment 3 and Bug 108301 comment 0), Writer seems to
> return the translatable name also when asking for the internal name. So we
> need to change that, so it won't return it unless we explicitly ask for the
> display name.

So i guess i should reopen bug 108301 for that issue right?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95489] Character styles applied through the Styles menu does not function in some locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95489

--- Comment #8 from Maxim Monastirsky  ---
(In reply to Yousuf Philips (jay) from comment #7)
> @Maxim: Your thoughts on this?
Each built-in style has 2 names. One is "internal" non-localizable name, and
another "display" name which can be translated (and some styles have also a
third name, i.e. the label we give to style commands in *Commands.xcu). In
order to work with all locales, the .uno:StyleApply command should get the
internal name. So "Quotation" is the display name, and should be replaced with
the internal name which is "Citation".

wrt "Default Style" (comment 3 and Bug 108301 comment 0), Writer seems to
return the translatable name also when asking for the internal name. So we need
to change that, so it won't return it unless we explicitly ask for the display
name.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95489] Character styles applied through the Styles menu does not function in some locales

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95489

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||momonas...@gmail.com,
   ||philip...@hotmail.com
 Blocks||108014, 91781
Summary|"Styles-Quotation" does not |Character styles applied
   |function|through the Styles menu
   ||does not function in some
   ||locales

--- Comment #7 from Yousuf Philips (jay)  ---
@Maxim: Your thoughts on this?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91781
[Bug 91781] [META] Reorganization of the menu bar for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=108014
[Bug 108014] [META] Writer character style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs