[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #15 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d3fe0bce57633c9540c58ee05314e15ff51e2b8=libreoffice-5-1

tdf#97374: prevent crash while updating SvxPageTitleField

It will be available in 5.1.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0 target:5.1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Rosemary Sebastian  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #13 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=90dfa7cbcaf32aab6005b94b393c7c409ff1af8f

tdf#97374: prevent crash while updating SvxPageTitleField

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #14 from Rosemary Sebastian  ---
(In reply to Oliver Specht from comment #12)
> The only way for me to crash was to open a Writer document before which
> makes SfxViewShell::Current() return a Writer view shell which ends in an
> access to a (SdDrawDocument* pDoc == nullptr
> 
> Prio to 
> commit 2970ec843820a72d73a91cc11fc353e5b9fde5fd
> Author: Noel Grandin 
> Date:   Sun Jul 12 21:13:57 2015 +0200
> 
> editeng: make Link<> usage typed
> 
> Change-Id: Iec36c7e4f4fbc2ee2ee25d4d0c8488340ba7d8c4
> Reviewed-on: https://gerrit.libreoffice.org/16968
> Tested-by: Jenkins 
> Reviewed-by: Noel Grandin 
> The crashing line was:
> 
> - DocumentType eDocType = pDoc ? pDoc->GetDocumentType() :
> DOCUMENT_TYPE_IMPRESS;
> - aRepresentation = ( ( eDocType == DOCUMENT_TYPE_IMPRESS )
> 
> That suggests that pDoc can be a nullptr. 
> Fix is in https://gerrit.libreoffice.org/#/c/22006/

Thanks. Now I can open the file without crashing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #12 from Oliver Specht  ---
The only way for me to crash was to open a Writer document before which makes
SfxViewShell::Current() return a Writer view shell which ends in an access to a
(SdDrawDocument* pDoc == nullptr

Prio to 
commit 2970ec843820a72d73a91cc11fc353e5b9fde5fd
Author: Noel Grandin 
Date:   Sun Jul 12 21:13:57 2015 +0200

editeng: make Link<> usage typed

Change-Id: Iec36c7e4f4fbc2ee2ee25d4d0c8488340ba7d8c4
Reviewed-on: https://gerrit.libreoffice.org/16968
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 
The crashing line was:

- DocumentType eDocType = pDoc ? pDoc->GetDocumentType() :
DOCUMENT_TYPE_IMPRESS;
- aRepresentation = ( ( eDocType == DOCUMENT_TYPE_IMPRESS )

That suggests that pDoc can be a nullptr. 
Fix is in https://gerrit.libreoffice.org/#/c/22006/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #11 from Julien Nabet  ---
(In reply to Oliver Specht from comment #10)
> On the valgrind stack I can see a lot of accessibility::... calls
> Are there any accessibility tools or extensions active? I don't have that
> symbols on the stack.

Except if I missed something, there's nothing enabled about accessibility on my
laptop.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #10 from Oliver Specht  ---
On the valgrind stack I can see a lot of accessibility::... calls
Are there any accessibility tools or extensions active? I don't have that
symbols on the stack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #9 from Julien Nabet  ---
Created attachment 122263
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122263=edit
valgrind log

I reproduced the crash with master sources updated today so I retrieved a
Valgrind trace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #5 from Oliver Specht  ---
I cannot reproduce it on a centos with a current master and _no_ dbgutil.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #6 from Julien Nabet  ---
Thank you Oliver for your feedback.
I'll try to get a Valgrind trace to provide more info about this one.

Rosemary Sebastian: just for information, do you also use debug mode?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Rosemary Sebastian  changed:

   What|Removed |Added

 OS|All |other

--- Comment #7 from Rosemary Sebastian  ---
(In reply to Joel Madero from comment #1)
> Bodhi Moksha
> Version: 5.2.0.0.alpha0+
> Build ID: 182375f7a90ca53919fd2892f7856aee4d678dd0
> CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
> Locale: en-US (en_US.UTF-8)
> 
> 
> I can open the file without a problem.
> 
> 
> What OS are you using? Does it happen with fresh stable build? How about 5.2
> daily? 
> 
> Marking as NEEDINFO - if you still see the problem in master and answer the
> above please set to UNCONFIRMED. Thanks

Sorry that I didn't mention my OS. I use Ubuntu 15.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

--- Comment #8 from Rosemary Sebastian  ---
(In reply to Julien Nabet from comment #6)
> Thank you Oliver for your feedback.
> I'll try to get a Valgrind trace to provide more info about this one.
> 
> Rosemary Sebastian: just for information, do you also use debug mode?

No I don't use any debug mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Julien Nabet  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
 CC||oliver.spe...@cib.de

--- Comment #4 from Julien Nabet  ---
Oliver: I'm not sure at all, so really just a guess, but by taking a look to
bt, I wonder if it might be due to
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d3c7c9ea81ee7c617f8cee5b645621088aea215b,
any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Joel Madero  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace, regression
   Priority|medium  |high
 Status|NEEDINFO|NEW
   Severity|normal  |major

--- Comment #3 from Julien Nabet  ---
With LO Debian package 5.0.5.1, I don't reproduce this with a brand new file.
I also tested to open the file generated from 5.0.5.1 with master sources
build, I got a crash too.
=> regression => increase importance

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Created attachment 122240
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122240=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today (+dbgutil), I reproduced
the crash from the reporter's file and from a brand new file following initial
description.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97374] FILEOPEN: Impress crashes loading a file with Page Title field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97374

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jmadero@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Joel Madero  ---
Bodhi Moksha
Version: 5.2.0.0.alpha0+
Build ID: 182375f7a90ca53919fd2892f7856aee4d678dd0
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
Locale: en-US (en_US.UTF-8)


I can open the file without a problem.


What OS are you using? Does it happen with fresh stable build? How about 5.2
daily? 

Marking as NEEDINFO - if you still see the problem in master and answer the
above please set to UNCONFIRMED. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs