[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Winfried Donkers  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #24 from Winfried Donkers  ---
(In reply to Timur from comment #23)
> Now:
>  -open attachment 122714 [details]
>  -delete cell A4, cells A5:A8 show revised results (unlike before)
>  -undo and than delete cell A4 again
>   expected behaviour: cells A5:A8 show revised results
>   actual behaviour: cells A5:A8 do not change

Yes, I confirm. 
Moving the cursor (anywhere, including away from A4 and back to A4) between the
first and the second delete action shows expected behaviour, though.  
As this regards the second patch of this bug report, I have put Eike as
assignee.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #22 from Timur  ---
Looks like fixed, at least as reported in Comment 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #23 from Timur  ---
(In reply to Winfried Donkers from comment #6)
> Created attachment 122714 [details]
> 
> -open second attachment (Calc document with autocalculate ON)
> -delete cell A4
> -expected behaviour: cells A5:A8 showing revised results
>  actual behaviour: cells A5:A8 do not change

Now:
 -open attachment 122714
 -delete cell A4, cells A5:A8 show revised results (unlike before)
 -undo and than delete cell A4 again
  expected behaviour: cells A5:A8 show revised results
  actual behaviour: cells A5:A8 do not change

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #21 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1bfc042ea7af6f7b3b0410cb03cef41a358582d4=libreoffice-5-0

fix the "group not recalculated after delete" second part of tdf#97897

It will be available in 5.0.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.1.2   |target:5.2.0 target:5.1.2
   ||target:5.0.6

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||887

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #20 from Commit Notification 
 ---
Winfried Donkers committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8dd5dbbb6ef27e7e5405e38761576a61f11a3b19

tdf#97897 (first problem) fix for not recalculating on F9.

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Cor Nouws  changed:

   What|Removed |Added

 CC||fritz3...@gmail.com

--- Comment #19 from Cor Nouws  ---
*** Bug 98486 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0|target:5.2.0 target:5.1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #18 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a5d00507d08179d2511de0b5152e17a238f4a2d=libreoffice-5-1

fix the "group not recalculated after delete" second part of tdf#97897

It will be available in 5.1.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #17 from Winfried Donkers  ---
(In reply to Eike Rathke from comment #16)
> For the first part of this bug, F9 not recalculating a loaded document when
> AutoCalc was/is off, there's not much we can do about other than forcing a
> full hard recalc the first time F9/recalc is executed or AutoCalc is
> switched on after load.
> 
> Other than that we could (should?) calculate dirty dependencies before
> saving such a document as to not save a dirty doc. Maybe only after having
> asked the user what s/he wants.

IMHO it would be a good idea to warn the user when opening a document that has
autocalculate off that the document may contain formulas that need
recalculation.
Giving a choice to do a forced recalculation would make it even more user
friendly. (Somewhat similar to the warning you get when a document contain
macros.)

I know from experience in the company where I work that opening such a document
leads to erroneous interpretation of the data and even to suspicion that Calc
is no good.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #16 from Eike Rathke  ---
For the first part of this bug, F9 not recalculating a loaded document when
AutoCalc was/is off, there's not much we can do about other than forcing a full
hard recalc the first time F9/recalc is executed or AutoCalc is switched on
after load.

Other than that we could (should?) calculate dirty dependencies before saving
such a document as to not save a dirty doc. Maybe only after having asked the
user what s/he wants.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #15 from Eike Rathke  ---
Pending review
https://gerrit.libreoffice.org/22783 for 5-1
https://gerrit.libreoffice.org/22784 for 5-0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #14 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=164419bfe6270015ccf94183c0b6273da7730391

fix the "group not recalculated after delete" second part of tdf#97897

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #13 from Winfried Donkers  ---
(In reply to raal from comment #11)
> commit f571104ef38ba9f7f6073e22c2374add7aa73887

Reverting this commit makes F9 work again with attachment 122676 .
I can't see the unwanted consequences of just reverting this commit yet, so I'm
not yet at the proper solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Winfried Donkers  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=69
   ||244

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Cor Nouws  changed:

   What|Removed |Added

 CC||jon_camill...@yahoo.it

--- Comment #12 from Cor Nouws  ---
*** Bug 98216 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #11 from raal  ---
(In reply to Winfried Donkers from comment #0)
> Created attachment 122676 [details]
> Calc Document with formula
> 
> Steps to reproduce:
> 1. open attachment
> 2. select cell B3
> 3. press F9 or Extra-Cell-Recalculate
> 4. expected behaviour: the result in B3 changes from 3 to 4
>actual behaviour: formula is not recalculated.
> 
> Only when cell A1 or A2 is changed, F9 functions.
> 
> Ctrl-Shift-F9 dos function in all cases, problem only exists for F9.
> 
> Reproduced in versions 4.4.7, 5.0.4, 5.0.5 and 5.2 (master) on Windows and
> on Linux.
> 
> The current behaviour is confusing and leads to wrong user-interpretations
> of formula results.

Winfried this is only one line commit..

f9bbb93682b5028ef66fbf65a0e93aeefc1482ec is the first bad commit
commit f9bbb93682b5028ef66fbf65a0e93aeefc1482ec
Author: Matthew Francis 
Date:   Thu May 28 18:33:32 2015 +0800

source-hash-f571104ef38ba9f7f6073e22c2374add7aa73887

commit f571104ef38ba9f7f6073e22c2374add7aa73887
Author: Kohei Yoshida 
AuthorDate: Mon Jan 27 19:08:30 2014 -0500
Commit: Kohei Yoshida 
CommitDate: Mon Jan 27 19:11:55 2014 -0500

fdo#69244: Avoid putting these cells in formula tree prematurely.

Marking the cell dirty alone appears to be sufficient to trigger
resetting
of number format.  SetDirty() would mark it dirty *and* put the cell
into
formula tree, which would prevent proper value propagation as seen in
the
bug report.

Change-Id: Ie68f996112938fe286a9bd50c38404f9df6f4ca1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Winfried Donkers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #10 from Winfried Donkers  ---
Working on a quick patch for the second problem.
It is caused by commit 5ef856e975d7c0396984d588a43fd1a7c7085c55 and reverting
one removed call fixes the problem. 
But as the above commit aimed to improve performance, it is not the best fix.
That however may prove too complex to find in a short time. Probably better to
fix now for versions 5.0 and 5.1 and try that best fix next...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Winfried Donkers  changed:

   What|Removed |Added

 CC||libreoff...@kohei.us

--- Comment #9 from Winfried Donkers  ---
@Kohei:
In commit 5ef856e975d7c0396984d588a43fd1a7c7085c55 (19 Nov 2014)
you removed 2 calls to   
   StartListeningTo( pDocument );

Putting these back in makes the problems with
https://bugs.documentfoundation.org/attachment.cgi?id=122714 disappear.

Do you remember anything about this commit and if so, could you tell me about
the why? That way I can try to fix the problem without breaking unknown
matters.
Should you wish to do it yourself, I won't feel offended ;-)

BTW, this doesn't fix the problem of
https://bugs.documentfoundation.org/attachment.cgi?id=122676 .

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||r...@post.cz

--- Comment #8 from raal  ---
bisected file test2.ods

d12d1a450eb7599eb60ba605ce7a7e8b12bcb744 is the first bad commit
commit d12d1a450eb7599eb60ba605ce7a7e8b12bcb744
Author: Matthew Francis 
Date:   Sun Mar 15 06:07:23 2015 +0800

source-hash-5ef856e975d7c0396984d588a43fd1a7c7085c55

(Bibisect: Skipped preceding irrelevant commit(s)
b2efe90c07baa45d2ee7e13138dd306a29738473)

commit 5ef856e975d7c0396984d588a43fd1a7c7085c55
Author: Kohei Yoshida 
AuthorDate: Tue Nov 18 21:03:05 2014 -0500
Commit: Kohei Yoshida 
CommitDate: Tue Nov 18 21:03:50 2014 -0500

Use group area listeners during ODS import.

Change-Id: Id01f9021dda7f33255f8206174cd730507ab55ad

:04 04 126e010c62ce770ece406648bd72b0d2505c593f
e7bee6d7439acbe7be3fd506baefed81c493b191 Mopt

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

--- Comment #7 from Winfried Donkers  ---
(In reply to Winfried Donkers from comment #6)
> Created attachment 122714 [details]
> Calc document with formulas
> 
> It's worse:
> -open second attachment (Calc document with autocalculate ON)
> -delete cell A4
> -expected behaviour: cells A5:A8 showing revised results
>  actual behaviour: cells A5:A8 do not change
> 
> (Possibly this behaviour is unrelated, but as I haven't found the code where
> recalculate is supposed to happen, I can't tell yet.)

Pressing F9 in one of the cells A5:A8 doesn't help either, Ctrl-Shift-F9 is
needed to recalculate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97897] Recalculate does not always work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97897

Winfried Donkers  changed:

   What|Removed |Added

Summary|Recalculate (F9) does not   |Recalculate does not always
   |always work |work

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs