[Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 Jakub Kościelak changed: What|Removed |Added Assignee|[email protected] |[email protected] |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #20 from Jakub Kościelak --- Currently, we're using 32x32 icons displayed in a 24x24 control. Control.idt: Width Height Attributes 24 24 5242881 Attributes 5242881 = 1(Visible) + 4194304(IconSize 32x32) + 1048576(FixedSize enabled) With these settings, these icons will always be 24x24 and won't be scaled (except for scaling the icon from 32 to 24 to fit the control). MSI is outdated in terms of .ico file support; the maximum size that can be set is 48x48 pixels. However, we can use a little trick. I disabled FixedSize and created 128x128 .ico files based on the .svg files and used 32x32 controls. Width Height Attributes 32 32 4194305 Attributes 4194305 = 1(Visible) + 4194304(IconSize 32x32) + 0(FixedSize disabled) With these settings, these icons will be 32x32 at 100% scale, but will scale, for example, to 64x64 at 200% scale. There will be no stretching or pixelation because it will start at 128x128 and scale down. Only after scaling exceeds 400% (4x32 = 128), i.e., for screens larger than 8K, will the size stretch beyond 128x128 begin. We can use 256x256 icons right away and be 16K ready ;-) I've attached screenshots from the installer at 175%, 150%, 125%, and 100% at Full HD. 250%, 225%, and 200% at 2560x1600. 400% at 2560x1600. It looks nice. I'd be happy to prepare a small patch. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #19 from Jakub Kościelak --- Created attachment 204857 --> https://bugs.documentfoundation.org/attachment.cgi?id=204857&action=edit 400% in 2560x1600. 400% in 2560x1600. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #18 from Jakub Kościelak --- Created attachment 204856 --> https://bugs.documentfoundation.org/attachment.cgi?id=204856&action=edit 250%, 225%, and 200% in 2560x1600. 250%, 225%, and 200% in 2560x1600. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #17 from Jakub Kościelak --- Created attachment 204855 --> https://bugs.documentfoundation.org/attachment.cgi?id=204855&action=edit 175%, 150%, 125%, and 100% in Full HD. 175%, 150%, 125%, and 100% in Full HD. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #16 from QA Administrators --- Dear Chaoting Liu, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #15 from QA Administrators --- Dear Chaoting Liu, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 Roman Kuznetsov <[email protected]> changed: What|Removed |Added Assignee|[email protected] |[email protected] ||desktop.org Status|ASSIGNED|NEW --- Comment #14 from Roman Kuznetsov <[email protected]> --- Unassigned myself. I created icon files with different resolution from 16x16 to 128x128, but I didn't found an info about icon scale handling in MSI. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 Roman Kuznetsov <[email protected]> changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #13 from V Stuart Foote --- (In reply to Rizal Muttaqin from comment #10) > > I can not see any problem here The .ico are not scaled with the rest of the installer dialog, so they appear under sized. Providing as .BMP would scale, like the other graphics. Alternatively, the .ico can contain values for rendering at multiple scales as pointed out comment 3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #12 from Mike Kaganski --- Created attachment 168125 --> https://bugs.documentfoundation.org/attachment.cgi?id=168125&action=edit 175% vs 100% Very easy to repro without any special screens. Windows Settings->System->Display->Scale and Layout->change it from 100% to another value, and restart installer. Attached is side-by-side screenshot of the dialog on 175% scaling vs. 100%. It's apparent that dialog itself, fonts, radio buttons, and top banner have scaled accordingly; while the icons stay as they were (they keep the same pixel size, not relative size). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #11 from Chaoting Liu --- > I can not see any problem here Yeah, the 1080p screenshot demonstrated the somehow "pixel perfect" UI. While, the 4K screenshot is where this "bug" lies. I still cannot reach that 4K monitor in this near few days. So I'd ask in humble that if someone can give me some "yes, I can reproduce that on my 7.0.3.1 with resolution higher than 1080p!" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #10 from Rizal Muttaqin --- (In reply to Chaoting Liu from comment #8) > Created attachment 168120 [details] > LO7.0.3.1 1080p zoom@100% I can not see any problem here -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 Chaoting Liu changed: What|Removed |Added Attachment #168086|0 |1 is obsolete|| --- Comment #9 from Chaoting Liu --- Created attachment 168121 --> https://bugs.documentfoundation.org/attachment.cgi?id=168121&action=edit LO 6.4.4.2 @4K zoom 125% -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #8 from Chaoting Liu --- Created attachment 168120 --> https://bugs.documentfoundation.org/attachment.cgi?id=168120&action=edit LO7.0.3.1 1080p zoom@100% -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #7 from Chaoting Liu --- No, it isn't fine under 7.0.3.1 under 4K resolution. I'd attach another "normal" screenshot under 1080p -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #6 from Rizal Muttaqin --- (In reply to Roman Kuznetsov from comment #4) > Rizal, can you add icons in BMP format from existing SVG files in address > above? If the icons are fine with current latest stable (7.0.3.1) release, so why we need to change current situation? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #5 from Mike Kaganski --- (In reply to Roman Kuznetsov from comment #4) MSI does not support SVGs. I would not be so sure before evaluating. In theory, ICO has a potential advantage of supporting *several* resolutions in a single file; and it *possibly* could allow us to have it automatically choose proper resolution icon for each screen resolution - without the ugly stretching, having pixel-perfect result. But that needs investigation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 Roman Kuznetsov <[email protected]> changed: What|Removed |Added Ever confirmed|0 |1 CC||[email protected] Status|UNCONFIRMED |NEW --- Comment #4 from Roman Kuznetsov <[email protected]> --- (In reply to Mike Kaganski from comment #3) > (In reply to V Stuart Foote from comment #2) > > Roman, Mike, * can the MSI itself be made dpi aware? > > MSI *is* DPI-aware. And all its dimensions are, in fact, in special units > related to a font size scaled to the screen resolution [1]. > > It is obvious that our installer does follow the resolution properly on the > screenshot, if you look at the top banner with "6". > > The problem here seems to be because of using ICO images for these specific > problematic places (and Icon type in Control.idt), not BMP (and Bitmap type). > > The Icon type [2] has some bits that might be related, namely FixedSize and > IconSize, and maybe we can just modify those, and not change the type. > > [1] https://docs.microsoft.com/en-us/windows/win32/msi/installer-units > [2] https://docs.microsoft.com/en-us/windows/win32/msi/icon-control I think we could rework all icons into bmp format instead .ico and then use Bitmap type instead Icon type in configure files. >From another side we already have all icons in SVG format in https://opengrok.libreoffice.org/xref/core/instsetoo_native/inc_common/windows/msi_templates/Binary/ but I'm not sure MSI installer can use SVG directly inside Rizal, can you add icons in BMP format from existing SVG files in address above? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #3 from Mike Kaganski --- (In reply to V Stuart Foote from comment #2) > Roman, Mike, * can the MSI itself be made dpi aware? MSI *is* DPI-aware. And all its dimensions are, in fact, in special units related to a font size scaled to the screen resolution [1]. It is obvious that our installer does follow the resolution properly on the screenshot, if you look at the top banner with "6". The problem here seems to be because of using ICO images for these specific problematic places (and Icon type in Control.idt), not BMP (and Bitmap type). The Icon type [2] has some bits that might be related, namely FixedSize and IconSize, and maybe we can just modify those, and not change the type. [1] https://docs.microsoft.com/en-us/windows/win32/msi/installer-units [2] https://docs.microsoft.com/en-us/windows/win32/msi/icon-control -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 V Stuart Foote changed: What|Removed |Added CC||[email protected], ||[email protected], ||[email protected] Blocks||113117 --- Comment #2 from V Stuart Foote --- Roman, Mike, * can the MSI itself be made dpi aware? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113117 [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138841] Windows installer display tiny icon under high resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=138841 --- Comment #1 from Chaoting Liu --- Created attachment 168086 --> https://bugs.documentfoundation.org/attachment.cgi?id=168086&action=edit the bugged screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
