[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0814 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #19 from Justin L --- Created attachment 193829 --> https://bugs.documentfoundation.org/attachment.cgi?id=193829=edit commentsInWord.docx: the source document for the previous screenshot -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #18 from Justin L --- Created attachment 193828 --> https://bugs.documentfoundation.org/attachment.cgi?id=193828=edit commentsInWord2019.PNG: screenshot of single reply to thread in MSO Likely our poor model is just a copy of what MSO does. It too is extremely limited in comment replies. You can only reply to the thread, and comments cannot be re-organized, etc. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #17 from Justin L --- (In reply to Timur from comment #15) > Separately, please explain that all "replies" are replies of a top comment > and never a reply to a reply. The only thing that suggests you have "replied to a reply" is some free-form answer-text that says 'Reply to xyz (04/23/2024, 09:29): "..."' However, that answer-text is NOT composed by the actions of hitting the reply button (FN_REPLY) and there is NOTHING in the comment itself that points to the comment that you think you replied to. INSTEAD, the answer-text is composed during its first LAYOUT, and is compiled FROM THE COMMENT IT FOLLOWS. This all happens long after the comment has been created. The internals of the comment indicate that its ParentPostItId is the top level comment - which is why the navigator shows only two levels of comments. Therefore, when I changed "MoveCaret" to move the reply to the end of the thread instead of the beginning of the thread, the answer-text "replied" to the second-last comment instead of the first comment. In other words, the entire comment design is based on the assumption that replies go to the top of the thread. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #16 from Justin L --- Created attachment 193824 --> https://bugs.documentfoundation.org/attachment.cgi?id=193824=edit Reply to someone else's comment in OOo 3.3.png: screenshot of replying in OOo. Using Comment Reply Example.docx (attachment 145913 from bug 119229) and bibisect-releases git checkout oldest (openoffice-3.3.0), I see a reply button. (Until recently, there was code that prevent someone from replying to their own comments - I assume that code is related to why your screenshot doesn't show a reply option.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #15 from Timur --- Created attachment 193820 --> https://bugs.documentfoundation.org/attachment.cgi?id=193820=edit Comment menu (In reply to Justin L from comment #13) > (In reply to Timur from comment #0) > > Seems like implementationError from when replies were added in LO 5.4. > I can reply to comments in OOo 3.3. Plese explain how to reply to comments in OO. Per attachment, in OO or 4.4 or 5.2, in comment menu there is no Reply, seen from LO 5.4. Separately, please explain that all "replies" are replies of a top comment and never a reply to a reply. Wrt that my test showed different behavior when replying to the top comment and replying to replies. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #14 from Justin L --- Inserting the comment at the end of the thread can easily happen with SwAnnotationWin::MoveCaret. But that causes a problem. The first time the reply undergoes LayoutPostIts, it InitAnswer's, and this expects that it is a reply to the previous comment. mrMgr.GetNextPostIt(KEY_PAGEUP, this); In fact, there is NO hierarchy of replies, REGARDLESS OF WHAT IT MAY LOOK LIKE. The navigator actually show this - all "replies" are replies of a top comment. (OK, so there is a two level hierarchy - initial comments and replies to the initial comment [GetTopReplyNote()], but never a reply to a reply.) In order to solve this bug, postit's need a complete rewrite. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 Justin L changed: What|Removed |Added Version|5.4.0.3 release |Inherited From OOo --- Comment #13 from Justin L --- (In reply to Timur from comment #0) > Seems like implementationError from when replies were added in LO 5.4. I can reply to comments in OOo 3.3. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9229 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #12 from Cor Nouws --- May I please ask @timur and @bogdanb to look at attachment 193483? There replies are shown below the comment on which they are done. What do you think of that situation? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Keywords|implementationError,| |needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Status|UNCONFIRMED |NEW --- Comment #11 from Heiko Tietze --- We discussed the topic in the design meeting. There are arguments for both sides, yet the majority believes in the "book style" with latest at bottom. Please make it possible via expert setting to switch back to the current sort order, if possible. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #10 from Cor Nouws --- Created attachment 193483 --> https://bugs.documentfoundation.org/attachment.cgi?id=193483=edit screen shot with mixed threads example with various relies mixed - looks sensible as Heiko suggests in comment #7 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #9 from BogdanB --- Heiko, from my point of view a +1 for book view, like in Google Drive/Bugzilla, if you will have a Jitsi meeting soon. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #8 from Timur --- (In reply to Heiko Tietze from comment #7) > Latest on top sounds reasonable. The real world scenario is A,B,C being > different people replying individually on some comment. How is that resonable, when that is contrary to time logic, user expectation, the way work Google Docs or MS Ofice, even this Bugzilla, or any commenting system? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #7 from Heiko Tietze --- Latest on top sounds reasonable. The real world scenario is A,B,C being different people replying individually on some comment. If the communication is a thread and B replies on A, and C on B, etc., you get the sequence as expected. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #6 from BogdanB --- If we read comments like a chat, the order is D, C, B, A. If we read comments like a book, the order is A, B, C, D. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #5 from Timur --- G docs and MSO both work as I expect, replies order as inserted. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 --- Comment #4 from Aron Budea --- Created attachment 193296 --> https://bugs.documentfoundation.org/attachment.cgi?id=193296=edit Current order This screenshot should help showing current behavior. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 Aron Budea changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #3 from Aron Budea --- What Timur described is that when you add multiple replies to the same comment, the replies will always be added right below the original comment, not below the existing replies, this is how the order of replies will be in reverse in the end. I agree with the expectation that they should be in the order as they're added, but let's ask the UX team as well for input. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 Timur changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from Timur --- Steps are rather clear, I think. It is about comment order. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160350] Replies to comment are in reverse order
https://bugs.documentfoundation.org/show_bug.cgi?id=160350 wjsim changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from wjsim --- Thank you for reporting the bug. Could you give clearer instructions to replicate the bug? Where are you seeing D, C, B, A? I did as you said and the comments are where the comments are supposed to be. Tested with: Version: 24.2.1.2 (X86_64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 6a064b1967e06e40be40817deff99d00c1a8554f CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: ko-KR (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
