[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |FIXED

--- Comment #20 from Xisco Faulí  ---
(In reply to David Tardon from comment #19)
> @Bernard, @Urmas: Could either of you verify this has indeed been fixed?

Since there's a commit fixing this issue, let's put it to RESOLVED FIXED.
@Bernard, @Urmas, change it back to NEW if the issue is still reproducible in
master...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

David Tardon  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #19 from David Tardon  ---
@Bernard, @Urmas: Could either of you verify this has indeed been fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

--- Comment #18 from osnola  ---
(In reply to osnola from comment #17)
>
> I add a new patch in libwps to try parsing these structures
> https://sourceforge.net/p/libwps/code/ci/
> ed353bb70c56fe1cb53a7dfe338200564d06e9dc/ ...

Hello, 
as I am trying to compile a libwps version with emscripten:
http://kripken.github.io/emscripten-site/ ,
you can try if these changes correct the seen problems in
http://www.loria.fr/~alonso/tmp/wps2odt.html (a temporary link). Normally, if
this "test page" works, you can choose a file to be converted and then open the
result in LibreOffice or save it...

Notes:
- the interface must be improved a lot :-~
- I try to "save" the converted result with FileSaver.js:
https://github.com/eligrey/FileSaver.js , so some browsers are not supported
:-~
- if the file to be converted is very big as "0.\ PARA\ ALL.WDB", the
conversion can take one or two minutes and as I have not implemented a progress
bar, you may see a message saying that the script is not responding do you want
to abort it/continue :-

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

--- Comment #17 from osnola  ---
(In reply to osnola from comment #15)
>
> Note:
> - concerning the structure with id=0x36, I will look if I can parse it...

I add a new patch in libwps to try parsing these structures
https://sourceforge.net/p/libwps/code/ci/ed353bb70c56fe1cb53a7dfe338200564d06e9dc/
...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

--- Comment #16 from osnola  ---
(In reply to osnola from comment #15)
> ...
> I suppose that the problem is that we use gmtime in
> WKSContentListener::CellContent::double2Date 
> (
> https://sourceforge.net/p/libwps/code/ci/master/tree/src/lib/
> WKSContentListener.cpp ) and that on Windows, date before 1970 are not
> supported by gmtime ( for instance
> http://stackoverflow.com/questions/21869602/mongodb-date-issue-when-before-
> 1970 ). As I do not have access on computer with Windows, if someone has
> some idea how to fix that on Windows, let me know
> 
I have added a patch to do the conversion by hand:
https://sourceforge.net/p/libwps/code/ci/818d9c4f527f08965e17ac9146286f3171622f5d/
can someone on Windows check if this solve the date's problem ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

--- Comment #15 from osnola  ---
Hello, I test on OSX using a 32bit and a 64bit version of libwps and I can not
reproduce the date's problem :-~ 

I suppose that the problem is that we use gmtime in
WKSContentListener::CellContent::double2Date 
(
https://sourceforge.net/p/libwps/code/ci/master/tree/src/lib/WKSContentListener.cpp
) and that on Windows, date before 1970 are not supported by gmtime ( for
instance
http://stackoverflow.com/questions/21869602/mongodb-date-issue-when-before-1970
). As I do not have access on computer with Windows, if someone has some idea
how to fix that on Windows, let me know

Note:
- concerning the structure with id=0x36, I will look if I can parse it...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

--- Comment #14 from David Tardon  ---
(In reply to Urmas from comment #12)
> Created attachment 125370 [details]
> Long text and linebreaks testcase

Could you open a separate bug for this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100043] Works Database: dates earlier than 1970-01-01 are not handled correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100043

David Tardon  changed:

   What|Removed |Added

 CC||dtar...@redhat.com
  Component|filters and storage |General
Version|5.1.3.2 release |unspecified
Product|LibreOffice |Document Liberation Project
Summary|import filter MS Works  |Works Database: dates
   ||earlier than 1970-01-01 are
   ||not handled correctly
 Whiteboard||libwps

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs