[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108728


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108728
[Bug 108728] [META] Dictionaries bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.3.0.1 |target:5.4.0 target:5.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Aron Budea  ---
Commits are now in 5.3 as well. Not in beta1, but it'll be in beta2 or 5.3.0.1
for sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #13 from Commit Notification 
 ---
Aron Budea committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=29dbac6fe556eb27067155c3be0c566b5328995c=libreoffice-5-3

tdf#103922: Add Tibetan (bo) dictionary

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #12 from Commit Notification 
 ---
Aron Budea committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fc88ed47a66e76d279471c1da1193ce90ad8e9e5

tdf#103922: Add Tibetan (bo) dictionary

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #11 from Aron Budea  ---
Andras committed the dictionary:
https://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=f023ac778c97881a53035f951fca95cee759888e

However, some related changes have to be made in the core repo as well. The
changes are pending in the following patch:
https://gerrit.libreoffice.org/#/c/31089/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #10 from Elie Roux  ---
Aron Budea, how long does the gerrit review usually take? I'm not really
familiar with how things work...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #9 from Elie Roux  ---
Ok understood. Thanks for the CHANGELOG!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #8 from Aron Budea  ---
I meant, in the extension file that is uploaded at [1], the .dlc and .aff files
are in a directory called "dictionaries", and are referenced via that path in
dictionaries.xcu. Move those files in the root of the archive, and get rid of
that directory in the future, please.

In the meantime, CHANGELOG.md has been added to the patch.

[1] http://extensions.openoffice.org/en/project/tibetan-syllable-spell-checker

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #7 from Elie Roux  ---
Thanks a lot for the patch! It looks fine, maybe the CHANGELOG.md could have
fit in, but it's not very important...

I'm not sure what you mean with "moving the .dic and .aff files a directory
up", do you mean put them in a separate directory? Do you have an example of
another dictionary using the structure you describe?

Thanks again!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #6 from Aron Budea  ---
Elie, in the future please move the .dic and .aff files a directory up in the
extension, and adjust paths in dictionaries.xcu accordingly.
Even though the directory structure doesn't matter in itself, other
dictionaries use this structure, and working with them is slightly more
straightforward if the structure is consistent. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #5 from Aron Budea  ---
Ok, I see it's for both.
I'm not sure I did everything correctly, but patch is in gerrit for review:
https://gerrit.libreoffice.org/#/c/30920/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Aron Budea  ---
I could add it to dictionaries, I was able to find two "bo" locales in
i18npool/source/localedata/localedata.cxx: bo_IN and bo_CN. I'd assume this'd
be bo_IN, right? (technically it doesn't matter, it's just the name for the
directory, but I'd like to be proper)

I'm also not sure if any reference has to be added to core repo... maybe not?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Caolán McNamara  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu,
   ||ti...@fsf.hu

--- Comment #3 from Caolán McNamara  ---
@xisco: this is a request to add those Tibetan hunspell dictionaries to
LibreOffices "dictionaries" git submodule. I help look after the hunspell
library, which is the code which used to make use of those dictionaries. Maybe
Aron or Timar could help, they did a lot of the updates in dictionaries

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

--- Comment #2 from Elie Roux  ---
Just to be sure, I'm talking about the repository on

https://cgit.freedesktop.org/libreoffice/dictionaries/

here, there are many contributors...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103922] please add Tibetan Hunspell files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103922

Xisco Faulí  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Hi Caolan,
Looking for 'hunspell' in the git log I see you have upgraded hunspell in the
past. Is this something we can do or it needs to be done in hunspell's project?
Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs