[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #16 from Buovjaga  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #15)
> Can someone please verify the fix? Then we can backport this to 6.0 too.

I verified it in December, see comment 13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||s.mehrbr...@gmail.com
 Resolution|--- |FIXED

--- Comment #15 from Samuel Mehrbrodt (CIB)  ---
Can someone please verify the fix? Then we can backport this to 6.0 too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #14 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=122da2eea23faf6916c3f3b9e1895f5c404b26c7

tdf#107567 et al. Paragraph dialog preview windows fixes

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #13 from Buovjaga  ---
(In reply to Jim Raykowski from comment #12)
> Hi All,
> 
> Here is a reworked patch for this bug. No merge conflict.
> 
> https://gerrit.libreoffice.org/#/c/45273/

I cherry picked it and confirm the fix works.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: b2d87e00ed93db79ba64a9bef83e20d44c69dd7c
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on December 18th 2017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #12 from Jim Raykowski  ---
Hi All,

Here is a reworked patch for this bug. No merge conflict.

https://gerrit.libreoffice.org/#/c/45273/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #11 from Buovjaga  ---
(In reply to Jim Raykowski from comment #10)
> This patch hasn't been merged yet. It includes fixes for this bug report and
> tdf#98211, tdf#98212, tdf#113275. To test it you will need to pull it from
> the following link and then build. 
> 
> https://gerrit.libreoffice.org/#/c/43678/

Looks like there is a merge conflict with the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #10 from Jim Raykowski  ---
(In reply to Omer Zak from comment #9)
> Still happens in:
> 
> Version: 6.0.0.0.alpha1+
> Build ID: 9050854c35c389466923f0224a36572d36cd471a
> CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; 
> Locale: en-US (en_US.utf8); Calc: group
> 
> OS: Debian 64bit Stretch (Debian 9.2, with some backported packages)
> 
> 
> A similar bug appears also in Justification tab of the same dialog (see:
> https://bugs.documentfoundation.org/show_bug.cgi?id=113823).

Hi Omer,

This patch hasn't been merged yet. It includes fixes for this bug report and
tdf#98211, tdf#98212, tdf#113275. To test it you will need to pull it from the
following link and then build. 

https://gerrit.libreoffice.org/#/c/43678/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #9 from Omer Zak  ---
Still happens in:

Version: 6.0.0.0.alpha1+
Build ID: 9050854c35c389466923f0224a36572d36cd471a
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.utf8); Calc: group

OS: Debian 64bit Stretch (Debian 9.2, with some backported packages)


A similar bug appears also in Justification tab of the same dialog (see:
https://bugs.documentfoundation.org/show_bug.cgi?id=113823).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #8 from Yousuf Philips (jay)  ---
(In reply to Jim Raykowski from comment #7)
> I couldn't resist :-)

Glad that you didnt resist. :D

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #7 from Jim Raykowski  ---
I couldn't resist :-)

link to patch is here
https://gerrit.libreoffice.org/#/c/43678/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #6 from Jim Raykowski  ---
Is it OK if I take this one?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #5 from Buovjaga  ---
Confirmed.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha1+
Build ID: 6e4cba99bb35e6697b94309eedd1a08ebea2dc68
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on May 5th 2016

Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107642


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107642
[Bug 107642] [META] Paragraph dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #4 from Yousuf Philips (jay)  ---
(In reply to V Stuart Foote from comment #3)
> Beleive it is just the *preview* for the Paragraph dialog that is
> incorrectly formatted.

Yes just the preview.

> The representation of the "Indents & Spacing" does not respond to the font
> direction assigned to the paragraph.  While the "Alignment" tab does respond
> to the LTR/RTL setting of the paragraph.

Well actually the Alignment tab is also likely not responding to the LTR/RTL
setting you just cant see it as it is affected by the alignment option, which
in RTL is set to right.

> Are the actual indentations: "Before text", "After text" and "First line"
> correct for the given script?

Yep those seem fine either way as they are direction neutral.

> If they're correct it is just cosmetic to the GUI rather than functional.

Yes its just cosmetic to the rendering of the preview.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #3 from V Stuart Foote  ---
Sorry, I don't think Khaled's work would have impacted this. Typically, I
misread the issue.

Beleive it is just the *preview* for the Paragraph dialog that is incorrectly
formatted.

The representation of the "Indents & Spacing" does not respond to the font
direction assigned to the paragraph.  While the "Alignment" tab does respond to
the LTR/RTL setting of the paragraph.

Are the actual indentations: "Before text", "After text" and "First line"
correct for the given script?

If they're correct it is just cosmetic to the GUI rather than functional.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #2 from Yousuf Philips (jay)  ---
@Stuart: Tested the latest available daily build and no difference.
@Khaled: Is your patch intended to fix this issue?

Version: 5.4.0.0.alpha0+
Build ID: 74ccd02eda2d6325a27266fd935aba29b3d75020
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-04-27_23:51:14
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
@Jay, any better if you use a build of master with Khaled's
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3b7ef45d4364fda15691b5748a9a88bc908afc6
done for bug 107204 that posted 2017-04-27?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs