[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Adolfo Jayme Barrientos  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|42082, 71732, 83066,|
   |103729, 108400, 114019  |
 Resolution|--- |DUPLICATE

--- Comment #20 from Adolfo Jayme Barrientos  ---
The issue has been fixed! See commit 4b693a0c594fb3b73f4a4c1e03e9916f1a107012

*** This bug has been marked as a duplicate of bug 148470 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=42082
[Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language
issues
https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] HarfBuzz-based common text layout regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=108400
[Bug 108400] [META] Toolbar tooltip bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114019
[Bug 114019] [META] Tooltip bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

eisa01  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3555

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Kamei  changed:

   What|Removed |Added

 Blocks||114019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114019
[Bug 114019] [META] Tooltip bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #19 from Jun Nogata  ---
Created attachment 172325
  --> https://bugs.documentfoundation.org/attachment.cgi?id=172325=edit
fallback font log in vcl/quartz/salgdi.cxx

I put SAL_INFO in line 90 in vcl/quartz/salgdi.cxx and logged it. (Attached
file)

> SAL_INFO( "vcl.quartz", 
> "CoreTextGlyphFallbackSubstititution::FindFontSubstitute() 
> rPattern.maSearchName=" << rPattern.maSearchName );

Where the text was displayed correctly, it was in Hiragino Kaku gothic.

> info:vcl.quartz:19628:58067:vcl/quartz/salgdi.cxx:90: 
> CoreTextGlyphFallbackSubstititution::FindFontSubstitute() 
> rPattern.maSearchName=ヒラギノ角ゴシック

Where the text was garbled, it was displayed in Lucida Grande.

> info:vcl.quartz:19628:58067:vcl/quartz/salgdi.cxx:90: 
> CoreTextGlyphFallbackSubstititution::FindFontSubstitute() 
> rPattern.maSearchName=Lucida Grande

The font is incorrectly specified and the text is garbled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Volga  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=13 |
   |4655|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Volga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||4655

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Adolfo Jayme  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||400

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #18 from himajin100...@gmail.com ---
I cannot reproduce with my Windows 10, and I don't have a macOS.

For who can build a macOS applications who wants to offer assistance,
I leave some questions.

Q1. Does the program reach line 84 when this issue occurs ?
Q2. Let me know what the value of pStr is.
Q3. Let me know What the value of rPattern.maSearchName is?

https://opengrok.libreoffice.org/xref/core/vcl/quartz/salgdi.cxx?r=ca2aa307#84

---
helpful documents if you have never built LibreOffice:

https://wiki.documentfoundation.org/Development/BuildingOnMac
---
on Windows, when I build LibreOffice,
I often pass enable-sal-log and enable-dbgutil(may be unnecessary?) so that I
can use SAL_INFO when  is included.

https://api.libreoffice.org/docs/cpp/ref/a4.html

at least I can use the macro in the following way, for example. at least we can
pass OUString as the second parameter.

SAL_INFO("vcl", OUString::number(3));

be careful not to write

SAL_INFO("vcl", 1 + 2);

but please write this way.

SAL_INFO("vcl", (1 + 2));

I don't know if SAL_INFO's second paramter accepts CFStringRef, but if it
doesn't I believe including  
will let you use OUString GetOUString(CFStringRef)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Christian Lohmaier  changed:

   What|Removed |Added

Version|5.3.3.2 release |5.3.0.3 release

--- Comment #17 from Christian Lohmaier  ---
applying version change by Kamei as of
https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176584.html
(outage)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Kamei  changed:

   What|Removed |Added

Version|5.3.3.2 release |5.3.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

himajin100...@gmail.com changed:

   What|Removed |Added

 CC||sungd...@gmail.com

--- Comment #16 from himajin100...@gmail.com ---
*** Bug 123548 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Adolfo Jayme  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |https://bugs.documentfounda
   |tion.org/show_bug.cgi?id=10 |tion.org/show_bug.cgi?id=12
   |6148,   |0029
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |1387|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Adolfo Jayme  changed:

   What|Removed |Added

 CC||hid...@cio-inc.com

--- Comment #15 from Adolfo Jayme  ---
*** Bug 121387 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1387

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #14 from Jihui Choi  ---
It seems to occur not only on mac osx, but also on windows 10.
there's a report with korean language pack on mac osx sierra and windows 10.

https://ask.libreoffice.org/ko/question/166572/ribeure-opiseueseo-ilbu-ui-tultib-pabeob-cangyi-hangeul-ponteuga-ggaejibnida/

And I also was able to reproduce it on my high sierra with libreoffice 6.0.x
but no problems on ubuntu 18.04, libreoffice 6.1.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

eisa01  changed:

   What|Removed |Added

 CC||pia...@silver.ocn.ne.jp

--- Comment #13 from eisa01  ---
*** Bug 117932 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #12 from Volga  ---
(In reply to Khaled Hosny from comment #11)
> (In reply to Volga from comment #10)
> > (In reply to Khaled Hosny from comment #9)
> > > (In reply to V Stuart Foote from comment #8)
> > > > @Jay, Khaled -- is this really only going to be CJK? Would expect it to
> > > > affect fallback for CTL scripts as well on OSX.
> > > 
> > > Possibly, we didn’t do font fallback on OSX before the switch to HarfBuzz 
> > > as
> > > the system was doing everything, so there is a bit of new not very tested
> > > code here.
> > So is it possible to make use of HarfBuzz font fallback APIs to do?
> 
> HarfBuzz does not have font fallback APIs, and we do font fallback after
> shaping (to a degree) and that is all HarfBuzz has to offer font-fallback
> wise.
So how does LibreOffice do font fallback well on Windows and Linux?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Kamei  changed:

   What|Removed |Added

 Blocks||42082


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=42082
[Bug 42082] [META] Make LibreOffice shine and glow on OS X
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #11 from Khaled Hosny  ---
(In reply to Volga from comment #10)
> (In reply to Khaled Hosny from comment #9)
> > (In reply to V Stuart Foote from comment #8)
> > > @Jay, Khaled -- is this really only going to be CJK? Would expect it to
> > > affect fallback for CTL scripts as well on OSX.
> > 
> > Possibly, we didn’t do font fallback on OSX before the switch to HarfBuzz as
> > the system was doing everything, so there is a bit of new not very tested
> > code here.
> So is it possible to make use of HarfBuzz font fallback APIs to do?

HarfBuzz does not have font fallback APIs, and we do font fallback after
shaping (to a degree) and that is all HarfBuzz has to offer font-fallback wise.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #10 from Volga  ---
(In reply to Khaled Hosny from comment #9)
> (In reply to V Stuart Foote from comment #8)
> > @Jay, Khaled -- is this really only going to be CJK? Would expect it to
> > affect fallback for CTL scripts as well on OSX.
> 
> Possibly, we didn’t do font fallback on OSX before the switch to HarfBuzz as
> the system was doing everything, so there is a bit of new not very tested
> code here.
So is it possible to make use of HarfBuzz font fallback APIs to do?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #9 from Khaled Hosny  ---
(In reply to V Stuart Foote from comment #8)
> @Jay, Khaled -- is this really only going to be CJK? Would expect it to
> affect fallback for CTL scripts as well on OSX.

Possibly, we didn’t do font fallback on OSX before the switch to HarfBuzz as
the system was doing everything, so there is a bit of new not very tested code
here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

--- Comment #8 from V Stuart Foote  ---
@Jay, Khaled -- is this really only going to be CJK? Would expect it to affect
fallback for CTL scripts as well on OSX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108042

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108400, 83066
Summary|Tooltips display for|Tooltips display for
   |toolbar icons suffer from   |toolbar icons suffer from
   |broken font fallback on OSX |broken font fallback on OSX
   ||in CJK UIs


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language
issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108400
[Bug 108400] [META] Toolbar tooltip bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs