[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

Eike Rathke  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #24 from Eike Rathke  ---
If someone who could originally reproduce could please check with one of the
next master builds that includes the above commit if that fixes the problem?
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #23 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d5020f35aec54f0241fa58557dc6caadc149f5a9

Attempt to blind fix tdf#108612 explicitly checking for clipboard document

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #22 from Eike Rathke  ---
So the debugger then can wipe the entire system, great security feature ;-)
SCNR.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #21 from Buovjaga  ---
(In reply to Eike Rathke from comment #20)
> (In reply to Buovjaga from comment #15)
> > Then attach gdb to LibreOffice:
> > sudo gdb --pid `pgrep soffice`
> Don't use sudo ...

I have to personally. If I don't, it says:
ptrace: Operation not permitted.

This is because of https://wiki.archlinux.org/index.php/security#ptrace_scope

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #20 from Eike Rathke  ---
(In reply to Buovjaga from comment #15)
> Then attach gdb to LibreOffice:
> sudo gdb --pid `pgrep soffice`
Don't use sudo ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #19 from Eike Rathke  ---
(In reply to stefan_lange...@t-online.de from comment #18)
> I couldn't install libreoffice-dbg because of errors, see attached log.
> Maybe version conflicts?
Your system pulls in a way too old libreoffice-dbg version 4.2.8, make sure
your dbg package repository matches the release of your regular package
repository, or wherever you installed LO 5.3.3 from.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #18 from stefan_lange...@t-online.de  
---
Created attachment 134511
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134511=edit
Log of terminal from install libreoffice-dbg

I couldn't install libreoffice-dbg because of errors, see attached log. Maybe
version conflicts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #17 from Buovjaga  ---
Ok, you could first install the debug package:
sudo apt-get install libreoffice-dbg

Note that it is over 2,5 gigabytes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #16 from stefan_lange...@t-online.de  
---
Created attachment 134505
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134505=edit
Log of terminal and gdb from the test

Buovjaga, I have tried to make what you have written, but I had some problems,
see also attached log in the odt document!

First problem is:
(gdb) break documen2.cxx:385
No source file named documen2.cxx.
Make breakpoint pending on future shared library load? (y or [n]) y

Must be available for the test the source documen2.cxx:385? When yes, where
must it be located? 

Second problem: In the test didn't come a break, not at first copy + paste and
not at second. I don't know if the reason is the missing (or wrongly located)
source or is it the fact that I can't reproduce the error in Linuy (Ubuntu
17.04) - see my Comment 3.

PS: I am a beginner in Ubuntu and I'm not very familiar with this system.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #15 from Buovjaga  ---
Stefan: if you would like to try what result you get (as I had different
symptoms):

Install gdb
Launch LibreOffice from the commandline with
SAL_NO_MOUSEGRABS=1 ./soffice
That way your mouse clicks will not be hijacked.

Then attach gdb to LibreOffice:
sudo gdb --pid `pgrep soffice`

Press enter when it asks. When you see the (gdb) prompt, give the command
break documen2.cxx:385

Then give the command: c

Then start doing the reproduction steps in LibreOffice. Use c in gdb to
continue until before you have copied A10 to clipboard. When it breaks the next
time, give the command n (for next) like in my previous comment. Then you can
show us your results.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #14 from Buovjaga  ---
I checked with Áron and he asked me to use next instead of step. This is with
copying A10 while A4 is already in the clipboard:

385 if (IsClipboardSource())
(gdb) n
397 mxFormulaParserPool.reset();
(gdb) n
400 pExternalRefMgr.reset();
(gdb) n
402 ScAddInAsync::RemoveDocument( this );

So I understand the if is evaluated to false.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #13 from Buovjaga  ---
Ok, I launched LibO and then in a terminal

sudo gdb --pid `pgrep soffice`

I let it attach and then in the (gdb) prompt gave

break documen2.cxx:385

ie. this line:
https://cgit.freedesktop.org/libreoffice/core/tree/sc/source/core/data/documen2.cxx#n385

Then I gave c to continue. The breakpoint is hit the first time already when I
pasted A4 to E4. I continued and this is what I got when copying A10:

Thread 1 "soffice.bin" hit Breakpoint 1, ScDocument::~ScDocument
(this=0x6a45170, 
__in_chrg=) at
/home/user/libreoffice/sc/source/core/data/documen2.cxx:385
385 if (IsClipboardSource())
(gdb) step
ScDocument::IsClipboardSource (this=this@entry=0x6a45170)
at /home/user/libreoffice/sc/source/core/data/document.cxx:2544
2544{

It was a bit disturbing along the way that gdb grabbed my mouse click focus. I
managed to solve it with this: https://unix.stackexchange.com/a/40472

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #12 from Eike Rathke  ---
Further thinking: if so that probably would involve that ScModule::GetClipDoc()
returns a document that is not the actual clipboard document but an ordinary
one, most likely the source document itself, which would be even weirder..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #11 from Eike Rathke  ---
Nothing suspicious so far. With the commit Raal identified and a screenshot he
sent me, I suspect that under some unknown circumstances
ScDocument::IsClipboardSource() returns true when it should not (which is the
only possibility where the identified commit comes into play). There is one
step in the reproduction scenario, copying A10 to the clipboard when A4 was
already copied, where the first clipboard document is destroyed and
ScDocument::IsClipboardSource() is called.

Now, if someone who can reproduce the bug and has debug capabilities could set
a breakpoint in sc/source/core/data/documen2.cxx ScDocument::~ScDocument() on
the call to IsClipboardSource(), then after having copied A4 already when
copying A10 into the clipboard the breakpoint should be hit. Stepping into
IsClipboardSource() it should not return true, but if it does it would be good
to know why and what made it think it should..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #10 from Buovjaga  ---
Created attachment 134465
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134465=edit
Valgrind log from master, A10 as the source of copying

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #9 from Eike Rathke  ---
Does the log for copying A10 and pasting to E10, I10 differ in anything
relevant for this case?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #8 from Buovjaga  ---
Created attachment 134462
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134462=edit
Valgrind log from master

This is a log of copying A4 and pasting to E4 and then to I4.

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha0+
Build ID: 98befbb26217b0bf3f35354e418a355280c52cfc
CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on June 29th 2017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #7 from Eike Rathke  ---
Fwiw, I can not reproduce (on Linux) in any version, 5.3.3, 5.3.4,
>=5.4.0.beta2 or master.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #6 from Eike Rathke  ---
(In reply to raal from comment #5)
> This seems to have begun at the below commit.
I doubt that. That code is executed only when closing a document that is the
clipboard source to forget the caption pointers pointing into that document's
drawing layer. The bug description doesn't involve closing the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||er...@redhat.com

--- Comment #5 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Eike Rathke; Could you possibly take a look at this one? Thanks


a3a754ba53116b1ed03ad493908db89e1d636451 is the first bad commit
commit a3a754ba53116b1ed03ad493908db89e1d636451
Author: Norbert Thiebaud 
Date:   Fri Feb 10 22:00:08 2017 -0800

source sha:cb566c056b0e8f9f73dac3cbaf497e102a247cb9

author  Eike Rathke   2017-01-18 15:18:38 (GMT)
committer   Eike Rathke   2017-01-18 15:19:09 (GMT)
commit  cb566c056b0e8f9f73dac3cbaf497e102a247cb9 (patch)
tree93ba07dd11cab7ef22778971959de3bc7694ee1d
parent  2fb220093f7178f75ebd582bbcd956c1ee7e03db (diff)
tdf#104967 prevent crash when pasting notes originating from a closed document
This is only a workaround to prevent a crash, the actual note content is lost
when pasting, only a standard empty note caption will be pasted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #4 from Buovjaga  ---
(In reply to stefan_lange...@t-online.de from comment #3)
> Created attachment 134320 [details]
> Screenshots of tests with LO 6.0 in Win10 and with LO 5.3.3 in Ubuntu
> 
> Maybe the bug exists only in Windows. I can reproduce the bug with the
> (nearly) newest builds of LO 6.0 in Win 10 (build 15063.413 64 bit, preview
> build 16226 32 bit and 64 bit), but not with LO 5.3.3 in Ubuntu, see
> screenshots in attached archive file "Screenshots_Bug_108612.tar.gz"!

No, as I said in my comment 1 I am seeing the problem on Linux, but only with
slightly different results/steps.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #3 from stefan_lange...@t-online.de  
---
Created attachment 134320
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134320=edit
Screenshots of tests with LO 6.0 in Win10 and with LO 5.3.3 in Ubuntu

Maybe the bug exists only in Windows. I can reproduce the bug with the (nearly)
newest builds of LO 6.0 in Win 10 (build 15063.413 64 bit, preview build 16226
32 bit and 64 bit), but not with LO 5.3.3 in Ubuntu, see screenshots in
attached archive file "Screenshots_Bug_108612.tar.gz"!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #2 from raal  ---
no repro. Version: 6.0.0.0.alpha0+
Build ID: 643da8ec4e721d33dfdf8d78bedd50a915f1188d
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-06-26_01:29:47

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Blocks||101216
 Ever confirmed|0   |1
 OS|Windows (All)   |All
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
I got different results: I got the wrong position after pasting to I*. When I
copied A10, it "reset" and only paste to I10 was wrong.

Yet: no problems at all in 3.6.

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha0+
Build ID: f808c50c6eece87d515df3b84b1c774395b5d9bc
CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on June 26th 2017

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
[Bug 101216] [META] Calc comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs