[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2019-09-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

Aron Budea  changed:

   What|Removed |Added

 Blocks||127300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127300
[Bug 127300] [META] Issues with import/export/display of Excel built-in defined
names
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2019-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #10 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/9d63c7035a86bb3a355433b567d2d8cd53d582fa%5E%21

tdf#115159 XLSX export: don't duplicate print titles

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2019-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2019-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #9 from László Németh  ---
@Áron: many thanks for the useful code pointers!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2019-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

László Németh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2019-03-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108897


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

Aron Budea  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #8 from Aron Budea  ---
Eike, here are my thoughts on this bug, but the big picture is still unclear,
can you please advise on how to approach it?

The immediate cause of this is that when exporting the built-in defined range,
it takes Excel's limits for colummns, which is 16384...

https://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/xename.cxx#613
// *** 2) print titles *** 
...


...then later, when XclExpNameManagerImpl::CreateName(...) is called, it checks
for an existing built-in range name, but also tries to match the range, which
is still 1024 here, so they won't match.
If the two matched, then as far as I can see, it would update the built-in
range based on the defined one. However, first it checks if the two token
arrays match... when could this work sensibly?

https://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/xename.cxx#555
/*  Try to replace by existing built-in name - complete token array is
needed for comparison, and due to the recursion problem above this
cannot be done earlier. If a built-in name is found, the created NAME
record for this name and all following records in the list must be
deleted, otherwise they may contain wrong name list indexes. */
sal_uInt16 nBuiltInIdx = FindBuiltInNameIdx( rName, *xTokArr );


It's not clear to me why the built-in named ranges are gathered both directly
from the respective spreadsheet settings, and also from regular named ranges
(as imported). Would it make sense to either only match based on names, or even
do away with the double handling of built-in names?

And indeed, when revisiting bug 112571 after its fix, as soon as the user
updates the print ranges, those names are duplicated again because of the
double handling and range-checking.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #7 from Kevin Suo  ---
Reproduced in
Version: 6.1.0.0.alpha0+
Build ID: 3a2a430ae8e2c1647c18d8904477949f6e2e7941
CPU threads: 4; OS: Linux 4.14; UI render: default; VCL: gtk3; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group threaded

Fedora 27 x64

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #6 from Gabor Kelemen  ---
Created attachment 139276
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139276&action=edit
The example file saved again by LO 6 RC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #5 from Gabor Kelemen  ---
Created attachment 139275
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139275&action=edit
The example file saved by LO 6 RC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #3 from Gabor Kelemen  ---
Created attachment 139273
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139273&action=edit
Print titles after first save

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #4 from Gabor Kelemen  ---
Created attachment 139274
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139274&action=edit
Print titles after second save

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #2 from Gabor Kelemen  ---
Created attachment 139272
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139272&action=edit
The example file saved again by LO 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

2018-01-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #1 from Gabor Kelemen  ---
Created attachment 139271
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139271&action=edit
The example file saved by LO 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs