[Libreoffice-bugs] [Bug 115931] ScFiltersTest:: testOrcusODSStyleInterface fails with liborcus 0.13.3

2018-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115931

--- Comment #5 from Olivier Tilloy  ---
Moved conversation to the mailing list:
https://lists.freedesktop.org/archives/libreoffice/2018-February/079531.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115931] ScFiltersTest:: testOrcusODSStyleInterface fails with liborcus 0.13.3

2018-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115931

--- Comment #4 from Olivier Tilloy  ---
I can do that for sure, but as soon as the dependency on liborcus is bumped to
0.13.3 it will become an issue in libreoffice, requiring changes in the
codebase.

So I'm not sure I agree it's not an issue in the software itself. It's just
that it hasn't manifested itself yet, but it eventually will.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115931] ScFiltersTest:: testOrcusODSStyleInterface fails with liborcus 0.13.3

2018-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115931

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |MOVED

--- Comment #3 from Xisco Faulí  ---
Hello Olivier,
Since this is an issue in the building system and not in the software itself,
would you mind sending an email to the dev mailing list instead adding Kohei as
Cc? -> https://wiki.documentfoundation.org/Development/Mailing_List

Setting as RESOLVED MOVED
Sorry for the inconveniences.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115931] ScFiltersTest:: testOrcusODSStyleInterface fails with liborcus 0.13.3

2018-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115931

--- Comment #2 from Olivier Tilloy  ---
Tentative patch (untested, might not be complete):

--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -839,7 +839,7 @@ void ScOrcusStyles::fill::applyToItemSet
 return;
 }

-rSet.Put(SvxBrushItem(maBgColor, ATTR_BACKGROUND));
+rSet.Put(SvxBrushItem(maFgColor, ATTR_BACKGROUND));
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115931] ScFiltersTest:: testOrcusODSStyleInterface fails with liborcus 0.13.3

2018-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115931

--- Comment #1 from Olivier Tilloy  ---
https://github.com/LibreOffice/core/commit/20945a9a4de6684010fd5b3603595e6da543807d
mentions that liborcus 0.13.3 is expected to have the correct ODF styles, so I
assume the unit tests will have to be updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs