[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #7 from Caolán McNamara  ---
I think the len check is actually good. Its that we're using null terminated
strings here and expect that we can add a zero at the end, which is possible in
this specific case, but not in the general case if that field has filled with a
number > the buffer size. So this has headed off disaster in the general case.

For the specific case I think what we can do is to rework this to not need to
add a null terminator and just build an OUString directly from the known length

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

--- Comment #6 from Julien Nabet  ---
(In reply to Jack O'Sullivan from comment #5)
> Hey guys, thanks for the quick work on this, look forward to testing it out
> properly on 6.1.

It's not fixed yet. The patch which has been pushed is just to add some trace.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

--- Comment #5 from Jack O'Sullivan  ---
Hey guys, thanks for the quick work on this, look forward to testing it out
properly on 6.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|

--- Comment #4 from Julien Nabet  ---
Let's remove target since it's just adding some warn log.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

--- Comment #3 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5bf410957994ec2acfec1fddb822934ed0965820

Related tdf#116999: log the exception (filter/icgm)

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

--- Comment #2 from Julien Nabet  ---
Created attachment 141351
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141351=edit
pdf generated

Jack: thought you might be interested in retrieving the pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116999] Libreoffice command line interface is not opening cgm files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116999

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||caol...@redhat.com,
   ||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Caolán: after some gdb session, I saw that the pb was due to 
187 if (static_cast(mpEndValidSource -
(mpSource + mnParaSize)) <= nSize)
188 throw css::uno::Exception("attempt to read past end
of input", nullptr);
from filter/source/graphicfilter/icgm/class4.cxx

If revert partially 34a7a7ff426dac55d62fc357cebbc0b22cd65c06 by replacing "<="
by "<" it works, pdf is created.

Any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs