[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #19 from Drew Jensen  ---
(In reply to MM from comment #17)
> With Version: 6.2.0.0.alpha0+
> Build ID: c4c56de1b0e62ec866b519b2b24c5e805f0a86d3
> CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
> TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
> 2018-06-09_00:23:35
> Locale: en-US (en_US.UTF-8); Calc: threaded
> 
> it doesn't crash anymore, but the patch has some side effects.
> The picture from attachment 141910 [details] is gone now if you migrate. And
> if you add a new image (any), it will also disappear when closing /
> reopening form 'tbl_varbinary'.

Right, but this issue was just about the application becoming non-responsive,
that is fixed. 

The image disappearing is a separate issue, but even that is ancillary. 

There is a question as to how valid the test file is. Not that you can't store
an image that way in the hsqldb version of Base, the file itself shows you can,
but whether it is how anyone is using it. (it would be less than optimal
performance wise).

These are two datatypes not directly found in the Firebird engine, and the
native firedbird datatype used in the new Firebird schema doesn't currently
support moving data in and out via an image control. But again that is a
separate issue, and someone should open it. ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #18 from Julien Nabet  ---
(In reply to MM from comment #17)
> ...
> it doesn't crash anymore, but the patch has some side effects.
> The picture from attachment 141910 [details] is gone now if you migrate. And
> if you add a new image (any), it will also disappear when closing /
> reopening form 'tbl_varbinary'.

Difficult to tell if it's a side effect since before the patch, there was a
hang (or I missed something). I had noticed the disappearing of image too but I
don't know why. At least the patch fixed the hang.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #17 from MM  ---
With Version: 6.2.0.0.alpha0+
Build ID: c4c56de1b0e62ec866b519b2b24c5e805f0a86d3
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-06-09_00:23:35
Locale: en-US (en_US.UTF-8); Calc: threaded

it doesn't crash anymore, but the patch has some side effects.
The picture from attachment 141910 is gone now if you migrate. And if you add a
new image (any), it will also disappear when closing / reopening form
'tbl_varbinary'.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

Drew Jensen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Drew Jensen  ---
yes, the attached file and two others which did previously no longer do.

test with
Version: 6.1.0.0.beta1+
Build ID: b57819201ff89bbde14b4df8c02a0eb4bea2c2bb
Branch:libreoffice-6-1, Time: 2018-06-04_04:41:46

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #15 from Xisco Faulí  ---
LibreOffice doesn't hang in

Version: 6.1.0.0.beta1+
Build ID: 8b96445766efe237eb47608ade6c147673466e2e
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

@Julien, @Drew Jensen, Since this issue is about Libreoffice hanging, should it
be closed as RESOLVED FIXED ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[ VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #14 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=570279baa7df076413cc6b4f9220a07248db0c1b=libreoffice-6-1

tdf#117446: FB mig, (VAR)BINARY, fix memory management

It will be available in 6.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[ VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.2.0|target:6.2.0 target:6.1.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[ VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #13 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=54ddc4ff4c2ff7e8b2c502d6b475cfdc9b8e3cec

tdf#117446: FB mig, (VAR)BINARY, fix memory management

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[ VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[ VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #12 from Drew Jensen  ---
Excellent

So there is two new problems here:
First in firbird that column could be up to 32K in size ( and max data would be
32k - 2 bytes IIRC)
Second - with the current migration assistant it creates a column type that is
unrecognized and unusable by any current Base data control. The user can
connect to a text control or an image control, either way the data is either
lost when you try to insert it, mangled or irretrievable.

However, if you do connect an image control to one of these migration assistant
created column and open an image less then 8000 bytes in size it appears to
write something to the table. If you try to export that data, to Writer for
example, what you get is that value x0 and nothing else.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[ VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

--- Comment #11 from Julien Nabet  ---
For information, I submitted for review on gerrit the patch quoted in comment
7, see https://gerrit.libreoffice.org/#/c/54863/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117446] Firebird: Migration: LibO hangs with data type Binary[ VARBINARY] OR Binary(fix)[BINARY] AND data in hsql column exceeds new column size ( 8000 bytes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117446

Drew Jensen  changed:

   What|Removed |Added

Summary|Firebird: Migration: LibO   |Firebird: Migration: LibO
   |hangs with data type|hangs with data type
   |Binary[VARBINARY] OR|Binary[VARBINARY] OR
   |Binary(fix)[BINARY] AND |Binary(fix)[BINARY] AND
   |data in hsql database over  |data in hsql column exceeds
   |8000 bytes  |new column size ( 8000
   ||bytes )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs