[Libreoffice-bugs] [Bug 118647] MacOS: Some system dictionaries are missing

2018-07-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118647

Xisco FaulĂ­  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |t...@iki.fi
   |desktop.org |
 CC||xiscofa...@libreoffice.org

--- Comment #5 from Xisco FaulĂ­  ---
Patch for 6-1: https://gerrit.libreoffice.org/#/c/57226/1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118647] MacOS: Some system dictionaries are missing

2018-07-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118647

Telesto  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

--- Comment #4 from Telesto  ---
Didn't expect a fix so soon ;-). Many thanks for that! 

And even more for 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3b6905e37a6baac08eaff00e6e42aced7d6896df
LibreOffice is now blazing fast; Super!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118647] MacOS: Some system dictionaries are missing

2018-07-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118647

--- Comment #3 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d66df262ee4fd8abc794ef9ef764a182b0da29ea

tdf#118647: Improve handling of system spell dictionaries on macOS

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118647] MacOS: Some system dictionaries are missing

2018-07-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118647

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118647] MacOS: Some system dictionaries are missing

2018-07-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118647

--- Comment #2 from Tor Lillqvist  ---
Suggested fix in https://gerrit.libreoffice.org/#/c/57220/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118647] MacOS: Some system dictionaries are missing

2018-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118647

Tor Lillqvist  changed:

   What|Removed |Added

Summary|MacOS: system dictionaries  |MacOS: Some system
   |are missing |dictionaries are missing

--- Comment #1 from Tor Lillqvist  ---
Caused by 69c8e9a0607e9a197dfff8139f2ca14c2538da8a (and the corresponding
cherry-pick to the 6.1 branch). The languages with system dictionaries are (for
me, on 10.13.5) as follows. This is a list from adding debug output to
MacSpellChecker::getLocales() in
lingucomponent/source/spellcheck/macosxspell/macspellimp.mm:

lang:'en' country:'GB'
lang:'en' country:''
lang:'en' country:'AU'
lang:'en' country:'IN'
lang:'en' country:'SG'
lang:'en' country:'CA'
lang:'en' country:'JP'
lang:'sv' country:''
lang:'fi' country:''
lang:'da' country:''
lang:'de' country:''
lang:'es' country:''
lang:'fr' country:''
lang:'it' country:''
lang:'nl' country:''
lang:'nb' country:''
lang:'pl' country:''
lang:'pt' country:'BR'
lang:'pt' country:'PT'
lang:'tr' country:''
lang:'ru' country:''
lang:'ko' country:''

In the Character dialogue I do see the marker indicating that a spelling
dictionary is present for languages in the above list that have a non-empty
country in the above list. For instance "English (India)". And the "fr"
apparently gets interpreted by LO as "French (France)". But indeed no German is
there.

If I add a similar check for plain "de" as there already is for "en", then
"German (Germany)" does get the spell check marker.

>else if (lang == "de" && country.isEmpty())
>country = "DE";

I guess the equivalent would need to be done for all the languages in the list
without a country. or then just expand each such language without territory to
all the combinations that LO knows. Will do the latter.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs