[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 tommy27 changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #15 from tommy27 --- retested using LibO 7.1.5.2 autocorrect now takes just 4 seconds to load a huge autocorrect replacement table. issue is finally solved thanks to anyone who fixed it RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 tommy27 changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3874 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #14 from tommy27 --- latest test using LibO 7.0.4.2 under Win10x64 loading a huge autocorrect replacement table (probably 300K entries) takes 18 seconds the computer has an Inter Core i5-8400 CPU @ 2.80GHz, 16GM RAM and an SSD disk, so it's not a bad machine. basically the performance is stable from previous tests using the 6.4.x branch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 tommy27 changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0635 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |3700| CC||tele...@surfxs.nl --- Comment #13 from V Stuart Foote --- *** Bug 133700 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 tommy27 changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3700 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #12 from tommy27 --- relevant or not relevant, I can tell that situations is better in 6.4.1 now the loading takes 16 seconds on the same computer of my previous benchmark. still slower than 5.3.6 (5 secs) and 6.1.6 (10 secs) but faster tha 6.3.4 (20 seconds) probably this has been a positive side effect of some other code tweak. having said that, I hope that some developer will one day address this annoying performance issue. Stuart's insights about the code refactoring look interesting. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #11 from V Stuart Foote --- (In reply to tommy27 from comment #10) > ... > this shows that there has been a consistent performance drop loading large > autocorrect lists. > > whilst 5.3.x was very fast, 6.1.x is twice slower, and 6.3.x 4 times > slower... And again those are totally irrelevant as benchmarks. Assuming continued UX agreement that supporting auto-correct tables of 200,000 or more entries is needed (and I think it is) this enhancement would require refactoring of the 'AutoCorrect Options...' dialog for populating the widgets on its 'Replace' tab. That refactoring could take several tracts. My preference would be to test for autocorrect list size, and for greater than ~3000 entries use a fixed entry, just dump the pairs into the widget unmeasured. Give up some visual precision for load speed. Not pretty, just fast. But possibly provide a different 'mode' for large (> 3000) autocorrect tables, presumably in its own thread. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #10 from tommy27 --- retested and compared between different LibO versions on a different Win10 x64 than my original tests. loading times are respectively: LibO 5.3.6 -> 5 seconds Lib 6.1.6 -> 10 seconds LibO 6.3.4 -> 20 seconds LibO 7.0.0.0.alpha0+ -> 20 seconds this shows that there has been a consistent performance drop loading large autocorrect lists. whilst 5.3.x was very fast, 6.1.x is twice slower, and 6.3.x 4 times slower... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #9 from Julien Nabet --- (In reply to Heiko Tietze from comment #7) > (In reply to V Stuart Foote from comment #5) > ... > In a nutshell: >200ms - busy pointer, >1s - progress bar with a proper time > estimation (don't proceed to 1%, wait, and jump to 95%) and the possibility > to cancel the operation. Operation that takes minutes should ideally run in > a separate thread. These numbers depend entirely on the power of your pc so even if you take into account pc not older than 10 years, you can have old CPUs with 4Go RAM Anyway, autocorrect should perhaps be in a separate thread. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #8 from Julien Nabet --- (In reply to tommy27 from comment #6) > (In reply to V Stuart Foote from comment #4) >... > think about people with dyslexia or hand movement impairments... they > heavily rely on autocorrect. What about having a limited size by default and propose 200k size as an extension or a kind of option like accessibility, high contrast theme, etc. ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #7 from Heiko Tietze --- (In reply to V Stuart Foote from comment #5) > Seems a subject for UX review, not the GUI but the user expectation. Here is what I wrote for KDE some time ago https://hig.kde.org/components/assistance/progress.html. Also quite good is the MS guideline https://docs.microsoft.com/en-us/windows/win32/uxguide/progress-bars In a nutshell: >200ms - busy pointer, >1s - progress bar with a proper time estimation (don't proceed to 1%, wait, and jump to 95%) and the possibility to cancel the operation. Operation that takes minutes should ideally run in a separate thread. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #6 from tommy27 --- (In reply to V Stuart Foote from comment #4) > > > > So at this point (6.3 & master/6.4) we have users who have assembled > abusively large (~200K entry) AutoCorrect replacement lists given a best > case latency of 15 - 20 seconds in opening the tool. As compared to 5 second > openings in the past. > > ... think about people with dyslexia or hand movement impairments... they heavily rely on autocorrect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 V Stuart Foote changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #5 from V Stuart Foote --- Seems a subject for UX review, not the GUI but the user expectation. Pretty certain we had inherited the unbounded correction list from OOo era, and that our GUI formatting of listbox has now unintentionally reduced usability of this previously functional "feature". How the project handles this going forward should be deliberated as a UX issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #4 from V Stuart Foote --- @Caolán, was that a scolding? ;-) But doesn't the issue summary say it all? We have situation of latency in opening/reopening the AutoCorrect dialog. Previously supported usage has allowed for a user to open the dialog interactively to assemble 'text strings' and associated shortcuts as a writing aid. If they had "boiler plate" to capture for reuse--throw it into the AutoCorrect dialog. Multiple variations? No problem throw them in with each with a different shortcut string. The project even did the same thing--we put the entire :emoji: entry feature and localized it into the AutoCorrect dialog. So at this point (6.3 & master/6.4) we have users who have assembled abusively large (~200K entry) AutoCorrect replacement lists given a best case latency of 15 - 20 seconds in opening the tool. As compared to 5 second openings in the past. It now is opened visually correctly, but even with recent optimizations Noel did, it is just too slow. Do we force the user to edit back their correction list, cap the counts? If not, can we again accommodate their hefty usage by sacrificing visual precision of the listbox display for performance? And at what count should the threshold be? To me seems like anything above 3,000 --so that our deployed correction lists will format visually correctly-- and any count beyond that could be allowed to be "sloppy". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 Buovjaga changed: What|Removed |Added Keywords||perf Summary|slower loading of large |Improve loading of large |autocorrect lists |autocorrect lists Severity|normal |enhancement --- Comment #3 from Buovjaga --- Changing to enhancement, so the nature of this is clear. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
