[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #7 from V Stuart Foote  ---
Corrected with

Version: 7.0.0.0.alpha1+ (x64)
Build ID: b587de60d4e6aa96238766272d94f1499b22f696
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; 
Locale: en-US (en_US); UI: en-US
Calc: threaded

But may still need to cleanup the listed icon paths for the Sidebar, comment 2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

--- Comment #6 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/3ac066a585c781e0cb6e7fa7ae6a3c1107839dce

Colibre: tdf#133250 inconsisten colors icons

It will be available in 6.4.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.0.0|target:7.0.0 target:6.4.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

--- Comment #5 from V Stuart Foote  ---
(In reply to Rizal Muttaqin from comment #4)
> ...
> So what is the problem here? Sorry I do not get it. I just see 
> 
> ...

More a side bar to the visual glitch here of the bad icon mix.

Point is the Bitmap::Adjust functions have some very specific behaviors
applying filter transforms and replacing a source graphic (raster or vector).
Seems the UI should expose the full set of controls (with a cohesive set of
icons) for each of the MUFFIN modes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

--- Comment #4 from Rizal Muttaqin  ---
(In reply to V Stuart Foote from comment #3)
> (In reply to V Stuart Foote from comment #2)
> > 
> > Icons assigned to the six values for the VCL Bitmap:Adjust [1][2], Colibre
> > had a mix of icons in use. And in SVX also used the sc_ size [3].
> 
> s/six/seven
> 
> luminance, contrast, red, green, blue, gamma, brightness
> 
> Suspect the NB color sections that use these controls should probably
> include all 7 (exclude the 3 colors--so icons don't show on the NB).

So what is the problem here? Sorry I do not get it. I just see 

- Six functions with standard toolbar UI (under Color toolbar):Red, Blue,
Green, Brightness, Contrast, Gamma.

- Four functions in the Image tab with Tabbed UI: Brightness, Transparency,
Contrast, Gamma.

- Eight functions in the Sidebar Image Properties with four of them have no
icons: Brightness, Contrast, Color mode and Transparency and remaining four
with icons: Red, Green, Blue, Gamma

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

--- Comment #3 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #2)
> 
> Icons assigned to the six values for the VCL Bitmap:Adjust [1][2], Colibre
> had a mix of icons in use. And in SVX also used the sc_ size [3].

s/six/seven

luminance, contrast, red, green, blue, gamma, brightness

Suspect the NB color sections that use these controls should probably include
all 7 (exclude the 3 colors--so icons don't show on the NB).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

V Stuart Foote  changed:

   What|Removed |Added

 CC||kain...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
https://gerrit.libreoffice.org/c/core/+/94653

Icons assigned to the six values for the VCL Bitmap:Adjust [1][2], Colibre had
a mix of icons in use. And in SVX also used the sc_ size [3].

And do the hard coded icon paths need clean up also? [4,5,6] 

=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/bitmap3.cxx?r=c7e07cc7=1000#999
[2]
https://opengrok.libreoffice.org/xref/core/include/vcl/bitmap.hxx?r=e3cc7b94#469

[3]
https://opengrok.libreoffice.org/xref/core/svx/inc/bitmaps.hlst?r=473e9720#277

[4,5,6]
https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/sidebargraphic.ui?r=387200f2#200

https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/sidebargraphic.ui?r=387200f2#243

https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/sidebargraphic.ui?r=387200f2#287

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

--- Comment #1 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/defdbb87a67e2a48ecebf28d71e9b9576ef67c1e

Colibre: tdf#133250 inconsisten colors icons

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

Rizal Muttaqin  changed:

   What|Removed |Added

 Blocks||117497


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117497
[Bug 117497] [META] Colibre icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133250] Colibre: Inconsistent Icon for Red, Blue and Green

2020-05-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133250

Rizal Muttaqin  changed:

   What|Removed |Added

Summary|Colibre Inconsistent Icon   |Colibre: Inconsistent Icon
   |for Red, Blue and Green |for Red, Blue and Green

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs